From e02c83e3d93d5ec4d7b2bacc7dd816ee6b3b4209 Mon Sep 17 00:00:00 2001
From: YuAng <angshineee@gmail.com>
Date: Fri, 18 Jun 2021 00:51:26 +0800
Subject: [PATCH] Update indoor testing scripts.

---
 configs/loftr/indoor/scannet/loftr_ds_eval.py | 15 +++++++++++++++
 scripts/reproduce_test/indoor_ds.sh           |  2 +-
 scripts/reproduce_test/indoor_ot.sh           |  1 -
 scripts/reproduce_test/outdoor_ot.sh          |  1 -
 4 files changed, 16 insertions(+), 3 deletions(-)
 create mode 100644 configs/loftr/indoor/scannet/loftr_ds_eval.py

diff --git a/configs/loftr/indoor/scannet/loftr_ds_eval.py b/configs/loftr/indoor/scannet/loftr_ds_eval.py
new file mode 100644
index 0000000..3b6255f
--- /dev/null
+++ b/configs/loftr/indoor/scannet/loftr_ds_eval.py
@@ -0,0 +1,15 @@
+""" A config only for reproducing the ScanNet evaluation results.
+
+We remove border matches by default, but the originally implemented
+`remove_border()` has a bug, leading to only two sides of
+all borders are actually removed. However, the [bug fix](https://github.com/zju3dv/LoFTR/commit/e9146c8144dea5f3cbdd98b225f3e147a171c216)
+makes the scannet evaluation results worse (auc@10=40.8 => 39.5), which should be
+caused by tiny result fluctuation of few image pairs. This config set `BORDER_RM` to 0
+to be consistent with the results in our paper.
+"""
+
+from src.config.default import _CN as cfg
+
+cfg.LOFTR.MATCH_COARSE.MATCH_TYPE = 'dual_softmax'
+
+cfg.LOFTR.MATCH_COARSE.BORDER_RM = 0
diff --git a/scripts/reproduce_test/indoor_ds.sh b/scripts/reproduce_test/indoor_ds.sh
index 1128930..86df40f 100755
--- a/scripts/reproduce_test/indoor_ds.sh
+++ b/scripts/reproduce_test/indoor_ds.sh
@@ -8,7 +8,7 @@ export PYTHONPATH=$PROJECT_DIR:$PYTHONPATH
 cd $PROJECT_DIR
 
 data_cfg_path="configs/data/scannet_test_1500.py"
-main_cfg_path="configs/loftr/indoor/loftr_ds.py"
+main_cfg_path="configs/loftr/indoor/scannet/loftr_ds_eval.py"
 ckpt_path="weights/indoor_ds.ckpt"
 dump_dir="dump/loftr_ds_indoor"
 profiler_name="inference"
diff --git a/scripts/reproduce_test/indoor_ot.sh b/scripts/reproduce_test/indoor_ot.sh
index fddf2bb..11e31a8 100755
--- a/scripts/reproduce_test/indoor_ot.sh
+++ b/scripts/reproduce_test/indoor_ot.sh
@@ -26,4 +26,3 @@ python -u ./test.py \
     --batch_size=${batch_size} --num_workers=${torch_num_workers}\
     --profiler_name=${profiler_name} \
     --benchmark 
-    
\ No newline at end of file
diff --git a/scripts/reproduce_test/outdoor_ot.sh b/scripts/reproduce_test/outdoor_ot.sh
index 83d6320..961f2bc 100755
--- a/scripts/reproduce_test/outdoor_ot.sh
+++ b/scripts/reproduce_test/outdoor_ot.sh
@@ -26,4 +26,3 @@ python -u ./test.py \
     --batch_size=${batch_size} --num_workers=${torch_num_workers}\
     --profiler_name=${profiler_name} \
     --benchmark 
-    
\ No newline at end of file