protobuf

Commit Graph

Author	SHA1	Message	Date
Protobuf Team Bot	3784ba1959	Fix stack overflow on self-recursive messages with pybind11 There is a special case where message factories can be confused: if a module written in C++ with pybind11 links against a self-recursive message, and that message is part of another message loaded from Python, then the confusion will happen. Example: # This one is also linked into the C++ module. message SelfRecursive { optional SelfRecursive self_recursive = 1; } # This one is used only in Python and not linked. message OnlyUsedInPython { optional SelfRecursive self_recursive = 2; } The caching through message_factory::RegisterMessageClass then happens on one instance of the factory, but traversal with the lookup in another. This occurs in the pure Python and upb implementations that have their own default descriptor pools (and thus message factory). Fix this by using the already passed message factory to registering the message class to cache. A test accounts for this case to avoid regressions. PiperOrigin-RevId: 642551744	6 months ago
Protobuf Team Bot	4a5660c889	Automated rollback of commit `4dc164884c`. PiperOrigin-RevId: 642058565	6 months ago
Mike Kruskal	4dc164884c	Automated rollback of commit `e1bf1f048e`. PiperOrigin-RevId: 640697358	6 months ago
Protobuf Team Bot	e1bf1f048e	Update rules_python to 0.28.0 Closes #15849 PiperOrigin-RevId: 640633756	6 months ago
Protobuf Team Bot	e595749c9c	Reenable FFI tests on CRuby. PiperOrigin-RevId: 640188804	6 months ago
Protobuf Team Bot	475158ef61	Internal change PiperOrigin-RevId: 639885959	6 months ago
Sandy Zhang	ce026abf92	Work around windows path length limitations by moving immutable -> full in open source (new generator paths) and shortening long file names. Re-enable windows bazel test. PiperOrigin-RevId: 633224191	7 months ago
Mike Kruskal	be99767a69	Clear repository cache between bazel runs PiperOrigin-RevId: 632621361	7 months ago
Sandy Zhang	94cf1e9446	Add 27.x to staleness check PiperOrigin-RevId: 631532649	7 months ago
Bastien Jacot-Guillarmod	7b3682fcf2	Pin the rev of googletest to the GitHub main branch PiperOrigin-RevId: 630417312	7 months ago
Seth Vargo	4f23cafa02	Cancel in-progress workflow runs for pull requests and dispatches (#16601 ) This will reduce unnecessary resource consumption by cancelling running workflows when new commits are pushed to a PR or workflow dispatch. It does not cancel pushes to main or branches. Closes #16601 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/16601 from sethvargo:sethvargo/actions-concurrency `82fd070dba` PiperOrigin-RevId: 629805311	7 months ago
Mike Kruskal	b28d9d4144	Migrate bazel tests to protobuf-ci. This will allow them to reuse our bazelrc and remote caching setup. This also silences the non-bzlmod windows test that's hitting the windows path length. PiperOrigin-RevId: 626390416	7 months ago
Mike Kruskal	89118ba9d4	Fix bazel cache issues in 7.0.0 We're seeing a high flake rate due to remote cache-misses only on Bazel 7 builds. The key change here seems to be adding the remote_download_output flag, but this also upgrades us to 7.1.1 and adds some retry behavior to caching issues. PiperOrigin-RevId: 625892332	7 months ago
Jason Lunn	801049a43e	Update JRuby from 9.4.3.0 to 9.4.6.0. (#16381 ) Closes #16381 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/16381 from protocolbuffers:jruby_9.4.6.0 `e9d1244efa` PiperOrigin-RevId: 621364008	8 months ago
Mike Kruskal	a916d447c0	Update dependency on setup-php PiperOrigin-RevId: 621030474	8 months ago
Mike Kruskal	b497787aef	Enable visionos tests after GH runner update PiperOrigin-RevId: 620965206	8 months ago
Alex Eagle	71e4061ace	feat: test bzlmod usage on CI (#16319 ) Closes #16319 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/16319 from protocolbuffers:bcr `d66845cfcb` PiperOrigin-RevId: 619939078	8 months ago
Adam Cozzette	0641202bcc	Fix syntax error in test_objectivec.yml I'm not sure why exactly but GitHub Actions is complaining about the reference to `matrix.PLATFORM`. Let's just delete that and the visionos builds until we're ready to turn visionos back on. PiperOrigin-RevId: 617922287	8 months ago
Mike Kruskal	61a079ff0b	Automated rollback of commit `c076f9d874`. PiperOrigin-RevId: 617678321	8 months ago
YoloMao	c076f9d874	ci: add visionOS pod lib lint check (#15903 ) as title Closes #15903 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/15903 from YoloMao:feat/visionos_support `62474c592c` PiperOrigin-RevId: 617382097	8 months ago
Mike Kruskal	6898451f5e	Setup upb installation with cmake. This installs a upb's static library, headers, and three protoc plugin binaries (upb, upbdefs, upb_minitable). These will now be enabled by default, but can be disabled by setting protobuf_BUILD_LIBUPB=OFF. To qualify this, we hook into our existing install test infrastructure which attempts to build and run our tests without any of the installation artifacts available from the source tree. Public headers are deleted, and builds of exported libraries/binaries are disabled. PiperOrigin-RevId: 617376961	8 months ago
Mike Kruskal	0176f8a72a	Downgrade our sanitized builds to ubuntu-20. The latest github runner image of ubuntu-22 includes a kernel update that breaks the sanitizers we use in our docker images. Long-term, we'll likely need to upgrade the images to new sanitizers and clang. PiperOrigin-RevId: 616319042	9 months ago
Mike Kruskal	c17b102148	Disable TSAN tests due to what appears to be a sanitizer bug PiperOrigin-RevId: 616138585	9 months ago
Mike Kruskal	b6032d72e3	Add basic upb cmake support. libupb will always be statically linked, and currently doesn't ever install itself. PiperOrigin-RevId: 615136389	9 months ago
Sandy Zhang	9a262c2091	Update setup-php to 2.30.0 and re-enable macOS PHP 8.2 tests. setup-php 2.30.0 should fix https://github.com/shivammathur/setup-php/issues/823 PiperOrigin-RevId: 612882408	9 months ago
Sandy Zhang	360531cd08	Drop Ruby 2.7. This updates the required ruby version to >= 3.0 and removes Ruby 2.7 tests from main branch, in anticipation for end of Ruby 2.7 support on 3/31 in 27.x See https://cloud.google.com/ruby/getting-started/supported-ruby-versions PiperOrigin-RevId: 612841114	9 months ago
Mike Kruskal	119e71c40a	Run C# tests with non-Bazel protobuf-ci actions. The Bazel action currently isn't setup to regenerate the proto gencode itself, meaning that it won't actually be running on changes in the pending PR. Long-term, we should migrate this back to Bazel after enabling proto codegen properly. PiperOrigin-RevId: 611238217	9 months ago
Mike Kruskal	bda13f3bfa	Add back error message unconditionally PiperOrigin-RevId: 611105036	9 months ago
Mike Kruskal	fc6adb6c0e	Actually fail if staleness fail PiperOrigin-RevId: 610833812	9 months ago
Mike Kruskal	396e26b475	Enable C++ tests for Bazel 7 on mac PiperOrigin-RevId: 610573579	9 months ago
Mike Kruskal	4dc2c07025	Disable Mac PHP 8.2 test PiperOrigin-RevId: 610520746	9 months ago
Adam Cozzette	8ca628db61	Update error message to clarify what needs to happen for tests to run When we get a pull request from outside the protobuf repository, the tests will not run until a protobuf team member adds the `safe for tests` tag. This change updates the error message to make it more clear what has to happen to get the tests to run. Fixes #15847. PiperOrigin-RevId: 608660908	9 months ago
Sandy Zhang	2f9b5e1204	Add 26.x to staleness checks PiperOrigin-RevId: 606443838	10 months ago
Sandy Zhang	9252b64ef3	Automated rollback of commit `0ee34d35de`. PiperOrigin-RevId: 603802046	10 months ago
Mike Kruskal	54931ca45e	Disable test that seems to be using pre-Java 8 PiperOrigin-RevId: 603746010	10 months ago
Thomas Van Lenten	a892c20578	[ObjC] Re-enable watchOS cocoapods validations The image used for this actions has a new enough CocoaPods that this should now work. PiperOrigin-RevId: 601855822	10 months ago
Mike Kruskal	f6812b7d6d	Bump python version to 3.9 for gcloud 460.0.0 PiperOrigin-RevId: 599953322	10 months ago
Sandy Zhang	3c8a3d27f7	Raise minimum PHP version to 8.1, due to PHP 8.0 EOL per https://cloud.google.com/php/getting-started/supported-php-versions Drops tests for PHP 8.0, and adds tests for PHP 8.3. See https://www.php.net/supported-versions.php. PiperOrigin-RevId: 599636473	10 months ago
Protobuf Team Bot	1581e72425	Disable linkage-monitor test in anticipation of a breaking (major version) java release: 4.26 PiperOrigin-RevId: 597629358	11 months ago
Marcel Hlopko	648c20d602	Pass crate mapping from Bazel to protoc This will enable us to get the correct crate names for Rust gencode. The actual reading of the mapping file in protoc happens in the followup. PiperOrigin-RevId: 597509582	11 months ago
Eric Salo	33080e9917	upb: disable the Fast Table CI tests on GH PiperOrigin-RevId: 597310347	11 months ago
Adam Cozzette	a7b0421c78	Breaking change: make protobuf comply with the C++ layering check This check enforces that each C++ build target has the correct dependencies for all headers that it includes. We have many targets that were not correct with respect to this check, so I fixed them up. I also cleaned up the C++ targets related to the well-known types. I created a cc_proto_library() target for each one and removed the :wkt_cc_protos target, since this was necessary to satisfy the layering check. I deleted the //src/google/protobuf:protobuf_nowkt target and deprecated :protobuf_nowkt, because the distinction between the :protobuf and :protobuf_nowkt targets was not really correct. Neither one exposed the headers for the well-known types in a way that was valid with respect to the layering check, and the idea of bundling all the well-known types together is not idiomatic in Bazel anyway. This is a breaking change, because the //:protobuf target no longer bundles the well-known types. From now on they should be accessed through the new //:*_cc_proto aliases in our top-level package. I renamed the :port_def target to :port, which simplifies things a bit by matching our internal name. The original motivation for this change was that to move utf8_range onto our CI infrastructure, we needed to make its dependency rules_fuzzing compatible with Bazel 6. The rules_fuzzing project builds with the layering check, and I found that the process of upgrading it to Bazel 6 made it take a dependency on protobuf, which caused it to break due to layering violations. I was able to work around this, but it would still be nice to comply with the layering check so that we don't have to worry about this kind of thing in the future. PiperOrigin-RevId: 595516736	11 months ago
Mike Kruskal	807f00b4db	Fix typo in cache-clearing workflow PiperOrigin-RevId: 595424484	11 months ago
Sandy Zhang	0317875286	Update Ruby GHA to test against Ruby 3.3 in Linux / MacOS / Install and FFI combinations. PiperOrigin-RevId: 594132729	11 months ago
Joshua Haberman	36bb6fb0dd	Disable MacOS C++ Cmake test for now. PiperOrigin-RevId: 594102279	11 months ago
Sandy Zhang	2f7b2832b6	Update Ruby GHA to test against Ruby 3.3. Fixes #15182 PiperOrigin-RevId: 593899707	11 months ago
Sandy Zhang	9f96118e1e	Pin bundler version to 2.4.22 for Ruby 2.7 support. Latest bundler 2.5.0 release results in the following error: `The last version of bundler (>= 0) to support your Ruby & RubyGems was 2.4.22. Try installing it with gem install bundler -v 2.4.22 bundler requires Ruby version >= 3.0.0. The current ruby version is 2.7.3.183.` PiperOrigin-RevId: 591288515	12 months ago
Mike Kruskal	eea39d6f53	Add Bazel 7 test points. This adds tests for C++ under linux, and windows, and upb on linux. PiperOrigin-RevId: 591056302	12 months ago
dependabot[bot]	92619cdd43	Bump ossf/scorecard-action from 2.1.2 to 2.3.1 (#14554 ) Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.2 to 2.3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ossf/scorecard-action/releases">ossf/scorecard-action's releases</a>.</em></p> <blockquote> <h2>v2.3.1</h2> <h2>What's Changed</h2> <ul> <li>🌱 Bump github.com/ossf/scorecard/v4 from v4.13.0 to v4.13.1 by <a href="https://github.com/spencerschrock"><code>@spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1282">ossf/scorecard-action#1282</a> <ul> <li>Adds additional Fuzzing detection and fixes a SAST bug related to detecting CodeQL. For a full changelist of what this includes, see the <a href="https://github.com/ossf/scorecard/releases/tag/v4.13.1">v4.13.1</a> release notes</li> </ul> </li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/ossf/scorecard-action/compare/v2.3.0...v2.3.1">https://github.com/ossf/scorecard-action/compare/v2.3.0...v2.3.1</a></p> <h2>v2.3.0</h2> <h2>What's Changed</h2> <ul> <li>🌱 Bump github.com/ossf/scorecard/v4 from v4.11.0 to v4.13.0 by <a href="https://github.com/spencerschrock"><code>@spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1270">ossf/scorecard-action#1270</a> <ul> <li>For a full changelist of what this includes, see the <a href="https://github.com/ossf/scorecard/releases/tag/v4.12.0">v4.12.0</a> and <a href="https://github.com/ossf/scorecard/releases/tag/v4.13.0">v4.13.0</a> release notes</li> </ul> </li> <li>✨ Send rekor tlog index to webapp when publishing results by <a href="https://github.com/spencerschrock"><code>@spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1169">ossf/scorecard-action#1169</a></li> <li>🐛 Prevent url clipping for GHES instances by <a href="https://github.com/rajbos"><code>@rajbos</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1225">ossf/scorecard-action#1225</a></li> </ul> <h3>Documentation</h3> <ul> <li>📖 Update access rights needed to see the results in code scanning by <a href="https://github.com/rajbos"><code>@rajbos</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1229">ossf/scorecard-action#1229</a></li> <li>📖 Add package comments. by <a href="https://github.com/spencerschrock"><code>@spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1221">ossf/scorecard-action#1221</a></li> <li>📖 Add SECURITY.md file by <a href="https://github.com/david-a-wheeler"><code>@david-a-wheeler</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1250">ossf/scorecard-action#1250</a></li> <li>📖 Fix typo in token input docs by <a href="https://github.com/aabouzaid"><code>@aabouzaid</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1258">ossf/scorecard-action#1258</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/david-a-wheeler"><code>@david-a-wheeler</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1250">ossf/scorecard-action#1250</a></li> <li><a href="https://github.com/aabouzaid"><code>@aabouzaid</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1258">ossf/scorecard-action#1258</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/ossf/scorecard-action/compare/v2.2.0...v2.3.0">https://github.com/ossf/scorecard-action/compare/v2.2.0...v2.3.0</a></p> <h2>v2.2.0</h2> <h2>What's Changed</h2> <ul> <li>🌱 Bump github.com/ossf/scorecard/v4 from v4.10.5 to v4.11.0 by <a href="https://github.com/spencerschrock"><code>@spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1192">ossf/scorecard-action#1192</a></li> </ul> <h2>Scorecard Result Viewer</h2> <p>Thanks to contributions from <a href="https://github.com/cynthia-sg"><code>@cynthia-sg</code></a> and <a href="https://github.com/tegioz"><code>@tegioz</code></a> at <a href="https://github.com/cncf/clomonitor">CLOMonitor</a>, there is a new Scorecard Result visualization page at <code>https://securityscorecards.dev/viewer/?uri=<project-url></code>.</p> <ul> <li><a href="https://redirect.github.com/ossf/scorecard-webapp/pull/406">ossf/scorecard-webapp#406</a></li> <li><a href="https://redirect.github.com/ossf/scorecard-webapp/pull/422">ossf/scorecard-webapp#422</a></li> </ul> <p>As an example, you can see our own score visualized <a href="https://securityscorecards.dev/viewer/?uri=github.com/ossf/scorecard">here</a> Checkout our <a href="`08b4669551/README.md (scorecard-badge)`">README</a> to learn how to link your README badge to the new visualization page.</p> <h2>Publishing Results</h2> <p>This release contains two fixes which will improve the user experience when <code>publish_results</code> is <code>true</code></p> <ul> <li>Runs that fail our <a href="`08b4669551/README.md (workflow-restrictions)`">workflow restrictions</a> will fail with a 400 response indicating the problem, instead of a vague 500 status. (<a href="https://redirect.github.com/ossf/scorecard-action/pull/1156">ossf/scorecard-action#1156</a>, resolved <a href="https://redirect.github.com/ossf/scorecard-action/issues/1150">ossf/scorecard-action#1150</a>)</li> <li>Scorecard action will retry when signing results and submitting them to our web API. This should help with flakiness from connection failures. (<a href="https://redirect.github.com/ossf/scorecard-action/pull/1191">ossf/scorecard-action#1191</a>)</li> </ul> <h2>Docs</h2> <ul> <li>📖 Update README to accept fine-grained tokens by <a href="https://github.com/pnacht"><code>@pnacht</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1175">ossf/scorecard-action#1175</a></li> <li>📖 Update installation instructions to match current GitHub UI by <a href="https://github.com/joycebrum"><code>@joycebrum</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1153">ossf/scorecard-action#1153</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="`0864cf1902`"><code>0864cf1</code></a> 🌱 Bump docker tag to for v2.3.1 release (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1284">#1284</a>)</li> <li><a href="`72df3bff66`"><code>72df3bf</code></a> 🌱 Bump github.com/ossf/scorecard/v4 from v4.13.0 to v4.13.1 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1282">#1282</a>)</li> <li><a href="`0ea411f94a`"><code>0ea411f</code></a> 🌱 Bump the docker-images group with 1 update (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1281">#1281</a>)</li> <li><a href="`dbfd042453`"><code>dbfd042</code></a> 🌱 Bump the github-actions group with 1 update (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1280">#1280</a>)</li> <li><a href="`2fa1e2fa15`"><code>2fa1e2f</code></a> 🌱 Bump golang.org/x/net from 0.16.0 to 0.17.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1278">#1278</a>)</li> <li><a href="`652ddd06c8`"><code>652ddd0</code></a> 🌱 Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1277">#1277</a>)</li> <li><a href="`28d0c92b8b`"><code>28d0c92</code></a> 🌱 Group Dependabot updates for GitHub Actions and Dockerfiles (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1276">#1276</a>)</li> <li><a href="`cb50491a46`"><code>cb50491</code></a> 🌱 Bump distroless/base from <code>a35b652</code> to <code>b31a6e0</code> (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1275">#1275</a>)</li> <li><a href="`87157ac77d`"><code>87157ac</code></a> 🌱 Bump github/codeql-action from 2.21.9 to 2.22.1 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1274">#1274</a>)</li> <li><a href="`7c1648b23e`"><code>7c1648b</code></a> 🌱 Bump step-security/harden-runner from 2.5.1 to 2.6.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1273">#1273</a>)</li> <li>Additional commits viewable in <a href="`e38b1902ae...0864cf1902`">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ossf/scorecard-action&package-manager=github_actions&previous-version=2.1.2&new-version=2.3.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Closes #14554 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14554 from protocolbuffers:dependabot/github_actions/ossf/scorecard-action-2.3.1 `543f85ba25` PiperOrigin-RevId: 581438189	1 year ago
Mike Kruskal	8699fde0a9	Enable upb editions conformance testing. This also cleans up some pre-existing bugs and adds a Fasttable/ASAN build. PiperOrigin-RevId: 581408568	1 year ago

1 2 3 4 5 ...

308 Commits (fe6963970c8c4ac582dbefe3b7ee4ebb251dd803)