protobuf

Commit Graph

Author	SHA1	Message	Date
Joshua Haberman	8370818143	Switch to a macro to avoid signed/const mismatches.	4 years ago
Joshua Haberman	8f3ee80d46	Drop C89/C90 support and MSVC prior to Visual Studio 2015. upb previously attempted to support C89 and pre-2015 versions of Visual Studio. This was to support older compilers with limited C99 support (particularly MSVC). But as of last August, even gRPC has dropped support for MSVC prior to 2015 `c87276d058` Therefore it seems safe for upb to no longer attempt C89 support (we were already not truly C89 compliant, with our use of "bool"). We now explicitly require C99 or greater and MSVC 2015 or greater. This cleaned up port_def.inc a fair bit. I took the chance to also remove some obsolete macros.	4 years ago
Joshua Haberman	504e105420	undef UPB_ASAN.	4 years ago
Joshua Haberman	d5096f9ee8	Fixed bug in addunknown and added ASAN poisoning.	4 years ago
Igor Kostenko	f7fcc0df37	Fix divide by zero vs2019 compilation error #293 (#294 ) * Fix divide by zero vs2019 compilation error * undef introduced define	5 years ago
Joshua Haberman	2b1e7dc1cc	Arena refactor: moves cleanup list into regular blocks (#277 ) * WIP. * WIP. * Tests are passing. * Recover some perf: LIKELY doesn't propagate through functions. :( * Added some more benchmarks. * Simplify & optimize upb_arena_realloc(). * Only add owned blocks to the freelist. * More optimization/simplification. * Re-fixed the bug. * Revert unintentional changes to parser.rl. * Revert Lua changes for now. * Revert the arena fuse changes for now. * Added last_size to the arena representation. * Fixed compile errors. * Fixed compile error and changed benchmarks to do one allocation.	5 years ago
Joshua Haberman	08b6d2d6fd	Rewrite of the decoder (#263 ) New code is smaller (in both source size and compiled size) and faster. # Speed The decoder speeds up on all machines I tested, though the amount of speedup varies. I was only able to test Intel CPUs. ### Linux Desktop ``` CPU: Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz OS: Linux name old time/op new time/op delta CreateArena 4.72ns ± 0% 4.93ns ± 0% +4.47% (p=0.000 n=11+11) ParseDescriptor 12.4µs ± 1% 9.1µs ± 1% -26.65% (p=0.000 n=11+11) ``` ### Mac Laptop ``` CPU: Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz OS: macOS name old time/op new time/op delta CreateArena 5.33ns ± 3% 5.58ns ± 2% +4.69% (p=0.000 n=12+12) ParseDescriptor 15.0µs ± 2% 11.9µs ± 2% -20.20% (p=0.000 n=12+12) ``` ### Linux Workstation ``` CPU: Intel(R) Xeon(R) Gold 6154 CPU @ 3.00GHz OS: Linux name old time/op new time/op delta CreateArena 5.29ns ± 0% 5.52ns ± 0% +4.37% (p=0.000 n=10+12) ParseDescriptor 18.6µs ± 0% 16.4µs ± 0% -11.54% (p=0.000 n=12+12) ``` # Size A few source files grow marginally because of some arena functionality moved inline. But `upb/decode.c` shrinks by 30% on Linux: ``` VM SIZE -------------- +2.1% +283 upb/json_decode.c +24% +205 upb/msg.c +8.4% +115 upb/upb.c +0.9% +28 upb/reflection.c [ = ] 0 upb/def.c [ = ] 0 upb/encode.c [ = ] 0 upb/json_encode.c [ = ] 0 upb/table.c -30.3% -1.51Ki upb/decode.c -0.7% -738 TOTAL ```	5 years ago
Joshua Haberman	a6c54729df	Added UPB_ASSUME(), to work around warnings when optimization is enabled: upb/json/parser.rl: In function 'end_member.isra.150': bazel-out/k8-opt/bin/upb.c:5536:13: error: 'sel' may be used uninitialized in this function [-Werror=maybe-uninitialized] upb_func ret = (upb_func )h->table[s].func;	5 years ago
Joshua Haberman	2a85bef825	Generated code interface for maps is complete, though not yet tested.	5 years ago
Esun Kim	7a1e6aa84b	Support MSVC prior to 2015	6 years ago
Joshua Haberman	cf35baa1ad	Moved macros from upb.h to port_def.inc to avoid leaking them to users. (#160 ) * Use port_def.inc to prevent macros from leaking to users. * Added helpful comments to port_def.inc/port_undef.inc.	6 years ago
Joshua Haberman	33d1231ead	Added port_def.inc and port_undef.inc.	7 years ago

12 Commits (f104225a1e92adb8f2c4710cc8a26113fe55db17)