With gcc (tested versions: 11.3.0, 12.2.0) compiled with asan, the
`type_id` variable is warned about maybe being used uninitialized in
the later call:
```
ptr = ParseFieldMaybeLazily(static_cast<uint64_t(type_id) * 8 + 2, ptr,
extendee, metadata, ctx);
```
This change initializes the variable to a defined default.
PiperOrigin-RevId: 507883964
This has the consequence of removing the path filter, but allows us to actually use these test results as presubmits. Since these are relatively cheap tests, this seems like a better situation. A future enhancement may restore path filters to these and other tests.
PiperOrigin-RevId: 507872208
Include option to skip it if it was installed.
https://github.com/tuist/xcbeautify would also be an option (it supports bazel to),
but we'd have to install it.
PiperOrigin-RevId: 507852912
The `BuildInParallel` flag only controls parallelism at the *project* level, while `/MP` enables it at the *compilation unit* level.
PiperOrigin-RevId: 507837073
This slows down the build and hasn't had an issue in a really long time. The
support is still there, so it can be manually run at any time from within Xcode.
PiperOrigin-RevId: 507810543
This uses ccache + github caching to substantially decrease the time it takes to run XCode builds. Due to Bazel caching, these are some of our slowest tests, causing one of the biggest presubmit bottlenecks
PiperOrigin-RevId: 507794241
This uses ccache + github caching to substantially decrease the time it takes to run CMake builds. Due to Bazel caching, these are some of our slowest tests, causing one of the biggest presubmit bottlenecks
PiperOrigin-RevId: 507667813
The ABSL logging check seems to prevent the compiler from seeing
that comparing values for equality is equivalent if comparing
with a signed or unsigned zero literal...
Fixes: #11743
PiperOrigin-RevId: 507010435
Fix the macro PROTOBUF_LITTLE_ENDIAN cannot be set correctly on the little endian QNX.
Signed-off-by: wugaoyin <1132954336@qq.com>
Closes#11750
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/11750 from WuGaoyin:main 09ec1a19e9
PiperOrigin-RevId: 506979012
Fix the macro PROTOBUF_LITTLE_ENDIAN cannot be set correctly on the little endian QNX.
Signed-off-by: wugaoyin <1132954336@qq.com>
Closes#11750
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/11750 from WuGaoyin:main 09ec1a19e9
PiperOrigin-RevId: 506979012
Since *.inc is not a common filename suffix, editors and
other tools might not recognize these as c++ and would
not offer language speficific features such as
syntax-highlighting.
This uses the commonly used -*- c++ -*- annotation recongized
by many tools.
PiperOrigin-RevId: 506953120
Pull the first index with jq instead of looking for "main"
Git add all artifacts since "git commit -a" doesn't add new ones
PiperOrigin-RevId: 506933714
Pull the first index with jq instead of looking for "main"
Git add all artifacts since "git commit -a" doesn't add new ones
PiperOrigin-RevId: 506933714
It is intended to remove some push/pops and unify the common path
Diff:
https://gcc.godbolt.org/z/4f8a9zsjW
For 64 bit we got rid of extra push/pop. For 32 we think less register pressure and shld is better than ror+test+js. No push/pops. Fun fact that top 32 of 64 bits of intermediate result can be polluted with ones, that does not matter for final assignment of resulting pair
PiperOrigin-RevId: 506846358
This no longer served its original purpose and was actually testing an *older* version of MacOS than the rest of our test suite. This did lock down CMake builds on Mac though, so we'll keep that coverage.
PiperOrigin-RevId: 506776948
Mike Kruskal
Protobuf Team Bot
Deanna Garcia
deannagarcia
Sandy Zhang
WuGaoyin
Adam Cozzette