protobuf

18108 Commits

201 Branches

346 Tags

254 MiB

Tag: Branch: Tree: e3fa6aac29

Commit Graph

Author	SHA1	Message	Date
Jakob Buchgraber	8cdc700b5b	Implement ctype=CORD for singular string & byte fields - We introduce two new view types ProtoStringCow and ProtoBytesCow. - In UPB, for cord field accessors we always return a Cow::Borrowed. - In C++, for coed field accessors we check if the underlying absl::Cord is flat (contigous) and if so return a Cow::Borrowed. If it's not flat we copy the data to a ProtoString and return a Cow::Owned. - We expect the absl::Cord to be flat almost all the time. We have experimentally verified that for small strings (<4 KiB) and less than 6 appends the cord is in fact flat [1]. - This change lifts the requirement of all ViewProxy types to be Copy. Our Cow types cannot be Copy because the owned types aren't copy. [1] https://source.corp.google.com/piper///depot/google3/experimental/users/buchgr/cords/cords.cc PiperOrigin-RevId: 655485943	4 months ago

Author

SHA1

Message

Date

Jakob Buchgraber

8cdc700b5b

Implement ctype=CORD for singular string & byte fields

- We introduce two new view types ProtoStringCow and ProtoBytesCow.
 - In UPB, for cord field accessors we always return a Cow::Borrowed.
 - In C++, for coed field accessors we check if the underlying absl::Cord is flat (contigous) and if so return a Cow::Borrowed. If it's not flat we copy the data to a ProtoString and return a Cow::Owned.
   - We expect the absl::Cord to be flat almost all the time. We have experimentally verified that for small strings (<4 KiB) and less than 6 appends the cord is in fact flat [1].
 - This change lifts the requirement of all ViewProxy types to be Copy. Our Cow types cannot be Copy because the owned types aren't copy.

[1] https://source.corp.google.com/piper///depot/google3/experimental/users/buchgr/cords/cords.cc

PiperOrigin-RevId: 655485943

4 months ago

1 Commits (e3fa6aac29f72e27f9db73db26fb71f24509ab7c)