protobuf

Commit Graph

Author	SHA1	Message	Date
Alyssa Haroldsen	035d6ec2cb	Implement map iteration PiperOrigin-RevId: 604447996	1 year ago
Alyssa Haroldsen	a48090e329	Make map insert return if the value was newly inserted PiperOrigin-RevId: 603481207	1 year ago
Marcel Hlopko	d21425d334	Use consistent thunk prefix between generator and cpp.rs PiperOrigin-RevId: 602644203	1 year ago
Marcel Hlopko	39e8ca7faf	Add support for repeated strings/bytes PiperOrigin-RevId: 599822292	1 year ago
Jakob Buchgraber	85972e505a	#rust #protobuf Implement bytes as map values We now support fields with bytes as map values e.g. map<i32, bytes>. The implementation for the C++ runtime was straightforward. The majority of the changes in this CL are about the UPB runtime. In UPB, when we insert Rust bytes/string into the map we need to first copy the bytes onto the maps arena. To support this I have rewritten the macro that implements the ProxiedInMapValue types. I refactored the functionality to convert between UPB and Rust types into the 'UpbTypeConversions' trait. This trait has a function 'to_message_value_if_required' which does the copying for bytes and strings. PiperOrigin-RevId: 599118416	1 year ago
Jakob Buchgraber	8d9e3e9a1c	#rust #protobuf Refactor maps to make ProxiedInMapValue independent of the runtime - ProxiedInMapValue is defined in maps.rs, and no longer in the runtime files {upb, cpp}.rs. - ProxiedInMapValue's methods accept and return Proxied types. - InnerMapMut no longer has any generic type parameters. - Through this refactoring the Map type is no longer a ZST. Creating a new map is now as simple as `Map::new()`. PiperOrigin-RevId: 597765165	1 year ago
Protobuf Team Bot	9d749cd5b0	Change Thunks that take by ref to take by pointer. PiperOrigin-RevId: 592525870	1 year ago
Alyssa Haroldsen	f51182b543	Add RepeatedMut::clear, free for owned Repeated PiperOrigin-RevId: 591046913	1 year ago
Jakob Buchgraber	976029283f	Implement Maps for strings This change implements maps with keys and values of type string e.g. Map<ProtoStr, i32> and Map<ProtoStr, ProtoStr>. Implementing the Map type for ProtoStr has been different from scalar types because ProtoStr is an unsized type i.e. its size is not known at compile time. The existing Map implementation assumed sized types in many places. To make unsized types fit into the existing code architecture I have added an associated type 'Value' to the MapWith*KeyOps traits. The associated type needs to be sized and is the type returned by the Map::get(self, key) method e.g. for aProtoStr, the `type Value = &ProtoStr`. PiperOrigin-RevId: 588783751	1 year ago
Jakob Buchgraber	001be3c655	Implement Maps for scalar types for the C++ kernel This CL implements Maps for scalar types for the C++ runtime. It's orthogonal to cl/580453646. This CL is constrained by having to force template instantiation of proto2::Map<K, V>. Put differently, a Rust protobuf::Map<K, V> implementation needs to call 'extern "C"' functions with both key and value type in the function name (e.g. __pb_rust_Map_i32_f64_get()). We use macros to generate a Map implementation for every (K,V)-pair. An alternative would have been to use vtables. Luckily a key in a protobuf map can only be integer types, bool and string. So the number of key types is bounded by the specification, while the number of value types is not i.e. any protobuf message can be a value in a map. Given these constraints we introduce one 'MapKeyOps' trait per key type e.g. MapKeyBOOLOps or MapKeyI32Ops. These traits need to be implemented for every value type e.g. 'impl MapKeyBOOLOps for i32' will implement 'Map::<bool, i32>'. In particular the MapKeyOps traits can also be implemented for generated messages without violating the orphan rule. This CL also contains significant changes to the UPB runtime so that both upb.rs and cpp.rs export a similar interface to simplify the implementation in map.rs and the generated code. This CL does not yet implement the Proxied trait. PiperOrigin-RevId: 582951914	1 year ago
Kevin King	65cdac4ac5	Finish Proxied impls for rust repeated scalars PiperOrigin-RevId: 575935874	1 year ago
Protobuf Team Bot	e1bb7d65a8	Implement rust repeated scalars for cpp and upb PiperOrigin-RevId: 574261929	1 year ago

12 Commits (e26193d16868bcdb2616f551b6a17f8d641dddc4)