de84e20788
Merge branch 'master' into optdefload
4 years ago
d5c64476fd
Merge pull request #318 from haberman/descriptor-load-benchmark
...
Benchmarks for descriptor loading time.
4 years ago
42d2f6cef9
Add MB/s measures in the benchmarks.
...
Current output on my machine is:
-----------------------------------------------------------------------------------------
Benchmark Time CPU Iterations
-----------------------------------------------------------------------------------------
BM_ArenaOneAlloc 21 ns 21 ns 33344552
BM_ArenaInitialBlockOneAlloc 6 ns 6 ns 115948084
BM_LoadDescriptor_Upb 107286 ns 107275 ns 6512 67.5731MB/s
BM_LoadDescriptor_Proto2 240539 ns 240537 ns 2909 30.1362MB/s
BM_ParseDescriptor_Upb_LargeInitialBlock 11500 ns 11499 ns 60864 630.377MB/s
BM_ParseDescriptor_Upb 11920 ns 11920 ns 58676 608.123MB/s
BM_ParseDescriptor_Proto2_NoArena 31338 ns 31336 ns 22389 231.325MB/s
BM_ParseDescriptor_Proto2_Arena 21622 ns 21622 ns 32472 335.26MB/s
BM_ParseDescriptor_Proto2_Arena_LargeInitialBlock 17799 ns 17798 ns 39266 407.288MB/s
BM_SerializeDescriptor_Proto2 4943 ns 4942 ns 141050 1.43252GB/s
BM_SerializeDescriptor_Upb 12262 ns 12261 ns 57131 591.195MB/s
4 years ago
1ce98b86ec
Added LoadDescriptor benchmark for proto2.
4 years ago
4890735ce2
Added benchmark for descriptor loading.
4 years ago
6f59f1256e
Optimizations to descriptor loading.
4 years ago
6874d61704
Merge pull request #317 from haberman/gencode-compat
...
Compatibility with old generated code
4 years ago
c81113e60f
Added fallback code for when no enum matches.
4 years ago
c10b24ffb2
Simplified switch().
4 years ago
ded2e657a7
Added compatibility with old generated code.
...
Until everyone can regenerate their code, we need to provide
compatible semantics with the old generated code.
Also fixed a bug where enums were allocated 8 bytes instead
of 4.
4 years ago
8bd5c0088e
Merge pull request #316 from haberman/submsg-array
...
Fixed bug where submsg array could have excess elements.
4 years ago
a4966fd230
Added a few extra sanity checks.
4 years ago
99acbe0da8
Fixed bug where submsg array could have excess elements.
...
Before we were allocating an array element for every sub-message
field, even if two different fields had messages of the same type.
4 years ago
2a0425ecf5
Merge pull request #315 from haberman/conformance-fixes
...
Updated to a new version of protobuf and fixed a few conformance tests.
4 years ago
7ccf5650c7
If we encounter "null" for a non-NullValue enum, throw an error.
4 years ago
0a3a94a12f
Updated to a new version of protobuf and fixed a few conformance tests.
...
When `google.protobuf.NullValue` appears on its own, we need to parse
and serialize it as plain JSON "null" value.
4 years ago
ddd5f28c4f
Merge branch 'is_bazel'
4 years ago
10fa3a0c77
Merge pull request #314 from haberman/addunknown
...
Fixed bug in addunknown and added ASAN poisoning.
4 years ago
504e105420
undef UPB_ASAN.
4 years ago
ab96d1ec41
Removed extraneous C++-style comment.
4 years ago
d5096f9ee8
Fixed bug in addunknown and added ASAN poisoning.
4 years ago
6fe84526be
Mark _is_bazel to be replace in google3.
4 years ago
d1cd80385b
Merge pull request #313 from haberman/inline-arena
...
Inline arena for the duration of the decode.
4 years ago
2339fc779c
Updated obsolete comment.
4 years ago
ebe53f8590
Fixed compile error.
4 years ago
71749b7caf
Implemented inline array allocation, and moved type->lg2 map to reflection.
4 years ago
b58d2a0ee6
Shrink overhead of message representation.
4 years ago
d87ceeacab
Shave off one more store.
4 years ago
c25d895adf
Shrunk the arena state that needs to be synced.
4 years ago
ff40dd6ea9
Added new internal header.
4 years ago
cbcd635917
Fixed memory leak.
4 years ago
e5264bd794
Merge pull request #312 from haberman/defiter
...
Added simple offset-based accessors for defs, and deprecated old iterators
4 years ago
746f64692c
Moved arena inline for decoder.
4 years ago
b8ef1dcc57
Removed C++-style comments.
4 years ago
575acd85bd
Re-added const for all of the pointer wrapper types.
4 years ago
5aa5b77b41
Added simple offset-based accessors for defs, and deprecated old iterators.
4 years ago
33384301e2
Merge pull request #311 from haberman/proto2-benchmark2
...
Benchmarks vs. proto2
4 years ago
bc301e7da4
Use merge/partial variants to give proto2 benchmark the fairest hearing.
4 years ago
30f01afa83
Added LargeInitialBlock test for proto2.
4 years ago
5d23fd99af
Used shorter protobuf:: namespace alias.
4 years ago
02ff6fb996
Merge pull request #309 from haberman/decoder-forceinline
...
Add UPB_FORCEINLINE for varint32 decoding.
4 years ago
a202ce9629
Add UPB_FORCEINLINE for varint32 decoding.
...
This speeds up the decoder by >20% and also reduces code size slightly!
name old time/op new time/op delta
ArenaOneAlloc 20.4ns ± 0% 20.2ns ± 0% -1.10% (p=0.000 n=12+11)
ArenaInitialBlockOneAlloc 5.25ns ± 0% 5.25ns ± 0% ~ (p=0.786 n=11+12)
ParseDescriptorNoHeap 17.1µs ± 0% 13.1µs ± 0% -23.29% (p=0.000 n=11+12)
ParseDescriptor 17.4µs ± 1% 13.5µs ± 1% -22.51% (p=0.000 n=12+12)
SerializeDescriptor 10.7µs ± 0% 10.9µs ± 0% +1.95% (p=0.000 n=12+12)
FILE SIZE VM SIZE
-------------- --------------
+2.7% +16 +2.7% +16 [LOAD #2 [RX]]
+0.5% +16 [ = ] 0 [Unmapped]
-1.4% -72 -0.7% -32 upb/decode.c
+3.1% +98 +3.1% +98 decode_msg
[DEL] -170 [DEL] -130 decode_varint32
-0.0% -40 -0.0% -16 TOTAL
4 years ago
d0f2c4c8a2
Merge pull request #308 from haberman/encoder
...
Optimized the binary encoder for a 2x speedup
4 years ago
5741eb9ad7
Expanded benchmarking script and added one size opt to the encoder.
4 years ago
0135399e60
Fixed bug introduced in refactoring.
4 years ago
df3438222b
Notated impossible branch as unreachable.
4 years ago
9b31e8fe12
Merged common encode tag paths.
4 years ago
5d7dc718cc
Minor formatting fix.
4 years ago
80441e4eb4
Optimized binary encoder.
4 years ago
ada28896b9
Changed encoder to use longjmp() for error recovery.
4 years ago
Joshua Haberman