Alyssa Haroldsen
4696ac71ca
Rename 'a to 'msg in message gencode
...
PiperOrigin-RevId: 599325506
1 year ago
Alyssa Haroldsen
ab8b762941
Use `self` for all methods on views, return `'msg`
...
View is Copy, and so it can preserve the lifetime of itself
when accessing any fields.
PiperOrigin-RevId: 599323122
1 year ago
Sandy Zhang
7c2e9c10d8
Add include for absl/str_cat.h
1 year ago
Protobuf Team Bot
fe6a601598
Auto-generate files after cl/599313198
1 year ago
Eric Salo
7c5ff29979
upb: add upb_MiniTableExtension_CType()
...
PiperOrigin-RevId: 599313198
1 year ago
Protobuf Team Bot
8eb7c63ee7
Correct conformance_cpp to use the requested message type for JSON tests.
...
Before this fix it incorrectly always used the Proto3 test message.
PiperOrigin-RevId: 599285917
1 year ago
Hong Shin
808487918c
Initialize scaffolding for ProxiedWithPresence for Messages
...
We want to return $pb$::FieldEntry<'_, $msg_type$> for msg_mut accessors as opposed to the current state (returning $Msg$Mut directly).
In this CL, we pave the way to implementing field entry returns.
We introduce { MessagePresentMutData, MessageAbsentMutData } and impl { ProxiedWithRawVTable, ProxiedWithRawOptionalVTable }. I initially tried a blanket impl approach, but it collided with the already existing PrimitiveVTable constructs; perhaps worth revisiting post 0.6.
In a followup, we'll flesh out the bodies. Lastly, we'll perform the swapover by
replacing $field$_mut with $field$_entry, updating all related tests.
PiperOrigin-RevId: 599282850
1 year ago
Alyssa Haroldsen
e16dd47999
Implement IntoIterator for &Repeated{View,Mut}
...
googletest matchers use this. Unfortunately, we still can't
use `elements_are!` with them:
https://github.com/google/googletest-rust/issues/351
PiperOrigin-RevId: 599281808
1 year ago
Alyssa Haroldsen
19851968bb
Fix indentation of a macro in simple_nested_test.rs
...
Looks like rustfmt doesn't do it automatically.
PiperOrigin-RevId: 599271261
1 year ago
Sandy Zhang
734e8e6adf
Update sha hash to match new absl commit
1 year ago
Sandy Zhang
c0ab33b520
Update to latest absl RC 20240116.rc1
1 year ago
Kevin King
9bd8dfa639
Add Repeated<Message> accessors
...
Shares logic with Repeated<Scalar> accessors.
PiperOrigin-RevId: 599263714
1 year ago
Protobuf Team Bot
b04a213326
Auto-generate files after cl/599244388
1 year ago
Kevin King
a19ce5b002
Move repeated_scalar.cc to repeated_field.cc
...
Repeated scalars and messages can share the same accessor code.
PiperOrigin-RevId: 599244388
1 year ago
Kevin King
df376c807c
Implement ProxiedInRepeated for Messages
...
PiperOrigin-RevId: 599241012
1 year ago
Protobuf Team Bot
27af4c802f
Auto-generate files after cl/599220883
1 year ago
Protobuf Team Bot
57a0ff8c92
Reserve and extension number in proto2.FeatureSet for Go
...
PiperOrigin-RevId: 599220883
1 year ago
Joshua Haberman
9188b39fb7
Shorten our license headers into an abbreviated form that references LICENSE instead of including it in full.
...
PiperOrigin-RevId: 599218886
1 year ago
Kevin King
b3639a0e9a
Add rust bindings for `upb_Array_GetMutable`
...
PiperOrigin-RevId: 599208395
1 year ago
Protobuf Team Bot
4773c091d2
Also emit the oneof accessors into $Msg$Mut and $Msg$View
...
PiperOrigin-RevId: 599199864
1 year ago
Joshua Haberman
50d0421170
Separate MiniTable code generator into a separate library target.
...
This will allow it to be linked into other code generators.
PiperOrigin-RevId: 599171495
1 year ago
Protobuf Team Bot
12e6af88e9
Auto-generate files after cl/599153141
1 year ago
Protobuf Team Bot
cd575718be
Update the r# prefixing logic:
...
- Only prepend r# to fields when needed instead of always
- Append '__mangled_because_symbol_is_a_rust_raw_identifier' to names like 'Self' which can't be used legally even with an r# prefix
Also use the same check to prepend r# on:
- Message names (eg `message Self {}`)
- oneof names
- oneof case names
- enum names
- enum case names
- module names (e.g. 'package google.type')
PiperOrigin-RevId: 599153141
1 year ago
Jakob Buchgraber
85972e505a
#rust #protobuf Implement bytes as map values
...
We now support fields with bytes as map values e.g. map<i32, bytes>. The implementation for the C++ runtime was straightforward. The majority of the changes in this CL are about the UPB runtime. In UPB, when we insert Rust bytes/string into the map we need to first copy the bytes onto the maps arena. To support this I have rewritten the macro that implements the ProxiedInMapValue types. I refactored the functionality to convert between UPB and Rust types into the 'UpbTypeConversions' trait. This trait has a function 'to_message_value_if_required' which does the copying for bytes and strings.
PiperOrigin-RevId: 599118416
1 year ago
Protobuf Team Bot
1fe463ce71
Avoid integer-to-pointer cast in protobuf SerialArena
...
PiperOrigin-RevId: 598966004
1 year ago
Protobuf Team Bot
dfc275fc1f
Auto-generate files after cl/598899738
1 year ago
Protobuf Team Bot
d716c2e963
Reuse Message's accessor definitions on Msg+MsgMut+MsgView
...
PiperOrigin-RevId: 598899738
1 year ago
Protobuf Team Bot
55820f2b22
Remove redundant [[noinline]].
...
Function implementation is defined out of line - having a noinline wrapper is just a pessimization.
PiperOrigin-RevId: 598886387
1 year ago
Protobuf Team Bot
deb2dff4e1
Progress towards reusing the same accessor definitions on Msg+MsgMut+MsgView
...
This adds private methods of:
-- .raw_msg() to Msg+MsgMut+MsgView
-- .raw_arena() to Msg+MsgMut [upb kernel only]
And updates the accessors to use the self.raw_msg() / self.raw_arena().
A couple more things will need to be changed before the accessors can be verbatim reused in Msg/MsgView/MsgMut which will be mailed separately.
PiperOrigin-RevId: 598869392
1 year ago
Marcel Hlopko
e4ae0c110f
Make rust_crate_mapping flag optional
...
If the flag is not passed, it means the current proto_library has no deps.
PiperOrigin-RevId: 598846330
1 year ago
Marcel Hlopko
88d991d310
Depend on all deps of a proto_library, not just the first
...
The code this is fixing was not done properly. This CL fixes it.
PiperOrigin-RevId: 598832639
1 year ago
Protobuf Team Bot
c12c96e194
Auto-generate files after cl/598741329
1 year ago
Eric Salo
72275ded70
upb: move upb_Message definition back into upb/message/
...
PiperOrigin-RevId: 598741329
1 year ago
Protobuf Team Bot
854ca49520
Internal versioning changes.
...
PiperOrigin-RevId: 598625150
1 year ago
Kevin King
7b42f1c08b
Add `Msg::as_{view,mut}()`
...
PiperOrigin-RevId: 597969809
1 year ago
Protobuf Team Bot
a37522001f
Auto-generate files after cl/597962426
1 year ago
Protobuf Team Bot
bc7c90f2c2
Internal Protobuf changes
...
PiperOrigin-RevId: 597962426
1 year ago
Alyssa Haroldsen
0a4c006a39
Return RepeatedMut<c_int> for cpp cast_enum_repeated_mut
...
PiperOrigin-RevId: 597950980
1 year ago
Alyssa Haroldsen
e7a224cd85
Support enums as oneof fields
...
PiperOrigin-RevId: 597950541
1 year ago
Protobuf Team Bot
9ce56e363c
Auto-generate files after cl/597923328
1 year ago
Eric Salo
8d0bfb0a5a
upb: delete upb:upb, upb:collections, upb/upb.hpp, upb/collections/
...
PiperOrigin-RevId: 597923328
1 year ago
Joshua Haberman
f2a91b33e1
Make `str(msg)` in Python print raw UTF-8 strings. Only invalid UTF-8 is escaped.
...
PiperOrigin-RevId: 597917280
1 year ago
Protobuf Team Bot
3a007b59ae
Internal versioning changes
...
PiperOrigin-RevId: 597906574
1 year ago
Protobuf Team Bot
6c4ea1fadb
Internal changes.
...
PiperOrigin-RevId: 597873923
1 year ago
Protobuf Team Bot
3b9bd6db71
Breaking Change: Remove unused overload of AbstractMessageLite.addAll that worked on a Collection instead of a List.
...
PiperOrigin-RevId: 597869849
1 year ago
Protobuf Team Bot
2f5305d7fe
Auto-generate files after cl/597850176
1 year ago
Marcel Hlopko
6860c38119
Read crate mapping in protoc
...
This enables us to get the correct crate names for Rust gencode.
PiperOrigin-RevId: 597850176
1 year ago
Protobuf Team Bot
9310d2e817
Breaking Change: Remove obsolete runtime internalBuildGeneratedFileFrom which was for backwards compatibility with old gencode.
...
Remove `sentinel.proto` and references to it.
This was announced in https://protobuf.dev/news/2023-12-05/ per our Cross-Version Runtime Guarantees: https://protobuf.dev/support/cross-version-runtime-guarantee/
PiperOrigin-RevId: 597849821
1 year ago
Protobuf Team Bot
e542443b53
Move the FieldInfoComment down into AccessorGenerator.
...
PiperOrigin-RevId: 597835662
1 year ago
Sandy Zhang
519284a559
Remove LegacyDescriptorsUtil.java and JRuby's use of legacy descriptor APIs
...
This is not a breaking change since this has not been released yet.
PiperOrigin-RevId: 597824548
1 year ago