protobuf

Commit Graph

Author	SHA1	Message	Date
Hong Shin	18ad79cdfd	hpb: Have ExtensionNumber take in const ref ExtensionIdentifier PiperOrigin-RevId: 694155074	4 months ago
Hong Shin	8eeee0e3ca	hpb: implement SetExtension for scalars i32 and i64 PiperOrigin-RevId: 693799584	4 months ago
Hong Shin	471d66961a	Introduce IsHpbClassThatHasExtensions EnableIfHpbClass was too restrictive in the past; it was toggled only if <T> was extended. This has been rectified to toggle if T extends T::Access, which reflects the true intention. PiperOrigin-RevId: 693368653	4 months ago
Hong Shin	4f6f2dd873	Implement GetExtension for numeric (int32 and int64) At the moment, hpb's public api solely returns Ptr<const Extension>. We'd like to support all non-msg types like int32, int64, bool etc. These should not return a Ptr<...> but the underlying primitive itself. We start by adding support for int32 and int64. PiperOrigin-RevId: 691490444	4 months ago
Hong Shin	350e24efa9	hpb: composition over inheritance - ExtensionIdentifier Have ExtensionIdentifier have a upb_MiniTableExtension* instead of subclassing a class that is just a plain holder for a upb_MiniTableExtension* with a getter with the same name We generally want to lean toward composition over inheritance. Without a compelling reason for inheritance, let's prefer composition for clarity, flexibility, and evolvability. Locking oneself into an inheritance hierarchy has marred many a codebase. PiperOrigin-RevId: 689380813	4 months ago
Hong Shin	6935e10f38	Make ExtensionIdentifier's constructor private PiperOrigin-RevId: 688214820	5 months ago
Protobuf Team Bot	007c93fa9c	Automated rollback of commit `9a3c096b0c`. PiperOrigin-RevId: 687291129	5 months ago
Hong Shin	9a3c096b0c	Make ExtensionIdentifier's constructor private PiperOrigin-RevId: 687065564	5 months ago
Hong Shin	6ecaefc628	Move GetExtension and ExtensionNumber from hpb.h to extension.h PiperOrigin-RevId: 684118480	5 months ago
Hong Shin	9bce530117	Move hpb::internal::{MoveExtension, SetExtension} and hpb::{MoveExtension, SetExtension} from hpb.h to extension.h This delta makes hpb.cc empty, and was therefore eliminated. PiperOrigin-RevId: 683606379	5 months ago
Hong Shin	73fe084436	Move out hpb::HasExtension and hpb::ClearExtension to extension.h PiperOrigin-RevId: 681576188	5 months ago
Hong Shin	1b44ce0fee	Extract hpb::ExtensionRegistry, hpb::internal::{ExtensionMiniTableProvider, ExtensionIdentifer} to extension.h PiperOrigin-RevId: 668643168	6 months ago

12 Commits (c4a4b1fd9f08866ff3c53e4e59ffebd3b7e1f16f)