protobuf

Commit Graph

Author	SHA1	Message	Date
Joshua Haberman	1711ebd455	Fixed Python memory leak in map lookup. Previously we were allocating memory on the message's arena every time we performed a `map[key]` or `map.get(key)` operation. This is unnecessary, as the key's data is only needed ephemerally, for the duration of the lookup, and we can therefore alias the Python object's string data instead of copying it. This required fixing a bug in the convert.c operation. Previously in the `arena==NULL` case, if the user passes a bytes object instead of a unicode string, the code would return a pointer to a temporary Python object that had already been freed, leading to use-after-free. I fixed this by referencing the bytes object's data directly, and using utf8_range to verify the UTF-8. Fixes: https://github.com/protocolbuffers/protobuf/issues/14571 PiperOrigin-RevId: 578563555	1 year ago
Joshua Haberman	b0eeb356b8	Fixed Python memory leak in map lookup. Previously we were allocating memory on the message's arena every time we performed a `map[key]` or `map.get(key)` operation. This is unnecessary, as the key's data is only needed ephemerally, for the duration of the lookup, and we can therefore alias the Python object's string data instead of copying it. This required fixing a bug in the convert.c operation. Previously in the `arena==NULL` case, if the user passes a bytes object instead of a unicode string, the code would return a pointer to a temporary Python object that had already been freed, leading to use-after-free. I fixed this by referencing the bytes object's data directly, and using utf8_range to verify the UTF-8. Fixes: https://github.com/protocolbuffers/protobuf/issues/14571 PiperOrigin-RevId: 578563555	1 year ago
Protobuf Team Bot	f083530a06	Allow string + bytes fields in oneofs (now that the underyling accessors match the expected shape) PiperOrigin-RevId: 578561161	1 year ago
Protobuf Team Bot	abdcd65246	Extract field descriptor enums into descriptor_lite.h, which can be included by protobuf_lite code. PiperOrigin-RevId: 578533045	1 year ago
Adam Cozzette	8defef58f4	Include .inc files directly instead of through a filegroup (#14575 ) gRPC auto-generates CMake and other build configs from the Bazel build graph, but the logic for doing this does not know how to handle filegroups. This change works around that problem by making the `:port` target refer directly to the `.inc` files instead of going through a filegroup. This solution is not ideal but I think it's probably the best way to unblock progress for now. PiperOrigin-RevId: 578333954	1 year ago
Adam Cozzette	712badffb1	Include .inc files directly instead of through a filegroup gRPC auto-generates CMake and other build configs from the Bazel build graph, but the logic for doing this does not know how to handle filegroups. This change works around that problem by making the `:port` target refer directly to the `.inc` files instead of going through a filegroup. This solution is not ideal but I think it's probably the best way to unblock progress for now. PiperOrigin-RevId: 578333954	1 year ago
Mike Kruskal	88249acbfd	Internal change PiperOrigin-RevId: 578290521	1 year ago
Alex Potsides	30f157529d	feat: add protons extension (#14505 ) Adds an extension id to the registry for use by the [protons](https://www.npmjs.com/package/protons) protobuf encoder/decoder. Closes #14505 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14505 from achingbrain:patch-1 `1a80ee9b56` PiperOrigin-RevId: 578254102	1 year ago
zhangskz	0a5d6d4a45	Check that ffi-compiler loads before using it to define tasks. (#14538 ) (#14560 ) Fixes #14509 Closes #14538 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14538 from JasonLunn:fix_14509 `a3f9d0bd4f` PiperOrigin-RevId: 577837541 Co-authored-by: Jason Lunn <jason.lunn@gmail.com>	1 year ago
Protobuf Team Bot	3667102d91	Remove `virtual` keyword. There are no overrides. PiperOrigin-RevId: 577881969	1 year ago
Eric Salo	e56a9099f0	upb: minimize uses of :message_types PiperOrigin-RevId: 577872176	1 year ago
Jason Lunn	6a16ab6147	Check that ffi-compiler loads before using it to define tasks. (#14538 ) Fixes #14509 Closes #14538 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14538 from JasonLunn:fix_14509 `a3f9d0bd4f` PiperOrigin-RevId: 577837541	1 year ago
Protobuf Team Bot	c9f9d99172	Use GetArena() instead of GetOwningArena() #6 . PiperOrigin-RevId: 577833979	1 year ago
Protobuf Team Bot	c8d2abe43d	Automated rollback of commit `d76a6300d2`. PiperOrigin-RevId: 577833443	1 year ago
Jakob Buchgraber	ebdd7e3eb6	Add private accessors for maps to be used by Rust's Map implementation. PiperOrigin-RevId: 577749942	1 year ago
Mike Kruskal	63f4c503a2	Editions: Embed resolved features of descriptor.proto for pure python. Because pure python builds all descriptors at runtime via reflection, it's unable to parse options during the build of descriptor.proto (i.e. before we've built the options schemas). We always lazily parse these options to avoid this, but that still means options can't be used during this build. Since the current build process makes heavy use of features (which previously just relied on syntax), this poses a problem for editions. To get around this, we just embed the resolved features directly into the gencode for this one file. This will allow us to skip feature resolution for these descriptors and still consider features in their build. PiperOrigin-RevId: 577495949	1 year ago
Mike Kruskal	57bb1e55f1	Set up editions codegen tests for python These tests aren't super useful for python because of how little codegen we actually do, but the pyi ones specifically will guard against major editions regressions. PiperOrigin-RevId: 577495652	1 year ago
Chris Kennelly	b2efcdc1c5	Internal Code Change PiperOrigin-RevId: 577274352	1 year ago
Protobuf Team Bot	37cae2d2e1	Internal change PiperOrigin-RevId: 577125921	1 year ago
Jie Luo	e9953d2155	internal change PiperOrigin-RevId: 576966982	1 year ago
Eric Salo	8d67a40d30	upb: fix wheels build errors PiperOrigin-RevId: 576925248	1 year ago
Eric Salo	c20b337221	upb: remove redundant #includes from the foo.upbdefs.h gencode PiperOrigin-RevId: 576883852	1 year ago
Protobuf Team Bot	f69f40e3f6	Internal change PiperOrigin-RevId: 576883351	1 year ago
Mike Kruskal	137e5984af	Rollback changes to Utf8Validation PiperOrigin-RevId: 576863528	1 year ago
Mike Kruskal	6df7f0bbef	Internal changes PiperOrigin-RevId: 576731159	1 year ago
Eric Salo	a286c9b56d	upb: create upb/reflection/BUILD PiperOrigin-RevId: 576631037	1 year ago
Protobuf Team Bot	d76a6300d2	Automated rollback of commit `4d92106451`. PiperOrigin-RevId: 576194379	1 year ago
Protobuf Team Bot	a14f29e40a	Internal change PiperOrigin-RevId: 576133829	1 year ago
Protobuf Team Bot	4d92106451	Make SpaceUsedLong non-virtual to reduce the size of the vtable. PiperOrigin-RevId: 576128619	1 year ago
Protobuf Team Bot	c68554cc24	Optimize RepeatedPtrField constructors. Writing zeros is faster as they are often available in the cache as well as it can be done with less instructions on common platforms. ``` BM_RepeatedPtrField_Ctor 125ns ± 3% 118ns ± 3% -5.34% (p=0.000 n=217+219) ``` PiperOrigin-RevId: 576126835	1 year ago
Kevin King	65cdac4ac5	Finish Proxied impls for rust repeated scalars PiperOrigin-RevId: 575935874	1 year ago
Protobuf Team Bot	022d223488	Automated rollback of commit `538a8e9a0d`. PiperOrigin-RevId: 575890896	1 year ago
Protobuf Team Bot	356d774e18	Use GetArena() instead of GetOwningArena() #5 . PiperOrigin-RevId: 575857972	1 year ago
Martijn Vels	538a8e9a0d	Use Arena enabled copy constructor when merging child messages PiperOrigin-RevId: 575841937	1 year ago
Protobuf Team Bot	8bf4fe924a	Fix static reflection for an enum's min/max value to be signed (int instead of usize). PiperOrigin-RevId: 575811496	1 year ago
st-cheewah	cc27cc3cf7	Update docs/third_party.md with new Clojure/Script libraries (#14415 ) * https://github.com/s-expresso/clojobuf * https://github.com/s-expresso/rubberbuf * https://github.com/s-expresso/clojobuf-codec Closes #14415 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14415 from st-cheewah:main `ec6b50a46b` PiperOrigin-RevId: 575796617	1 year ago
Adam Cozzette	77aa913e68	Update `cc_file_list_aspect` to handle targets with missing `hdrs/textual_hdrs` Our stale file regeneration logic broke with Bazel 6.4.0, and I suspect it was caused by this change: https://github.com/bazelbuild/bazel/pull/19534 Our logic assumed that any target with a `CcInfo` provider must have `hdrs` and `textual_hdrs` attributes, but it seems that this is no longer true for `cc_proto_library` starting with Bazel 6.4.0. The fix is just to use `getattr` and treat the item as an empty list if it's missing. PiperOrigin-RevId: 575473886	1 year ago
dependabot[bot]	8b2a3a6139	Bump actions/checkout from 3.1.0 to 4.1.0 (#14412 ) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 4.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v4.1.0</h2> <h2>What's Changed</h2> <ul> <li>Update README.md for V4 by <a href="https://github.com/sivapalan"><code>@sivapalan</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1452">actions/checkout#1452</a></li> <li>Add support for partial checkout filters by <a href="https://github.com/finleygn"><code>@finleygn</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1396">actions/checkout#1396</a></li> <li>Prepare 4.1.0 release by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1496">actions/checkout#1496</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/sivapalan"><code>@sivapalan</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1452">actions/checkout#1452</a></li> <li><a href="https://github.com/finleygn"><code>@finleygn</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1396">actions/checkout#1396</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.0.0...v4.1.0">https://github.com/actions/checkout/compare/v4.0.0...v4.1.0</a></p> <h2>v4.0.0</h2> <h2>What's Changed</h2> <ul> <li>Update default runtime to node20 by <a href="https://github.com/takost"><code>@takost</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1436">actions/checkout#1436</a></li> <li>Support fetching without the --progress option by <a href="https://github.com/simonbaird"><code>@simonbaird</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1067">actions/checkout#1067</a></li> <li>Release 4.0.0 by <a href="https://github.com/takost"><code>@takost</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1447">actions/checkout#1447</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/takost"><code>@takost</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1436">actions/checkout#1436</a></li> <li><a href="https://github.com/simonbaird"><code>@simonbaird</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1067">actions/checkout#1067</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3...v4.0.0">https://github.com/actions/checkout/compare/v3...v4.0.0</a></p> <h2>v3.6.0</h2> <h2>What's Changed</h2> <ul> <li>Mark test scripts with Bash'isms to be run via Bash by <a href="https://github.com/dscho"><code>@dscho</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1377">actions/checkout#1377</a></li> <li>Add option to fetch tags even if fetch-depth > 0 by <a href="https://github.com/RobertWieczoreck"><code>@RobertWieczoreck</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/579">actions/checkout#579</a></li> <li>Release 3.6.0 by <a href="https://github.com/luketomlinson"><code>@luketomlinson</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1437">actions/checkout#1437</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/RobertWieczoreck"><code>@RobertWieczoreck</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/579">actions/checkout#579</a></li> <li><a href="https://github.com/luketomlinson"><code>@luketomlinson</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1437">actions/checkout#1437</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3.5.3...v3.6.0">https://github.com/actions/checkout/compare/v3.5.3...v3.6.0</a></p> <h2>v3.5.3</h2> <h2>What's Changed</h2> <ul> <li>Fix: Checkout Issue in self hosted runner due to faulty submodule check-ins by <a href="https://github.com/megamanics"><code>@megamanics</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1196">actions/checkout#1196</a></li> <li>Fix typos found by codespell by <a href="https://github.com/DimitriPapadopoulos"><code>@DimitriPapadopoulos</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1287">actions/checkout#1287</a></li> <li>Add support for sparse checkouts by <a href="https://github.com/dscho"><code>@dscho</code></a> and <a href="https://github.com/dfdez"><code>@dfdez</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1369">actions/checkout#1369</a></li> <li>Release v3.5.3 by <a href="https://github.com/TingluoHuang"><code>@TingluoHuang</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1376">actions/checkout#1376</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/megamanics"><code>@megamanics</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1196">actions/checkout#1196</a></li> <li><a href="https://github.com/DimitriPapadopoulos"><code>@DimitriPapadopoulos</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1287">actions/checkout#1287</a></li> <li><a href="https://github.com/dfdez"><code>@dfdez</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1369">actions/checkout#1369</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3...v3.5.3">https://github.com/actions/checkout/compare/v3...v3.5.3</a></p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h2>v4.1.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/1396">Add support for partial checkout filters</a></li> </ul> <h2>v4.0.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/1067">Support fetching without the --progress option</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1436">Update to node20</a></li> </ul> <h2>v3.6.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/1377">Fix: Mark test scripts with Bash'isms to be run via Bash</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/579">Add option to fetch tags even if fetch-depth > 0</a></li> </ul> <h2>v3.5.3</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/1196">Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1287">Fix typos found by codespell</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1369">Add support for sparse checkouts</a></li> </ul> <h2>v3.5.2</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/1289">Fix api endpoint for GHES</a></li> </ul> <h2>v3.5.1</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/1246">Fix slow checkout on Windows</a></li> </ul> <h2>v3.5.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/1237">Add new public key for known_hosts</a></li> </ul> <h2>v3.4.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/1209">Upgrade codeql actions to v2</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1210">Upgrade dependencies</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1225">Upgrade <code>@actions/io</code></a></li> </ul> <h2>v3.3.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/1045">Implement branch list using callbacks from exec function</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1050">Add in explicit reference to private checkout options</a></li> <li>[Fix comment typos (that got added in <a href="https://redirect.github.com/actions/checkout/issues/770">#770</a>)](<a href="https://redirect.github.com/actions/checkout/pull/1057">actions/checkout#1057</a>)</li> </ul> <h2>v3.2.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/942">Add GitHub Action to perform release</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/967">Fix status badge</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1002">Replace datadog/squid with ubuntu/squid Docker image</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/964">Wrap pipeline commands for submoduleForeach in quotes</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1029">Update <code>@actions/io</code> to 1.1.2</a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/1039">Upgrading version to 3.2.0</a></li> </ul> <h2>v3.1.0</h2> <ul> <li><a href="https://redirect.github.com/actions/checkout/pull/939">Use <code>@actions/core</code> <code>saveState</code> and <code>getState</code></a></li> <li><a href="https://redirect.github.com/actions/checkout/pull/922">Add <code>github-server-url</code> input</a></li> </ul> <h2>v3.0.2</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="`8ade135a41`"><code>8ade135</code></a> Prepare 4.1.0 release (<a href="https://redirect.github.com/actions/checkout/issues/1496">#1496</a>)</li> <li><a href="`c533a0a4cf`"><code>c533a0a</code></a> Add support for partial checkout filters (<a href="https://redirect.github.com/actions/checkout/issues/1396">#1396</a>)</li> <li><a href="`72f2cec99f`"><code>72f2cec</code></a> Update README.md for V4 (<a href="https://redirect.github.com/actions/checkout/issues/1452">#1452</a>)</li> <li><a href="`3df4ab11eb`"><code>3df4ab1</code></a> Release 4.0.0 (<a href="https://redirect.github.com/actions/checkout/issues/1447">#1447</a>)</li> <li><a href="`8b5e8b7687`"><code>8b5e8b7</code></a> Support fetching without the --progress option (<a href="https://redirect.github.com/actions/checkout/issues/1067">#1067</a>)</li> <li><a href="`97a652b800`"><code>97a652b</code></a> Update default runtime to node20 (<a href="https://redirect.github.com/actions/checkout/issues/1436">#1436</a>)</li> <li><a href="`f43a0e5ff2`"><code>f43a0e5</code></a> Release 3.6.0 (<a href="https://redirect.github.com/actions/checkout/issues/1437">#1437</a>)</li> <li><a href="`7739b9ba2e`"><code>7739b9b</code></a> Add option to fetch tags even if fetch-depth > 0 (<a href="https://redirect.github.com/actions/checkout/issues/579">#579</a>)</li> <li><a href="`96f53100ba`"><code>96f5310</code></a> Mark test scripts with Bash'isms to be run via Bash (<a href="https://redirect.github.com/actions/checkout/issues/1377">#1377</a>)</li> <li><a href="`c85c95e3d7`"><code>c85c95e</code></a> Release v3.5.3 (<a href="https://redirect.github.com/actions/checkout/issues/1376">#1376</a>)</li> <li>Additional commits viewable in <a href="https://github.com/actions/checkout/compare/v3.1.0...8ade135a41bc03ea155e62e844d188df1ea18608">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=3.1.0&new-version=4.1.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Closes #14412 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14412 from protocolbuffers:dependabot/github_actions/actions/checkout-4.1.0 `20c4eb77c6` PiperOrigin-RevId: 575284289	1 year ago
Mike Kruskal	108a4a3094	Use protobuf-ci for staleness infra. This will pin our version of Bazel, and avoid non-hermetic breakages from github runner changes PiperOrigin-RevId: 575277990	1 year ago
Mike Kruskal	b7de33ce48	Internal changes PiperOrigin-RevId: 575274614	1 year ago
Krasimir Georgiev	5eecee27de	Update rules_rust usage to match `cd3e53e9b8`. PiperOrigin-RevId: 575241905	1 year ago
Martijn Vels	e419f7365f	Remove dead code that was only used in aggregate initialization PiperOrigin-RevId: 575233315	1 year ago
Mike Kruskal	3d068a2247	Reduce CI frequency. We're having issues with github runners right now where they're queueing for long periods, and this has become disruptive. We've gotten the flake rate under 2% total (<0.5% per build), and can ramp this up again later if we want to reduce it further. PiperOrigin-RevId: 575227138	1 year ago
Joshua Haberman	8647a803a0	Cleaned up more cases of NULL -> nullptr PiperOrigin-RevId: 575226197	1 year ago
Adam Cozzette	96c7680f4e	Update CMake install test to use shared libraries This should help us catch problems that come up when libprotobuf and libprotoc are built as shared libraries. The motivating example was that we recently had build failures due to `PROTOBUF_EXPORT` being missing from a symbol that needed it, but none of our existing tests caught this. (Technically this test wouldn't catch it either since that particular issue affected C++17 only, but at least this should help with similar problems.) PiperOrigin-RevId: 575218922	1 year ago
Martijn Vels	1934daf26e	Internal changes PiperOrigin-RevId: 575078212	1 year ago
Protobuf Team Bot	d617c03221	Internal change. PiperOrigin-RevId: 575006343	1 year ago
Protobuf Team Bot	1b7615905f	Move `InitializationErrorString` into the secondary vtable, retrieved from `ClassData`. This removes one virtual function from MessageLite with zero per-type increase. PiperOrigin-RevId: 574994142	1 year ago
Hong Shin	2690017b16	cleanup upb.rs We shouldn't give easy access to the zeroed block, so let's pass in pbi::private to deter misuse. Also saw that arena wasn't used mutably in a repeatedfield test, so let mut -> let; PiperOrigin-RevId: 574896460	1 year ago
Protobuf Team Bot	287374e5eb	Replace try-catch Blocks with assertThrows() in GeneratedMessageTest PiperOrigin-RevId: 574887696	1 year ago

1 2 3 4 5 ...

16125 Commits (c1e0853f7047494af39388f72d80cfe14336bf27) All Branches Search

16125 Commits (c1e0853f7047494af39388f72d80cfe14336bf27)

All Branches