Mike Kruskal
bda13f3bfa
Add back error message unconditionally
...
PiperOrigin-RevId: 611105036
1 year ago
Chris Kennelly
08523897a5
Replace call to proto2::Arena::CreateMessage with Create.
...
PiperOrigin-RevId: 610960035
1 year ago
Protobuf Team Bot
6713c2f646
Clean up another Rust protobuf logspam message
...
PiperOrigin-RevId: 610921886
1 year ago
Sandy Zhang
5993e86986
Force descriptor initialization of dependencies at the beginning of the static init block.
...
This ensures that any dependent descriptors are already initialized before we use them and we're not initializing them lazily as-we-go. This should help ensure that dependent descriptors are fully initialized before we need them.
PiperOrigin-RevId: 610858264
1 year ago
Protobuf Team Bot
cc55b85a0e
Use parameterized testing.
...
PiperOrigin-RevId: 610838257
1 year ago
Mike Kruskal
fc6adb6c0e
Actually fail if staleness fail
...
PiperOrigin-RevId: 610833812
1 year ago
Protobuf Team Bot
0070ac1188
Make UnsafeByteOperations stable; removing experimental annotation.
...
PiperOrigin-RevId: 610787227
1 year ago
tony
fe60e5b971
Fix csharp doc commments ( #15955 )
...
Fix C# document comments when there is an extra `/` at the start of a comment line.
See https://github.com/grpc/grpc/issues/35905
Related to https://github.com/grpc/grpc/pull/36000 which also fixes the issue in the gRPC C# plugin
Closes #15955
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/15955 from tonydnewell:csharp-comment-fix d80e09ae20
PiperOrigin-RevId: 610784971
1 year ago
Sandy Zhang
8a17f5ddeb
Resolve features directly in setProto instead of temporarily setting to null.
...
Avoid potential races with other threads reading features that do not share a lock while features are temporarily null.
Special handling for proto1 mutable should not actually be needed, since setProto doesn't update dependency protos.
PiperOrigin-RevId: 610783483
1 year ago
Protobuf Team Bot
139ea4d385
Tweak "group to property name" mapping for C#. Under editions, where fields using a delimited encoding have independent field names from type names, we want to use the specified field name.
...
This change keeps the existing naming for properties generated from proto2 files, while improving the experience under editions. This introduces a C# incompatibility when upgrading a proto from proto2 to editions, but we anticipate this being a relatively rare problem.
PiperOrigin-RevId: 610783407
1 year ago
Protobuf Team Bot
0ad1bfc2fa
Automated Code Change
...
PiperOrigin-RevId: 610771450
1 year ago
Mike Kruskal
396e26b475
Enable C++ tests for Bazel 7 on mac
...
PiperOrigin-RevId: 610573579
1 year ago
Mike Kruskal
f66d876a10
Allow base64 encoding of embedded edition defaults.
...
PiperOrigin-RevId: 610570515
1 year ago
Mike Kruskal
4dc2c07025
Disable Mac PHP 8.2 test
...
PiperOrigin-RevId: 610520746
1 year ago
Protobuf Team Bot
ab127f7501
Rename EagerParseLazyField to EagerParseLazyFieldIgnoreUnparsed
...
PiperOrigin-RevId: 610469115
1 year ago
Marcin Kowalczyk
03a472ea08
Optimize `Reflection::ScratchSpace::CopyFromCord()`.
...
If the Cord is already flat, return a pointer to its data instead of copying
them to a string.
PiperOrigin-RevId: 610434454
1 year ago
Protobuf Team Bot
7ef3f87e3d
Auto-generate files after cl/610422312
1 year ago
Protobuf Team Bot
afbe9cc9b5
Internal change
...
PiperOrigin-RevId: 610422312
1 year ago
Protobuf Team Bot
7e5962d3bc
Auto-generate files after cl/610415350
1 year ago
Protobuf Team Bot
ed072f207c
Automated rollback of commit 6722988db6
.
...
PiperOrigin-RevId: 610415350
1 year ago
Thomas Van Lenten
9f52d5e380
[ObjC] Fix issue using GPBBootstrap.h only.
...
GPB_ENUM_FWD_DECLARE needs `int32_t`, so add the import so GPBBootstrap.h
stands on its own without needing users to import something else.
Add another compile test file to ensure this doesn't break.
PiperOrigin-RevId: 610403337
1 year ago
Protobuf Team Bot
9c0d130168
Automated Code Change
...
PiperOrigin-RevId: 610384942
1 year ago
Protobuf Team Bot
0e8bb1954d
Automated Code Change
...
PiperOrigin-RevId: 610367636
1 year ago
Protobuf Team Bot
2eb6e4f374
Automated Code Change
...
PiperOrigin-RevId: 610364921
1 year ago
Protobuf Team Bot
ee0a41cae3
Add states to support "ignore unparsed".
...
PiperOrigin-RevId: 609868025
1 year ago
Sandy Zhang
eb10ebd169
Fix features inheritance of oneof fields and extensions and fix/move unit tests to actually run.
...
JUnit4 does not support nested tests so these weren't running. Fixes setup problems and test logic. Oneof fields now inherit from their oneof, and top-level extensions inherit from top-level file when parent descriptor is null.
PiperOrigin-RevId: 609840087
1 year ago
Thomas Van Lenten
baaf402b29
Fix comment error.
...
PiperOrigin-RevId: 609830695
1 year ago
Protobuf Team Bot
f12f279be2
Deprecate Arena::CreateMessage internally first.
...
PiperOrigin-RevId: 609788176
1 year ago
Alyssa Haroldsen
fe5092a392
Support enums as map values
...
PiperOrigin-RevId: 609772950
1 year ago
Protobuf Team Bot
3590a8b7e8
Auto-generate files after cl/609769553
1 year ago
Protobuf Team Bot
6bf0d8a936
Drop MapEntry::_InternalParse and use the TcParser generated version instead.
...
PiperOrigin-RevId: 609769553
1 year ago
Alyssa Haroldsen
5983f7033c
Transpose the map thunk macros, relocate to header file
...
PiperOrigin-RevId: 609766889
1 year ago
Ilya Tokar
5988dc2e37
Make msvc happy
...
For some reason __forceinline inline geives a warning, but
inline __forceinline isn't.
PiperOrigin-RevId: 609766125
1 year ago
Chris Kennelly
9f79ddf8b3
Replace call to proto2::Arena::CreateMessage with Create.
...
PiperOrigin-RevId: 609755924
1 year ago
Protobuf Team Bot
827900d0f5
Add C# to the list of codegen test languages for Editions.
...
PiperOrigin-RevId: 609754899
1 year ago
Thomas Van Lenten
f9731fdf73
[ObjC] Fix potential `-Wstrict-prototypes` warning.
...
PiperOrigin-RevId: 609718293
1 year ago
Protobuf Team Bot
5a0135e65a
Bring back 'flat' setters for singular scalars and strings.
...
The non-string field setters can bypass the vtables already, the string setters still go through the vtable path here because its more important to let them take an `impl SettableValue` to be able to set either a &str or a &ProtoStr already.
PiperOrigin-RevId: 609705233
1 year ago
Alyssa Haroldsen
4395d97f66
Use a 64K static for zeroed scratch space in upb
...
The actual construction of the zeroed block is now entirely safe.
This will be accessed in nearly every program using protobuf.
Using a static in .bss has much less overhead than an atomically-constructed
dynamic allocation and is far more predictable for space-constrained systems.
In the future, if dynamic allocation is kept, it should use std::sync::OnceLock
instead of the much less safe Once combined with `static mut`.
PiperOrigin-RevId: 609635555
1 year ago
YoloMao
8afaae52d8
feat: add visionOS deployment target for Cocoapods ( #15917 )
...
add visionOS deployment target for Cocoapods
Closes #15917
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/15917 from YoloMao:feat/visionos_support_via_cocoapods 8a8a640d33
PiperOrigin-RevId: 609578154
1 year ago
Alyssa Haroldsen
c6af7f76b7
Replace UpbTypeConversions::empty_message_value with MaybeUninit/null
...
The API doesn't require the pointees be initialized first, and the writes are predictable.
PiperOrigin-RevId: 609540475
1 year ago
Alyssa Haroldsen
dd27b6b877
Use consistent name for the "get item from untyped map iterator" thunk
...
It now uses the same prefix as other thunks needed for the proxied type,
so the RawMapThunk helper can be used for enums.
Calling it a "iter next" thunk is misleading.
It does not increment the iterator as "next" implies,
it only gets the current key/value the iterator points to.
PiperOrigin-RevId: 609527442
1 year ago
Protobuf Team Bot
5d876c9fec
Point to released versions in Java Protobuf (lite) READMEs instead of the the next, unreleased version.
...
https://github.com/protocolbuffers/protobuf/issues/15878
PiperOrigin-RevId: 609488730
1 year ago
Anton Grbin
0fa67a94aa
JSON conformance test: repeated with a mix of known and unknown enum string values ( #15885 )
...
This test was suggested by @jskeet in the related issue: https://github.com/protocolbuffers/protobuf/issues/7392#issuecomment-1884666885
I am not confident that the failure lists are comprehensive (I only run a few tests locally) -- will fix once we get CI results.
Closes #15885
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/15885 from noom:anton/7392/conformance-repeated-enum 60c35f0339
PiperOrigin-RevId: 609487784
1 year ago
Protobuf Team Bot
ce61fc80b6
Remove the override for _InternalParse from Message and inject the custom
...
behavior via DescriptorMethods instead.
PiperOrigin-RevId: 609470854
1 year ago
Protobuf Team Bot
22cbe3a435
Auto-generate files after cl/609454594
1 year ago
Ilya Tokar
4b31b781f6
Be less aggressive about prefetching in bytesizelong
...
PiperOrigin-RevId: 609454594
1 year ago
Protobuf Team Bot
2ec8e4da21
Auto-generate files after cl/609437563
1 year ago
Protobuf Team Bot
6722988db6
Improve pinning assembly when using a clang that supports it.
...
The new technique adds the relocation without adding an instruction that has to be executed in the code path.
PiperOrigin-RevId: 609437563
1 year ago
Alyssa Haroldsen
b33682537b
Refactor builtin map key type naming info for enums
...
PiperOrigin-RevId: 609434380
1 year ago
Protobuf Team Bot
e4eac25bb3
Auto-generate files after cl/609416940
1 year ago