Mike Kruskal
d1d7502444
Delete codespell presubmit.
...
This has caused repeated issues due to the fact that it checks the entire repo. Most recently, it decided to complain about a typo in a file that hasn't been touched in 5 years.
PiperOrigin-RevId: 540356791
1 year ago
Mike Kruskal
b1df92704b
Clean up staleness tests.
...
Our automation can't currently update release branches, so we need to enable staleness tests as presubmits to force manual regeneration.
PiperOrigin-RevId: 540094169
1 year ago
Tomo Suzuki
2fd29b0b73
Move linkage monitor check as part of Bazel build ( #12980 )
...
Fixes https://github.com/protocolbuffers/protobuf/issues/12912
Moving the Linkage Monitor check to Bazel, so that the result is cached.
Closes #12980
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12980 from suztomo:bazelize_linkage_monitor 51c00949ba
PiperOrigin-RevId: 539681611
1 year ago
Mike Kruskal
4031712c34
Drop Bazel 4 support and add Bazel 6
...
PiperOrigin-RevId: 539130329
1 year ago
Mike Kruskal
d90c3e7c4f
Fix staleness test branching logic
...
PiperOrigin-RevId: 538812352
1 year ago
Marcel Hlopko
ff750bb4c3
Put shared.rs and cpp.rs/upb.rs into the same crate.
...
The motivation is to make the setup simpler and more flexible.
PiperOrigin-RevId: 538189061
1 year ago
Marcel Hlopko
f92edc13c2
Automated rollback of commit fe7c4f9422
.
...
PiperOrigin-RevId: 538128679
1 year ago
Joyce
010fde9a18
Set top level permissions to read only on GitHub Workflows ( #12971 )
...
Hi, here is Joyce from Google again.
I'd like starting suggesting the [Token-Permission check](https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions ) fix.
Let me know if I might be missing any permission. Thanks!
### Security Reason
This is needed because, by default, github grants write-all permission to all workflows, which could be exploit by an attacker in case of a compromised workflow. Limiting permissions is a simple and effective way to also limit the impact of an eventual compromised workflow.
Thus, it is both a recommendation from [OpenSSF Scorecard](https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions ) and the [Github](https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions ) to always use credentials that are minimally scoped.
Closes #12971
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12971 from joycebrum:main 6d6dac5678
PiperOrigin-RevId: 537973051
1 year ago
Mike Kruskal
0b9b5da7a7
Cleanup scheduled staleness tests.
...
- Do some minimal sanity testing on every PR
- Only run the staleness tests on a daily schedule or explicit runs.
- Add 23.x to the checks
PiperOrigin-RevId: 537952151
1 year ago
Mike Kruskal
722d6f5897
Disable non-hermetic breakage due to github runner update
...
See https://github.com/actions/runner-images/issues/7662
PiperOrigin-RevId: 537946689
1 year ago
Marcel Hlopko
03b53f404c
Update staleness test worker
...
Currently the test fails because the Bazel version is too old for the Rust subproject (https://github.com/protocolbuffers/protobuf/actions/runs/5154290452/jobs/9282571385 )
PiperOrigin-RevId: 537323723
2 years ago
Marcel Hlopko
fe7c4f9422
Simplify Protobuf Rust runtime build setup
...
PiperOrigin-RevId: 537300231
2 years ago
Marcel Hlopko
b14ad422ca
Fix staleness test workflow
...
PiperOrigin-RevId: 537256933
2 years ago
Carlos O'Ryan
4b414d60ee
Squashed 'third_party/utf8_range/' changes from 72c943dea..d863bc33e
...
d863bc33e cleanup: avoid "unused function" errors in OSS land
f4948c4f2 internal change
cd1507d14 Fix typo in pkg-config file to properly link the utf8_range libraries
3f179d134 Add pkg-config file declaring Abseil dependency of utf8_range
git-subtree-dir: third_party/utf8_range
git-subtree-split: d863bc33e15cba6d873c878dcca9e6fe52b2f8cb
2 years ago
Mike Kruskal
4b1c4965e4
Persist COMPOSER_HOME so that we don't continue to query remote servers
...
PiperOrigin-RevId: 534968948
2 years ago
Mike Kruskal
9657172749
Use composer action for dependency caching.
...
This will reduce the flakes we've seen in PHP tests.
PiperOrigin-RevId: 534226922
2 years ago
Mike Kruskal
e15326ba80
Add a workaround for GCC constexpr bug
...
This turns the constexpr constructors into templates to silence errors when constexpr isn't valid. We are also switching to 12.2 for GCC/cmake tests to prevent regressions (9.5 and 13.1 are already tested by GCC/bazel tests).
Fixes #12807
PiperOrigin-RevId: 532258101
2 years ago
Mike Kruskal
d4ef42aa9b
Fix C++17 gcc issues.
...
This also adds tests for C++17 and C++20 to prevent further regressions.
PiperOrigin-RevId: 530693318
2 years ago
deannagarcia
0e23f18865
Merge to main after 23.0 release ( #12721 )
...
Closes #12721
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12721 from protocolbuffers:main-202305082101 36482b4c68
PiperOrigin-RevId: 530664393
2 years ago
Protobuf Team Bot
67d9ea87f3
Internal change
...
PiperOrigin-RevId: 530619366
2 years ago
Mike Kruskal
bc9a1d219e
Add tests for GCC support window.
...
Note: gcc only supports docker images down to 9.5, and the 7.3 image is very old and problematic. A follow-up change might enable testing for GCC 7.3, which is our minimal supported version
PiperOrigin-RevId: 529885733
2 years ago
Mike Kruskal
da2c4a6ce9
Add tests for GCC support window.
...
Note: gcc only supports docker images down to 9.5, and the 7.3 image is very old and problematic. A follow-up change might enable testing for GCC 7.3, which is our minimal supported version
PiperOrigin-RevId: 529885733
2 years ago
Mike Kruskal
54caf40312
Avoid using string(JOIN..., which requires cmake 3.12
...
This also downgrades our tests to use cmake 3.10, compatible with our support window.
Closes #12672
PiperOrigin-RevId: 529840763
2 years ago
Mike Kruskal
adee0a59f9
Avoid using string(JOIN..., which requires cmake 3.12
...
This also downgrades our tests to use cmake 3.10, compatible with our support window.
Closes #12672
PiperOrigin-RevId: 529840763
2 years ago
Mike Kruskal
5f97a7f494
Define a new set of cmake tests.
...
These more closely follow the standard practices of our users, where dependencies are pre-installed instead of using our provided sub-modules. This will prevent issues such as #12201 from reoccuring.
Additionally, this cl bumps our Abseil dependency to the latest release, and fixes a GTest issue that went previously unnoticed.
PiperOrigin-RevId: 529490402
2 years ago
Mike Kruskal
7714d57c91
Define a new set of cmake tests.
...
These more closely follow the standard practices of our users, where dependencies are pre-installed instead of using our provided sub-modules. This will prevent issues such as #12201 from reoccuring.
Additionally, this cl bumps our Abseil dependency to the latest release, and fixes a GTest issue that went previously unnoticed.
PiperOrigin-RevId: 529490402
2 years ago
Mike Kruskal
24d3e74ac9
Remove --remote argument in cmake tests.
...
This will prevent non-hermetic breakages from changes to the Abseil release branch we're pinned to.
PiperOrigin-RevId: 529459765
2 years ago
Mike Kruskal
5223f56dba
Remove --remote argument in cmake tests.
...
This will prevent non-hermetic breakages from changes to the Abseil release branch we're pinned to.
PiperOrigin-RevId: 529459765
2 years ago
Deanna Garcia
74cea3dda5
Revert "Fix tests"
...
This reverts commit 645336fb8a
.
2 years ago
Deanna Garcia
645336fb8a
Fix tests
2 years ago
Mike Kruskal
0b73dd44a3
Add -ex switch to all docker bash commands. ( #12601 )
...
Without this, certain failures will be silently ignored.
PiperOrigin-RevId: 527718574
2 years ago
Mike Kruskal
f6c7fdf88c
Add -ex switch to all docker bash commands.
...
Without this, certain failures will be silently ignored.
PiperOrigin-RevId: 527718574
2 years ago
Deanna Garcia
d19c7997ab
Fix bom tests
2 years ago
Deanna Garcia
99c9491f7c
Fix maven pom test
2 years ago
Mike Kruskal
2230d0e748
Fix homebrew issue on Mac runners causing PHP CI failures
...
PiperOrigin-RevId: 527419345
2 years ago
Mike Kruskal
72b1f985a0
Fix homebrew issue on Mac runners causing PHP CI failures
...
PiperOrigin-RevId: 527419345
2 years ago
Mike Kruskal
9898418bd9
Fix btree issue in map tests.
...
Without any weak ordering, btree_map fails to compile on windows 2022.
Closes #12289
PiperOrigin-RevId: 527019995
2 years ago
Tomo Suzuki
d692223887
[WIP] Java BOM check with generated pom.xml files ( #12502 )
...
This check aims to address issues like https://github.com/protocolbuffers/protobuf/issues/12170 "Java 3.22.1: broken pom.xml".
Closes #12502
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12502 from suztomo:bom_check c69e2af597
PiperOrigin-RevId: 526776900
2 years ago
Adam Cozzette
f71dc953c7
Add GitHub actions workflow for testing CMake build of examples directory
...
I confirmed that this test would catch the problem from #12450 .
PiperOrigin-RevId: 526165526
2 years ago
Thomas Van Lenten
2fdec2a0df
Set up C++ macOS bazel coverage for Apple Silicon
...
This is inspired by https://github.com/protocolbuffers/protobuf/issues/12306 ,
but does not show those failures, so clearly it doesn't catch everything, but
figured some coverage is better than none.
PiperOrigin-RevId: 525134469
2 years ago
Thomas Van Lenten
1f1bd79d33
Ensure the ObjC runtime builds for Apple Silicon.
...
Github doesn't currently have Apple Silicon runners, but we can build for
the target to atleast ensure things are building.
PiperOrigin-RevId: 524929865
2 years ago
Thomas Van Lenten
8539ef4974
Ensure the ObjC runtime builds for Apple Silicon.
...
Github doesn't currently have Apple Silicon runners, but we can build for
the target to atleast ensure things are building.
PiperOrigin-RevId: 524929865
2 years ago
Miguel Young de la Sota
6678619d10
Factor out different codegen parts of the Rust backend.
...
The intent of this change is to take the best ideas from the C++ backend, such as having generator objects that can cache pre-computed state, while minimizing duplication.
Where possible, we take the approach of making the C++ and UPB kernel-specific code as similar as possible, since this reduces the number of templates we need to keep in sync.
PiperOrigin-RevId: 524903073
2 years ago
Deanna Garcia
41b7500aee
Fix abseil gitmodule date and add a step in tests to update the subrepo to catch errors like this in the future.
...
PiperOrigin-RevId: 523826559
2 years ago
Romfos
09f094c811
[dotnet, csharp] Run tests for supported platforms .NET 6, .NET Framework 4.6.2 ( #12378 )
...
What's changed?
- Update some nuget packages (for test projects)
- Run unit tests for supported platforms: .NET 6 + .NET Framework 4.6.2
Notes:
.NET Framework 4.6.1 is out of support, .NET Framework 4.6.2 is the older version that is still supported
https://devblogs.microsoft.com/dotnet/net-framework-4-5-2-4-6-4-6-1-will-reach-end-of-support-on-april-26-2022/
.NET 5 is out of support
https://devblogs.microsoft.com/dotnet/dotnet-5-end-of-support-update/
.NET Core 3.1 is out of support
https://devblogs.microsoft.com/dotnet/net-core-3-1-will-reach-end-of-support-on-december-13-2022/
Visual studio 2012 is out of support
https://devblogs.microsoft.com/visualstudio/support-ends-for-older-versions-of-visual-studio-feb2022
Closes #12378
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12378 from Romfos:main 227661e02c
PiperOrigin-RevId: 523196896
2 years ago
Marcel Hlopko
f7a2f4acea
Add initial end-to-end test directory structure.
...
This turns out to be quite of a yak shave to be able to perfectly test both kernels without having to pass extra Blaze flags.
PiperOrigin-RevId: 521850709
2 years ago
Mike Kruskal
8894d03bae
Switch to docker image for protoc build in java linkage test
...
This will prevent non-hermetic outages and better unify our test infrastructure.
PiperOrigin-RevId: 521779648
2 years ago
Jakob Buchgraber
515175db66
Build & test Rust compiler on GHA
...
PiperOrigin-RevId: 520578368
2 years ago
Jakob Buchgraber
ef53613b42
Add GHA workflow for Rust
...
PiperOrigin-RevId: 518933228
2 years ago
deannagarcia
6e624e4f6b
Add codespell exceptions
...
Codespell is failing on 22.x mostly because there were changes made to this file in main that weren't added to 22.x. This adds the extra exceptions.
2 years ago