protobuf

Commit Graph

Author	SHA1	Message	Date
Adam Cozzette	501ececd39	Reorganize upb file structure This change moves almost everything in the `upb/` directory up one level, so that for example `upb/upb/generated_code_support.h` becomes just `upb/generated_code_support.h`. The only exceptions I made to this were that I left `upb/cmake` and `upb/BUILD` where they are, mostly because that avoids conflict with other files and the current locations seem reasonable for now. The `python/` directory is a little bit of a challenge because we had to merge the existing directory there with `upb/python/`. I made `upb/python/BUILD` into the BUILD file for the merged directory, and it effectively loads the contents of the other BUILD file via `python/build_targets.bzl`, but I plan to clean this up soon. PiperOrigin-RevId: 568651768	1 year ago
Hong Shin	fab6920207	Shorten our license headers into an abbreviated form that references LICENSE instead of including it in full. PiperOrigin-RevId: 566699046	1 year ago
Adam Cozzette	7286ffceb2	Merge the protobuf and upb Bazel repos A couple weeks ago we moved upb into the protobuf Git repo, and this change continues the merger of the two repos by making them into a single Bazel repo. This was mostly a matter of deleting upb's WORKSPACE file and fixing up a bunch of references to reflect the new structure. Most of the changes are pretty mechanical, but one thing that needed more invasive changes was the Python script for generating CMakeLists.txt, make_cmakelists.py. The WORKSPACE file it relied on no longer exists with this change, so I updated it to hardcode the information it needed from that file. PiperOrigin-RevId: 564810016	1 year ago
Adam Cozzette	047df98dea	Move upb-x/ back to upb/ This is the second attempt to fix our Git history. This should allow "git blame" to work correctly in the upb/ directory even though our automation unexpectedly blew away that directory.	1 year ago
Adam Cozzette	895f190bda	Move upb to upb-x	1 year ago
Adam Cozzette	1ba80d7424	Move upb-temp/ back to upb/	1 year ago
Adam Cozzette	d38b8561e6	Move upb/ to upb-temp/ This will help us fix our Git commit history to ensure that git blame works correctly for upb.	1 year ago
Adam Cozzette	6fc87fe3f7	Internal change PiperOrigin-RevId: 560100839	1 year ago
مهدي شينون (Mehdi Chinoune)	c2f07bb80f	Fix building shared libraries on MinGW-w64 (#13240 ) Closes #13240 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/13240 from MehdiChinoune:mingw-shared `45600c9ccc` PiperOrigin-RevId: 546541196	1 year ago
Romain Geissler @ Amadeus	4329fde9cf	Use the same ABI for static and shared libraries on non-Windows platforms (#12983 ) Hi, It seems that until last year, the logic behind `PROTOBUF_USE_DLLS` was for Windows (MSCV) only. It was changed to all platforms here in `5a0887fc65` Last month, the generated pkg config files were updated to reflect the protobuf build-time value of `PROTOBUF_USE_DLLS` as it was indeed noted that it changes the ABI. This was done in https://github.com/protocolbuffers/protobuf/pull/12700 In the commit message it is mentionned that most likely we shall rather have a stable ABI. Finally in https://github.com/protocolbuffers/protobuf/issues/12746 which at some point mentions https://issuetracker.google.com/issues/283987730#comment7 where a Google employee hits the linker issue: ``` undefined reference to `google::protobuf::internal::ThreadSafeArena::thread_cache_' ``` which denotes a mix of some .o or libs built `PROTOBUF_USE_DLLS` defined and some others build with `PROTOBUF_USE_DLLS` undefined, resulting in ABI incompatibilities. I also hit this issue while trying to include protobuf in a corporate environment using it's own proprietary build system in which it is expected that .a and .so use a compatible ABI. From my own understanding, ideally we should always use `thread_local` variables, but experience has shown that: - old iOS (iOS < 9) didn't seem to accept `thread_local`, leading to the `GOOGLE_PROTOBUF_NO_THREADLOCAL` macro later renamed `PROTOBUF_NO_THREADLOCAL` which allowed to disable this, but it is not set anywhere in the protobuf code base. Also I doubt you still want to support such old iOS now, so maybe you should consider removing all `PROTOBUF_NO_THREADLOCAL` related code paths (this pull request doesn't do this). - MSVC's DLL interface doesn't seem to accept exporting thread local variables (at least from what I understood, I know absolutely nothing about the Windows ecosystem), yet we can "hide" a thread local variable in a static function using a thread local variable. However in that case the access to TLS variable is not inlined, leading to worse performances, this hack shall be done only for Windows (actually when using MSVC) AND we build a shared library. - In all other cases, a classical `thread_local` shall be used, no matter if we build a static or a shared library. In particular on Linux which I guess is the target Google cares the more about for its own production. This pull request achieves this. Am I right in my conclusion ? Closes #12983 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12983 from Romain-Geissler-1A:stable-abi-use-dll-non-windows `dc23ff50f6` PiperOrigin-RevId: 538230923	2 years ago
Protobuf Team Bot	d41deb9dc6	Internal change that helps identify the origin of reflection calls. PiperOrigin-RevId: 510255963	2 years ago

1 Commits (b9ad33cdffd7a6abfacde0580c430e184f62549c)