protobuf

Commit Graph

Author	SHA1	Message	Date
Joshua Haberman	96307d28f6	Sync from Piper @364389596 PROTOBUF_SYNC_PIPER	4 years ago
Joshua Haberman	7d63b996e1	Removed compatibility test that tries to append "nil" to repeated field.	4 years ago
Joshua Haberman	9abf6e2ab0	Ported Ruby extension to upb_msg (#8184 ) * WIP. * WIP. * WIP. * WIP. * WIP. * WIP. * Added some missing files. * WIP. * WIP. * Updated upb. * Extension loads, but crashes immediately. * Gets through the test suite without SEGV! Still a lot of bugs to fix, but it is a major step! 214 tests, 378 assertions, 37 failures, 147 errors, 0 pendings, 0 omissions, 0 notifications 14.0187% passed * Test and build for Ruby 3.0 * Fixed a few more bugs, efficient #inspect is almost done. 214 tests, 134243 assertions, 30 failures, 144 errors, 0 pendings, 0 omissions, 0 notifications 18.6916% passed * Fixed message hash initialization and encode depth checking. 214 tests, 124651 assertions, 53 failures, 70 errors, 0 pendings, 0 omissions, 0 notifications 42.5234% passed * A bunch of fixes to failing tests, now 70% passing. 214 tests, 202091 assertions, 41 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications 70.0935% passed * More than 80% of tests are passing now. 214 tests, 322331 assertions, 30 failures, 9 errors, 0 pendings, 0 omissions, 0 notifications 81.7757% passed Unfortunately there is also a sporadic bug/segfault hanging around that appears to be GC-related. * Add linux/ruby30 and macos/ruby30 * Use rvm master for 3.0.0-preview2 * Over 90% of tests are passing! 214 tests, 349898 assertions, 15 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications 92.5234% passed * Passes all tests! 214 tests, 369388 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed * A bunch of cleanup. 1. Removed a bunch of internal-only symbols from headers. 2. Required a frozen check to get a non-const pointer to a map or array. 3. De-duplicated the code to get a type argument for Map/RepeatedField. * Removed a bunch more stuff from protobuf.h. There is an intermittent assert failure. Intermittent failure: ruby: ../../../../ext/google/protobuf_c/protobuf.c:263: ObjectCache_Add: Assertion `rb_funcall(obj_cache2, (__builtin_constant_p("[]") ? __extension__ ({ static ID rb_intern_id_cache; if (!rb_intern_id_cache) rb_intern_id_cache = rb_intern2((("[]") ), (long)strlen(("[]"))); (ID) rb_intern_id_cache; }) : rb_intern("[]")), 1, key_rb) == val' failed * Removed a few more things from protobuf.h. * Ruby 3.0.0-preview2 to 3.0.0 * Require rake-compiler-dock >= 1.1.0 * More progress, fighting with the object cache. * Passes on all Ruby versions! * Updated and clarified comment regarding WeakMap. * Fixed the wyhash compile. * Fixed conformance tests for Ruby. Conformance results now look like: RUBYLIB=../ruby/lib:. ./conformance-test-runner --enforce_recommended --failure_list failure_list_ruby.txt --text_format_failure_list text_format_failure_list_ruby.txt ./conformance_ruby.rb CONFORMANCE TEST BEGIN ==================================== CONFORMANCE SUITE PASSED: 1955 successes, 0 skipped, 58 expected failures, 0 unexpected failures. CONFORMANCE TEST BEGIN ==================================== CONFORMANCE SUITE PASSED: 0 successes, 111 skipped, 8 expected failures, 0 unexpected failures. Fixes include: - Changed Ruby compiler to no longer reject proto2 maps. - Changed Ruby compiler to emit a warning when proto2 extensions are present instead of rejecting the .proto file completely. - Fixed conformance tests to allow proto2 and look up message by name instead of hardcoding a specific list of messages. - Fixed conformance test to support the "ignore unknown" option for JSON. - Fixed conformance test to properly report serialization errors. * Removed debug printf and fixed #inspect for floats. * Fixed compatibility test to have proper semantics for #to_json. * Updated Makefile.am with new file list. * Don't try to copy wyhash when inside Docker. * Fixed bug where we would forget that a sub-object is frozen in Ruby >=2.7. * Avoid exporting unneeded symbols and refactored a bit of code. * Some more refactoring. * Simplified and added more comments. * Some more comments and simplification. Added a missing license block. Co-authored-by: Masaki Hara <hara@wantedly.com>	4 years ago
listonjesse	2ae7cf0e03	Auxillary -> Auxiliary	5 years ago
Joshua Haberman	32e5deb1ac	Sync from Piper @308829107 PROTOBUF_SYNC_PIPER	5 years ago
Masaki Hara	f494cb222d	Test in Ruby 2.7 (#7386 ) * Test in Ruby 2.7 * Turn off GC.stress for 'require' in Ruby 2.7 * Backport `2c8364b` to compatibility_tests/v3.0.0	5 years ago
Joshua Haberman	c649397029	Set execute bit on files if and only if they begin with (#!). (#7347 ) * Set execute bit on files if and only if they begin with (#!). Git only tracks the 'x' (executable) bit on each file. Prior to this CL, our files were a random mix of executable and non-executable. This change imposes some order by making files executable if and only if they have shebang (#!) lines at the beginning. We don't have any executable binaries checked into the repo, so we shouldn't need to worry about that case. * Added fix_permissions.sh script to set +x iff a file begins with (#!).	5 years ago
Joshua Haberman	63f324a993	Roll forward Ruby upb changes now that protobuf Ruby build is fixed (#5866 ) * Rolled forward again with "Updated upb from defcleanup branch..." Revert "Revert "Updated upb from defcleanup branch and modified Ruby to use it (#5539)" (#5848)" This reverts commit `1568deab40`. * A few more merge fixes. * Updated for defcleanup2 branch. * Fixed upb to define upb_decode(). * Fixed names of nested messages. * Revert submodule. * Set -std=gnu90 and fixed warnings/errors. Some of our Kokoro tests seem to run with this level of warnings, and the source strives to be gnu90 compatible. Enforcing it for every build removes the possibility of some errors showing up in Kokoro/Travis tests only. * Fixed remaining warnings with gnu90 mode. I tried to match warning flags with what Ruby appears to do in our Kokoro tests. * Initialize values registered by rb_gc_register_address(). * Fixed subtle GC bug. We need to initialize this marked value before creating the instance. * Truly fix the GC bug. * Updated upb for mktime() fix. * Removed XOPEN_SOURCE as we are not using strptime(). * Removed fixed tests from the conformance failure list for Ruby. * Fixed memory error related to oneof def names. * Picked up new upb changes re: JSON printing. * Uncomment concurrent decoding test.	5 years ago
Joe Bolinger	580826cd97	cherry-pick test fix from #5853	6 years ago
Paul Yang	e75a689f7c	Fix ruby continuous tests (#5853 ) * Fix ruby continuous tests * Fix compatibility test	6 years ago
Paul Yang	de9e1a04a6	Add ruby 2.6 test (#5528 ) * Add ruby 2.6 test * Fix broken tests * Fix compatibility test * Fix bundler version * Use new docker image * Fix broken test * Use new docker image in ruby26 test * Install ruby for mac	6 years ago
Paul Yang	8356d270a5	Add continuous test for ruby 2.3, 2.4 and 2.5 (#4829 ) * Add continuous test for ruby 2.3, 2.4 and 2.5 * Change ruby 2.5 to 2.5.0 * No need to provide argument to rb_funcall when argc is 0 * Fix tests for ruby 2.5 * Use rescue instead of assert_raise to accept subclass of error	7 years ago
Paul Yang	78ba021b84	Add continuous test for ruby 2.3, 2.4 and 2.5 (#4829 ) * Add continuous test for ruby 2.3, 2.4 and 2.5 * Change ruby 2.5 to 2.5.0 * No need to provide argument to rb_funcall when argc is 0 * Fix tests for ruby 2.5 * Use rescue instead of assert_raise to accept subclass of error	7 years ago
Zachary Anker	87714836e3	Allow initializing a chain of protos using only a hash	7 years ago
Feng Xiao	9118ad659b	Add Ruby compatibilty test against 3.0.0.	8 years ago

3 Commits (b4b5c89c31b94ac0a89627c157edc173620ea257)