protobuf

16249 Commits

204 Branches

369 Tags

184 MiB

Tag: Branch: Tree: b41f04d42a

Commit Graph

Author	SHA1	Message	Date
Jakob Buchgraber	001be3c655	Implement Maps for scalar types for the C++ kernel This CL implements Maps for scalar types for the C++ runtime. It's orthogonal to cl/580453646. This CL is constrained by having to force template instantiation of proto2::Map<K, V>. Put differently, a Rust protobuf::Map<K, V> implementation needs to call 'extern "C"' functions with both key and value type in the function name (e.g. __pb_rust_Map_i32_f64_get()). We use macros to generate a Map implementation for every (K,V)-pair. An alternative would have been to use vtables. Luckily a key in a protobuf map can only be integer types, bool and string. So the number of key types is bounded by the specification, while the number of value types is not i.e. any protobuf message can be a value in a map. Given these constraints we introduce one 'MapKeyOps' trait per key type e.g. MapKeyBOOLOps or MapKeyI32Ops. These traits need to be implemented for every value type e.g. 'impl MapKeyBOOLOps for i32' will implement 'Map::<bool, i32>'. In particular the MapKeyOps traits can also be implemented for generated messages without violating the orphan rule. This CL also contains significant changes to the UPB runtime so that both upb.rs and cpp.rs export a similar interface to simplify the implementation in map.rs and the generated code. This CL does not yet implement the Proxied trait. PiperOrigin-RevId: 582951914	1 year ago
Kevin King	65cdac4ac5	Finish Proxied impls for rust repeated scalars PiperOrigin-RevId: 575935874	1 year ago
Protobuf Team Bot	e1bb7d65a8	Implement rust repeated scalars for cpp and upb PiperOrigin-RevId: 574261929	1 year ago

Author

SHA1

Message

Date

Jakob Buchgraber

001be3c655

Implement Maps for scalar types for the C++ kernel

This CL implements Maps for scalar types for the C++ runtime. It's orthogonal to cl/580453646. This CL is constrained by having to force template instantiation of proto2::Map<K, V>. Put differently, a Rust protobuf::Map<K, V> implementation needs to call 'extern "C"' functions with both key and value type in the function name (e.g. __pb_rust_Map_i32_f64_get()). We use macros to generate a Map implementation for every (K,V)-pair. An alternative would have been to use vtables.

Luckily a key in a protobuf map can only be integer types, bool and string. So the number of key types is bounded by the specification, while the number of value types is not i.e. any protobuf message can be a value in a map. Given these constraints we introduce one 'MapKeyOps' trait per key type e.g. MapKeyBOOLOps or MapKeyI32Ops. These traits need to be implemented for every value type e.g. 'impl MapKeyBOOLOps for i32' will implement 'Map::<bool, i32>'. In particular the MapKeyOps traits can also be implemented for generated messages without violating the orphan rule.

This CL also contains significant changes to the UPB runtime so that both upb.rs and cpp.rs export a similar interface to simplify the implementation in  map.rs and the generated code.

This CL does not yet implement the Proxied trait.

PiperOrigin-RevId: 582951914

1 year ago

Kevin King

65cdac4ac5

Finish Proxied impls for rust repeated scalars

PiperOrigin-RevId: 575935874

1 year ago

Protobuf Team Bot

e1bb7d65a8

Implement rust repeated scalars for cpp and upb

PiperOrigin-RevId: 574261929

1 year ago

3 Commits (b41f04d42acdbc0e9f8cd95d325559cc3a166eab)