Update the length check in google::protobuf::CEscapeInternal to account
for the extra NUL character emitted by snprintf when escaping hex and
octal sequences.
That function is an internal detail, not exported via any header.
Internally, it is used in two places, and both calls make buffers
that do have space for the extra NUL.
So in the actual usage, the check is redundant.
Move to explicit on single arg c'tors.
Move to unordered container types when working with pointers as order is likely unnecessary and just a performance issue.
This commit changes update_file_lists.sh to use Bazel as the source of truth. Currently, only the cmake build is actually affected, but Automake should be fairly straightforward to convert.
The file lists were originally factored out in PR#10027. This commit actually switches over to the Bazel-generated lists.
* [Bazel] Add a doc explaining our C++ build systems and distribution archives. (#10073)
* use char to find instead of string
Co-authored-by: David L. Jones <dlj@google.com>
This is in preparation for generating file lists automatically.
I am putting the list of files under src/, not under cmake/, so that it will be next to the file list for automake (see #10029). I can certainly put the list back under cmake/, but in general, I think we probably want to move the cmake targets e.g. to src/CMakeLists.txt anyhow.
Some of the continuous aarch64 builds started failing yesterday because
the autotools -> CMake change caused the protoc binary to end up in an
unexpected location. This change fixes the problem by putting a symlink
in the src/ directory.
This reverts commit c80808ce1d.
Thix fixes#10045. Somehow the change caused these four .cmake files to
stop being installed:
protobuf-config.cmake
protobuf-config-version.cmake
protobuf-module.cmake
protobuf-options.cmake
After reverting the change, I confirmed that the files are being
installed again.
David Neto
Chenwei Xiao
YJ
Dave MacLachlan
Elliotte Rusty Harold
Thanet (Knack) Praneenararat
Elliotte Rusty Harold
strangewiz
secup
Tomer Vromen
mkruskal-google
zhangskz
Namgoo Lee
Sandy Zhang
David L. Jones
appledragon
bttk
Dennis Shao
Adam Cozzette
Protobuf Team Bot
deannagarcia
Dennis Shao