protobuf

2829 Commits

197 Branches

346 Tags

251 MiB

Tag: Branch: Tree: a73852630f

Commit Graph

Author	SHA1	Message	Date
Joshua Haberman	6d6ab90ece	Enable arena test (it was previously #ifdef'd away accidentally) PiperOrigin-RevId: 519782179	2 years ago
Joshua Haberman	d450990631	Allow for fuse/free races in `upb_Arena`. Implementation is by kfm@, I only added the portability code around it. `upb_Arena` was designed to be only thread-compatible. However, fusing of arenas muddies the waters somewhat, because two distinct `upb_Arena` objects will end up sharing state when fused. This causes a `upb_Arena_Free(a)` to interfere with `upb_Arena_Fuse(b, c)` if `a` and `b` were previously fused. It turns out that we can use atomics to fix this with about a 35% regression in fuse performance (see below). Arena create+free does not regress, thanks to special-case logic in Free(). `upb_Arena` is still a thread-compatible type, and it is still never safe to call `upb_Arena_xxx(a)` and `upb_Arena_yyy(a)` in parallel. However you can at least now call `upb_Arena_Free(a)` and `upb_Arena_Fuse(b, c)` in parallel, even if `a` and `b` were previously fused. Note that `upb_Arena_Fuse(a, b)` and `upb_Arena_Fuse(c, d)` is still not allowed if `b` and `c` were previously fused. In practice this means that fuses must still be single-threaded within a single fused group. Performance results: ``` name old cpu/op new cpu/op delta BM_ArenaOneAlloc 18.6ns ± 1% 18.6ns ± 1% ~ (p=0.726 n=18+17) BM_ArenaInitialBlockOneAlloc 6.28ns ± 1% 5.73ns ± 1% -8.68% (p=0.000 n=17+20) BM_ArenaFuseUnbalanced/2 44.1ns ± 2% 60.4ns ± 1% +37.05% (p=0.000 n=18+19) BM_ArenaFuseUnbalanced/8 370ns ± 2% 500ns ± 1% +35.12% (p=0.000 n=19+20) BM_ArenaFuseUnbalanced/64 3.52µs ± 1% 4.71µs ± 1% +33.80% (p=0.000 n=18+19) BM_ArenaFuseUnbalanced/128 7.20µs ± 1% 9.72µs ± 2% +34.93% (p=0.000 n=16+19) BM_ArenaFuseBalanced/2 44.4ns ± 2% 61.4ns ± 1% +38.23% (p=0.000 n=20+17) BM_ArenaFuseBalanced/8 373ns ± 2% 509ns ± 1% +36.57% (p=0.000 n=19+17) BM_ArenaFuseBalanced/64 3.55µs ± 2% 4.79µs ± 1% +34.80% (p=0.000 n=19+19) BM_ArenaFuseBalanced/128 7.26µs ± 1% 9.76µs ± 1% +34.45% (p=0.000 n=17+19) BM_LoadAdsDescriptor_Upb<NoLayout> 5.66ms ± 1% 5.69ms ± 1% +0.57% (p=0.013 n=18+20) BM_LoadAdsDescriptor_Upb<WithLayout> 6.30ms ± 1% 6.36ms ± 1% +0.90% (p=0.000 n=19+18) BM_LoadAdsDescriptor_Proto2<NoLayout> 12.1ms ± 1% 12.1ms ± 1% ~ (p=0.118 n=18+18) BM_LoadAdsDescriptor_Proto2<WithLayout> 12.2ms ± 1% 12.3ms ± 1% +0.50% (p=0.006 n=18+18) BM_Parse_Upb_FileDesc<UseArena, Copy> 12.7µs ± 1% 12.7µs ± 1% ~ (p=0.194 n=20+19) BM_Parse_Upb_FileDesc<UseArena, Alias> 11.6µs ± 1% 11.6µs ± 1% ~ (p=0.192 n=20+20) BM_Parse_Upb_FileDesc<InitBlock, Copy> 12.5µs ± 1% 12.5µs ± 0% ~ (p=0.750 n=18+14) BM_Parse_Upb_FileDesc<InitBlock, Alias> 11.4µs ± 1% 11.3µs ± 1% -0.34% (p=0.046 n=19+19) BM_Parse_Proto2<FileDesc, NoArena, Copy> 25.4µs ± 1% 25.7µs ± 2% +1.37% (p=0.000 n=18+18) BM_Parse_Proto2<FileDesc, UseArena, Copy> 12.1µs ± 2% 12.1µs ± 1% ~ (p=0.143 n=18+18) BM_Parse_Proto2<FileDesc, InitBlock, Copy> 11.9µs ± 3% 11.9µs ± 1% ~ (p=0.076 n=17+19) BM_Parse_Proto2<FileDescSV, InitBlock, Alias> 13.2µs ± 1% 13.2µs ± 1% ~ (p=0.053 n=19+19) BM_SerializeDescriptor_Proto2 5.97µs ± 4% 5.90µs ± 4% ~ (p=0.093 n=17+19) BM_SerializeDescriptor_Upb 10.4µs ± 1% 10.4µs ± 1% ~ (p=0.909 n=17+18) name old time/op new time/op delta BM_ArenaOneAlloc 18.7ns ± 2% 18.6ns ± 0% ~ (p=0.607 n=18+17) BM_ArenaInitialBlockOneAlloc 6.29ns ± 1% 5.74ns ± 1% -8.71% (p=0.000 n=17+19) BM_ArenaFuseUnbalanced/2 44.1ns ± 1% 60.6ns ± 1% +37.21% (p=0.000 n=17+19) BM_ArenaFuseUnbalanced/8 371ns ± 2% 500ns ± 1% +35.02% (p=0.000 n=19+16) BM_ArenaFuseUnbalanced/64 3.53µs ± 1% 4.72µs ± 1% +33.85% (p=0.000 n=18+19) BM_ArenaFuseUnbalanced/128 7.22µs ± 1% 9.73µs ± 2% +34.87% (p=0.000 n=16+19) BM_ArenaFuseBalanced/2 44.5ns ± 2% 61.5ns ± 1% +38.22% (p=0.000 n=20+17) BM_ArenaFuseBalanced/8 373ns ± 2% 510ns ± 1% +36.58% (p=0.000 n=19+16) BM_ArenaFuseBalanced/64 3.56µs ± 2% 4.80µs ± 1% +34.87% (p=0.000 n=19+19) BM_ArenaFuseBalanced/128 7.27µs ± 1% 9.77µs ± 1% +34.40% (p=0.000 n=17+19) BM_LoadAdsDescriptor_Upb<NoLayout> 5.67ms ± 1% 5.71ms ± 1% +0.60% (p=0.011 n=18+20) BM_LoadAdsDescriptor_Upb<WithLayout> 6.32ms ± 1% 6.37ms ± 1% +0.87% (p=0.000 n=19+18) BM_LoadAdsDescriptor_Proto2<NoLayout> 12.1ms ± 1% 12.2ms ± 1% ~ (p=0.126 n=18+19) BM_LoadAdsDescriptor_Proto2<WithLayout> 12.2ms ± 1% 12.3ms ± 1% +0.51% (p=0.002 n=18+18) BM_Parse_Upb_FileDesc<UseArena, Copy> 12.7µs ± 1% 12.7µs ± 1% ~ (p=0.149 n=20+19) BM_Parse_Upb_FileDesc<UseArena, Alias> 11.6µs ± 1% 11.6µs ± 1% ~ (p=0.211 n=20+20) BM_Parse_Upb_FileDesc<InitBlock, Copy> 12.5µs ± 1% 12.5µs ± 1% ~ (p=0.986 n=18+15) BM_Parse_Upb_FileDesc<InitBlock, Alias> 11.4µs ± 1% 11.3µs ± 1% ~ (p=0.081 n=19+18) BM_Parse_Proto2<FileDesc, NoArena, Copy> 25.4µs ± 1% 25.8µs ± 2% +1.41% (p=0.000 n=18+18) BM_Parse_Proto2<FileDesc, UseArena, Copy> 12.1µs ± 2% 12.1µs ± 1% ~ (p=0.558 n=19+18) BM_Parse_Proto2<FileDesc, InitBlock, Copy> 12.0µs ± 3% 11.9µs ± 1% ~ (p=0.165 n=17+19) BM_Parse_Proto2<FileDescSV, InitBlock, Alias> 13.2µs ± 1% 13.2µs ± 1% ~ (p=0.070 n=19+19) BM_SerializeDescriptor_Proto2 5.98µs ± 4% 5.92µs ± 3% ~ (p=0.138 n=17+19) BM_SerializeDescriptor_Upb 10.4µs ± 1% 10.4µs ± 1% ~ (p=0.858 n=17+18) ``` PiperOrigin-RevId: 518573683	2 years ago
Matt Kulukundis	5bc3cae2d7	Add threading tests for arenas PiperOrigin-RevId: 518009578	2 years ago

Author

SHA1

Message

Date

Joshua Haberman

6d6ab90ece

Enable arena test (it was previously #ifdef'd away accidentally)

PiperOrigin-RevId: 519782179

2 years ago

Joshua Haberman

d450990631

Allow for fuse/free races in `upb_Arena`.

Implementation is by kfm@, I only added the portability code around it.

`upb_Arena` was designed to be only thread-compatible.  However, fusing of arenas muddies the waters somewhat, because two distinct `upb_Arena` objects will end up sharing state when fused.  This causes a `upb_Arena_Free(a)` to interfere with `upb_Arena_Fuse(b, c)` if `a` and `b` were previously fused.

It turns out that we can use atomics to fix this with about a 35% regression in fuse performance (see below).  Arena create+free does not regress, thanks to special-case logic in Free().

`upb_Arena` is still a thread-compatible type, and it is still never safe to call `upb_Arena_xxx(a)` and `upb_Arena_yyy(a)` in parallel.  However you can at least now call `upb_Arena_Free(a)` and `upb_Arena_Fuse(b, c)` in parallel, even if `a` and `b` were previously fused.

Note that `upb_Arena_Fuse(a, b)` and `upb_Arena_Fuse(c, d)` is still not allowed if `b` and `c` were previously fused.  In practice this means that fuses must still be single-threaded within a single fused group.

Performance results:

```
name                                           old cpu/op  new cpu/op  delta
BM_ArenaOneAlloc                                 18.6ns ± 1%  18.6ns ± 1%     ~     (p=0.726 n=18+17)
BM_ArenaInitialBlockOneAlloc                     6.28ns ± 1%  5.73ns ± 1%   -8.68%  (p=0.000 n=17+20)
BM_ArenaFuseUnbalanced/2                         44.1ns ± 2%  60.4ns ± 1%  +37.05%  (p=0.000 n=18+19)
BM_ArenaFuseUnbalanced/8                          370ns ± 2%   500ns ± 1%  +35.12%  (p=0.000 n=19+20)
BM_ArenaFuseUnbalanced/64                        3.52µs ± 1%  4.71µs ± 1%  +33.80%  (p=0.000 n=18+19)
BM_ArenaFuseUnbalanced/128                       7.20µs ± 1%  9.72µs ± 2%  +34.93%  (p=0.000 n=16+19)
BM_ArenaFuseBalanced/2                           44.4ns ± 2%  61.4ns ± 1%  +38.23%  (p=0.000 n=20+17)
BM_ArenaFuseBalanced/8                            373ns ± 2%   509ns ± 1%  +36.57%  (p=0.000 n=19+17)
BM_ArenaFuseBalanced/64                          3.55µs ± 2%  4.79µs ± 1%  +34.80%  (p=0.000 n=19+19)
BM_ArenaFuseBalanced/128                         7.26µs ± 1%  9.76µs ± 1%  +34.45%  (p=0.000 n=17+19)
BM_LoadAdsDescriptor_Upb<NoLayout>               5.66ms ± 1%  5.69ms ± 1%   +0.57%  (p=0.013 n=18+20)
BM_LoadAdsDescriptor_Upb<WithLayout>             6.30ms ± 1%  6.36ms ± 1%   +0.90%  (p=0.000 n=19+18)
BM_LoadAdsDescriptor_Proto2<NoLayout>            12.1ms ± 1%  12.1ms ± 1%     ~     (p=0.118 n=18+18)
BM_LoadAdsDescriptor_Proto2<WithLayout>          12.2ms ± 1%  12.3ms ± 1%   +0.50%  (p=0.006 n=18+18)
BM_Parse_Upb_FileDesc<UseArena, Copy>            12.7µs ± 1%  12.7µs ± 1%     ~     (p=0.194 n=20+19)
BM_Parse_Upb_FileDesc<UseArena, Alias>           11.6µs ± 1%  11.6µs ± 1%     ~     (p=0.192 n=20+20)
BM_Parse_Upb_FileDesc<InitBlock, Copy>           12.5µs ± 1%  12.5µs ± 0%     ~     (p=0.750 n=18+14)
BM_Parse_Upb_FileDesc<InitBlock, Alias>          11.4µs ± 1%  11.3µs ± 1%   -0.34%  (p=0.046 n=19+19)
BM_Parse_Proto2<FileDesc, NoArena, Copy>         25.4µs ± 1%  25.7µs ± 2%   +1.37%  (p=0.000 n=18+18)
BM_Parse_Proto2<FileDesc, UseArena, Copy>        12.1µs ± 2%  12.1µs ± 1%     ~     (p=0.143 n=18+18)
BM_Parse_Proto2<FileDesc, InitBlock, Copy>       11.9µs ± 3%  11.9µs ± 1%     ~     (p=0.076 n=17+19)
BM_Parse_Proto2<FileDescSV, InitBlock, Alias>    13.2µs ± 1%  13.2µs ± 1%     ~     (p=0.053 n=19+19)
BM_SerializeDescriptor_Proto2                    5.97µs ± 4%  5.90µs ± 4%     ~     (p=0.093 n=17+19)
BM_SerializeDescriptor_Upb                       10.4µs ± 1%  10.4µs ± 1%     ~     (p=0.909 n=17+18)

name                                           old time/op             new time/op             delta
BM_ArenaOneAlloc                                 18.7ns ± 2%             18.6ns ± 0%     ~           (p=0.607 n=18+17)
BM_ArenaInitialBlockOneAlloc                     6.29ns ± 1%             5.74ns ± 1%   -8.71%        (p=0.000 n=17+19)
BM_ArenaFuseUnbalanced/2                         44.1ns ± 1%             60.6ns ± 1%  +37.21%        (p=0.000 n=17+19)
BM_ArenaFuseUnbalanced/8                          371ns ± 2%              500ns ± 1%  +35.02%        (p=0.000 n=19+16)
BM_ArenaFuseUnbalanced/64                        3.53µs ± 1%             4.72µs ± 1%  +33.85%        (p=0.000 n=18+19)
BM_ArenaFuseUnbalanced/128                       7.22µs ± 1%             9.73µs ± 2%  +34.87%        (p=0.000 n=16+19)
BM_ArenaFuseBalanced/2                           44.5ns ± 2%             61.5ns ± 1%  +38.22%        (p=0.000 n=20+17)
BM_ArenaFuseBalanced/8                            373ns ± 2%              510ns ± 1%  +36.58%        (p=0.000 n=19+16)
BM_ArenaFuseBalanced/64                          3.56µs ± 2%             4.80µs ± 1%  +34.87%        (p=0.000 n=19+19)
BM_ArenaFuseBalanced/128                         7.27µs ± 1%             9.77µs ± 1%  +34.40%        (p=0.000 n=17+19)
BM_LoadAdsDescriptor_Upb<NoLayout>               5.67ms ± 1%             5.71ms ± 1%   +0.60%        (p=0.011 n=18+20)
BM_LoadAdsDescriptor_Upb<WithLayout>             6.32ms ± 1%             6.37ms ± 1%   +0.87%        (p=0.000 n=19+18)
BM_LoadAdsDescriptor_Proto2<NoLayout>            12.1ms ± 1%             12.2ms ± 1%     ~           (p=0.126 n=18+19)
BM_LoadAdsDescriptor_Proto2<WithLayout>          12.2ms ± 1%             12.3ms ± 1%   +0.51%        (p=0.002 n=18+18)
BM_Parse_Upb_FileDesc<UseArena, Copy>            12.7µs ± 1%             12.7µs ± 1%     ~           (p=0.149 n=20+19)
BM_Parse_Upb_FileDesc<UseArena, Alias>           11.6µs ± 1%             11.6µs ± 1%     ~           (p=0.211 n=20+20)
BM_Parse_Upb_FileDesc<InitBlock, Copy>           12.5µs ± 1%             12.5µs ± 1%     ~           (p=0.986 n=18+15)
BM_Parse_Upb_FileDesc<InitBlock, Alias>          11.4µs ± 1%             11.3µs ± 1%     ~           (p=0.081 n=19+18)
BM_Parse_Proto2<FileDesc, NoArena, Copy>         25.4µs ± 1%             25.8µs ± 2%   +1.41%        (p=0.000 n=18+18)
BM_Parse_Proto2<FileDesc, UseArena, Copy>        12.1µs ± 2%             12.1µs ± 1%     ~           (p=0.558 n=19+18)
BM_Parse_Proto2<FileDesc, InitBlock, Copy>       12.0µs ± 3%             11.9µs ± 1%     ~           (p=0.165 n=17+19)
BM_Parse_Proto2<FileDescSV, InitBlock, Alias>    13.2µs ± 1%             13.2µs ± 1%     ~           (p=0.070 n=19+19)
BM_SerializeDescriptor_Proto2                    5.98µs ± 4%             5.92µs ± 3%     ~           (p=0.138 n=17+19)
BM_SerializeDescriptor_Upb                       10.4µs ± 1%             10.4µs ± 1%     ~           (p=0.858 n=17+18)
```

PiperOrigin-RevId: 518573683

2 years ago

Matt Kulukundis

5bc3cae2d7

Add threading tests for arenas

PiperOrigin-RevId: 518009578

2 years ago

3 Commits (a73852630f429daa22dfa22fe224813589640594)