protobuf

Commit Graph

Author	SHA1	Message	Date
Eric Salo	a3f5ee3a5b	detect and reject repeated field numbers within a oneof PiperOrigin-RevId: 509707627	2 years ago
Joshua Haberman	1b50271ca2	Fixed a bug in the matcher that caused false positives. Previously we were calling the static method `Equals()` which did not take into effect the custom comparator or string for reporting errors. PiperOrigin-RevId: 507344425	2 years ago
Joshua Haberman	6e1cbdfe09	Added fuzzer for descriptor parsing/serialization, and fixed several bugs. The initial motivation for this change was to fix a bug found by fuzzing. The old fuzz test (built on `cc_fuzz_target()`) detected an infinite loop if a bytes field default has an unterminated `\x` escape. To fix this bug while expanding fuzz coverage, I created a fuzz test that verifies that we can do a lossless round trip from descriptor -> DefPool -> descriptor. We use C++ as the source of truth for whether a descriptor is valid or not, and what the canonical serialization back to protobuf form should be. I wrote the new fuzz test using go/FuzzTest, which makes it easier and more readable to use an arbitrary `FileDescriptorSet` as input, while adding test cases for regressions. The fuzz test highlighted a handful of errors that I subsequently fixed and added regression tests for: 1. The aforementioned unterminated `\x` bug. 2. We were not propagating the `edition` field. 3. We were missing the CheckIdent() check in a few places. 4. We were rejecting files with empty name, whereas C++ allows this. 5. There were a few bugs with escaping string defaults. Since FuzzTest is Clang-only, I split the `FUZZ_TEST()` invocation from the regression tests, since the latter are portable and should be run on all platforms. Only `FUZZ_TEST()` itself is in a google3/Clang-only file. PiperOrigin-RevId: 506997362	2 years ago
Mike Kruskal	2b011bc759	Internal changes PiperOrigin-RevId: 487599716	2 years ago
Eric Salo	edecfd5eb0	upb: use the new reflection headers Reflection headers now live in upb/reflection/ so update our include statements to reflect this. (See what I did there?) PiperOrigin-RevId: 474596615	2 years ago
Protobuf Team Bot	97993b219d	rename upb::SymbolTable as upb::DefPool PiperOrigin-RevId: 456147709	3 years ago
Protobuf Team Bot	65bde4e75b	upb_Encode() now returns a status value PiperOrigin-RevId: 454740100	3 years ago
Joshua Haberman	85072ce04e	Fixed a bug in enum layout generation.	3 years ago
Joshua Haberman	0c541f3305	Single encode.	3 years ago
Joshua Haberman	499c2cc8b1	upb_extreg, upb_msg	3 years ago
Joshua Haberman	1c955f37ce	Mass API rename and clang-reformat (#485 ) * Wave 1: upb_fielddef. * upb_fielddef itself. * upb_oneofdef. * upb_msgdef. * ExtensionRange. * upb_enumdef * upb_enumvaldef * upb_filedef * upb_methoddef * upb_servicedef * upb_symtab * upb_defpool_init * upb_wellknown and upb_syntax_t * Some constants. * upb_status * upb_strview * upb_arena * upb.h constants * reflection * encode * JSON decode. * json encode. * msg_internal. * Formatted with clang-format. * Some naming fixups and comment reformatting. * More refinements. * A few more stragglers. * Fixed PyObject_HEAD with semicolon. Removed TODO entries.	3 years ago
Joshua Haberman	d0795a29d9	Test for def_to_proto is working.	3 years ago

12 Commits (a3f5ee3a5b901815bf465e5cbd52611bbca3175a)