Mike Kruskal
0e167e796f
Disallow all feature types except enum and boolean.
...
Features are designed as temporary migration tools, and any unbounded type leaves the system open to unexpected use. Features should have a fixed set of values, with well defined behaviors.
PiperOrigin-RevId: 617933544
9 months ago
Protobuf Team Bot
e6684ac037
C#: Avoid string concatenation when looking up enum values by name.
...
PiperOrigin-RevId: 616745400
9 months ago
Protobuf Team Bot
7ef5207d81
Auto-generate files after cl/616324144
9 months ago
Trayan Zapryanov
fac929d9aa
Cache StringBuilder instances in the .NET JsonTextTokenizer.
...
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/15794 from TrayanZapryanov:cache_stringbuilder 596147e6f1
PiperOrigin-RevId: 613251480
9 months ago
Protobuf Team Bot
f7317e02e6
Refactor C# FieldDescriptor.FieldType for consistency.
...
PiperOrigin-RevId: 612337931
9 months ago
Protobuf Team Bot
b6c0c30633
Auto-generate files after cl/611246775
10 months ago
Protobuf Team Bot
450022de99
Runtime support for Protobuf Editions in C#.
...
PiperOrigin-RevId: 611246775
10 months ago
Jaap Taal
72e0be1031
[csharp] Fix indentation for MapField with nested Messages ( #15836 )
...
WriteDictionary does not pass indentationLevel downwards to WriteValue. The existing test for `MapField` only tests `MapField<string, string>`, which isn't affected by the issue.
Tests are added for this issue.
Note: I also added `WriteValueWithIndentation_MapWithEmptyNested` to ensure this change would break things, but I doubt if it's necessary. Let me know whether to remove it.
Closes #15836
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/15836 from q42jaap:main 2b9399ba0c
PiperOrigin-RevId: 607000434
10 months ago
Protobuf Team Bot
6efaf1db54
Auto-generate files after cl/606786933
10 months ago
aiuto
3ab1276bbb
Update Bazel references to rules_pkg to the supported file locations. ( #15780 )
...
WIP: I want to see this pass CI first.
Fixes : #15779
3 scripted transforms:
```
-load("@rules_pkg//:mappings.bzl", ...)
+load("@rules_pkg//pkg:mappings.bzl", ...)
```
```
-load("@rules_pkg//:pkg.bzl", "pkg_tar")
+load("@rules_pkg//pkg:tar.bzl", "pkg_tar")
```
```
-load("@rules_pkg//:pkg.bzl", "pkg_zip")
+load("@rules_pkg//pkg:zip.bzl", "pkg_zip")
```
Closes #15780
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/15780 from aiuto:rules_pkg a630276341
PiperOrigin-RevId: 606641398
10 months ago
Protobuf Team Bot
55e50ba406
C#: Ignore invalid enum string values in JSON, when invalid fields are being ignored.
...
PiperOrigin-RevId: 605310357
10 months ago
Protobuf Team Bot
4767a309d3
Auto-generate files after cl/605097398
10 months ago
Protobuf Team Bot
41732e8fee
Auto-generate files after cl/604457261
10 months ago
Chris Kennelly
34a04c1fd5
Remove lazy=true from repeated fields.
...
This is currently a no-op in protoc.
PiperOrigin-RevId: 604457261
10 months ago
Anton Grbin
a5e10aff2b
[C#] Conformance test: don't skip JsonIgnoreUnknownParsingTest in runner ( #15369 )
...
# Motivation
https://github.com/protocolbuffers/protobuf/issues/7392#issuecomment-1884666885
This is for completeness - I am not blocked by this change in any way, so feel free to close the PR or treat is a low priority.
# Changes
Implement JsonIgnoreUnknownParsingTest in C# conformance test runner.
# Tested
Locally with:
```
bazel test //csharp:conformance_test \
--action_env=DOTNET_CLI_TELEMETRY_OPTOUT=1 --test_env=DOTNET_CLI_HOME=~ \
--action_env=DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1
```
Closes #15369
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/15369 from noom:issue-7392/show-csharp-failures 3a652202a0
PiperOrigin-RevId: 602537927
11 months ago
Dennis Shao
9146ce6ddb
Updating version.json and repo version numbers to: 27-dev ( #15590 )
...
Closes #15590
PiperOrigin-RevId: 601468713
11 months ago
Austin Wise
48c80e46bb
Fix setting of environmental variables in build_release.sh
...
PiperOrigin-RevId: 601316979
11 months ago
Protobuf Team Bot
3d79d0374b
Auto-generate files after cl/599369761
11 months ago
Protobuf Team Bot
27af4c802f
Auto-generate files after cl/599220883
11 months ago
Protobuf Team Bot
41c8f2a5c6
Auto-generate files after cl/597378801
11 months ago
Protobuf Team Bot
55260d8321
Auto-generate files after cl/596018472
11 months ago
Protobuf Team Bot
79cc57bf57
Auto-generate files after cl/594312823
12 months ago
Protobuf Team Bot
e0b3610e7f
Auto-generate files after cl/594261739
12 months ago
Protobuf Team Bot
8981fe5cab
Auto-generate files after cl/592677762
12 months ago
James Newton-King
ec1fd2700e
[C#] Fix trimming warning in JSON formatter enum handling ( #14789 )
...
There is a new trimming/AOT warning in JSON formatter enum handling. I have fixed it by suppressing the value.
I also tested the solution with the .NET 8 SDK and suppressed some other warnings that came up (they're already handled).
It would be great to include this fix in a 25.x release.
Closes #14789
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14789 from JamesNK:jamesnk/enum-trimming-warning d64dda15f0
PiperOrigin-RevId: 592306588
12 months ago
Protobuf Team Bot
d159913c0d
Auto-generate files after cl/590998510
1 year ago
Protobuf Team Bot
4b2a30c22c
Slightly relax JSON integer parsing tests to handle a wider range of runtime behaviors around
...
parsing floating point values not exactly representable as the destination type.
PiperOrigin-RevId: 590739762
1 year ago
Protobuf Team Bot
de57b67561
Auto-generate files after cl/586781244
1 year ago
Protobuf Team Bot
4d31a3451b
Auto-generate files after cl/586756816
1 year ago
Protobuf Team Bot
43a950bfa6
Auto-generate files after cl/586448719
1 year ago
Protobuf Team Bot
5b8b87f3f7
Auto-generate files after cl/586204703
1 year ago
Protobuf Team Bot
b41f04d42a
Auto-generate files after cl/583411456
1 year ago
marner2
c1e0853f70
Fix csharp fieldmasktree merge null checking ( #12737 )
...
Fixes #12685 for CSharp, but the Java equivalent probably has the same bug.
Closes #12737
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12737 from marner2:fix_csharp_fieldmasktree_merge_null_checking 78c7812ac3
PiperOrigin-RevId: 579314424
1 year ago
Jie Luo
1231af10c7
merge 25.x to main ( #14617 )
...
Closes #14617
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14617 from anandolee:25.x ac86c5ef32
PiperOrigin-RevId: 578996979
1 year ago
Protobuf Team Bot
3ea774370a
Internal change
...
PiperOrigin-RevId: 578944754
1 year ago
Protobuf Team Bot
6b5d8db01f
Updating version.json and repo version numbers to: 25.0
1 year ago
Protobuf Team Bot
ba1aab2baf
Updating version.json and repo version numbers to: 25.0-rc2
1 year ago
Protobuf Team Bot
896f3d8ced
Updating version.json and repo version numbers to: 25.0-rc1
1 year ago
Protobuf Team Bot
4b301ad764
Auto-generate files after cl/573375994
1 year ago
Protobuf Team Bot
499dd1c3f4
Auto-generate files after cl/572264242
1 year ago
Protobuf Team Bot
ac5a13ce75
Update dependencies in C# test project.
...
PiperOrigin-RevId: 570922351
1 year ago
Protobuf Team Bot
c04b501e7c
Auto-generate files after cl/570746314
1 year ago
Protobuf Team Bot
6703802f20
Auto-generate files after cl/570576252
1 year ago
James Newton-King
68fce2e22a
Use ConcurrentDictionary in JsonFormatter ( #14272 )
...
I have a theory that the lock in `JsonFormatter` periodically causes this VS debugging error for Protobuf types:
![image](https://github.com/protocolbuffers/protobuf/assets/303201/64097805-67ab-43fe-a4a0-77ec4590844d )
Hopefully `ConcurrentDictionary` resolves this issue. Even if it doesn't, this change still resolves the TODO so this is a good improvement.
Closes #14272
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14272 from JamesNK:jamesnk/concurrentdictionary 6ec3ebc2f6
PiperOrigin-RevId: 570439102
1 year ago
Protobuf Team Bot
206583d39b
Auto-generate files after cl/568927357
1 year ago
Adam Cozzette
501ececd39
Reorganize upb file structure
...
This change moves almost everything in the `upb/` directory up one level, so
that for example `upb/upb/generated_code_support.h` becomes just
`upb/generated_code_support.h`. The only exceptions I made to this were that I
left `upb/cmake` and `upb/BUILD` where they are, mostly because that avoids
conflict with other files and the current locations seem reasonable for now.
The `python/` directory is a little bit of a challenge because we had to merge
the existing directory there with `upb/python/`. I made `upb/python/BUILD` into
the BUILD file for the merged directory, and it effectively loads the contents
of the other BUILD file via `python/build_targets.bzl`, but I plan to clean
this up soon.
PiperOrigin-RevId: 568651768
1 year ago
Protobuf Team Bot
61127956a7
Auto-generate files after cl/568621264
1 year ago
Protobuf Team Bot
ab58f8fbab
Auto-generate files after cl/568554147
1 year ago
Lydon Chandra
96100bf1e4
add C# deterministic serialization ( #13160 )
...
https://github.com/protocolbuffers/protobuf/issues/12881
@jskeet review please :-) as this is my first contrib to protobuf, any design / performance feedback is very sought after
Closes #13160
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/13160 from fmg-lydonchandra:feature/12881_cs_serialization_deterministic ab7e01b804
PiperOrigin-RevId: 568448399
1 year ago
James Newton-King
67b9c76752
Add .NET debugging attributes ( #14097 )
...
I've been working with a large Protobuf model and noticed debugging issues that can easily be improved.
Add debugging attributes to collections, `ByteString`, and descriptors. No impact on runtime behavior. Debugger type proxies are what the debugger displays by default, but full data is available by selecting "Raw View".
`RepeatedField` and `MapField` now display their item count. This is standard across .NET collections. For example, .NET's list and dictionary both display `Count = {Count}`.
Note that previously, Protobuf collections displayed the result of `ToString`, which returned JSON. The JSON debug view isn't useful when there is too much content to display at once because it's truncated. That experience will be fairly common.
Count benefits:
* Always useful
* Makes debugging Protobuf collections feel more like regular .NET collections
* Collection contents is now easier to access with debugger type proxies
No dependency between this PR and https://github.com/protocolbuffers/protobuf/pull/13838 . Each can be merged independently.
**MapField before:**
![image](https://github.com/protocolbuffers/protobuf/assets/303201/9dd3baa9-4432-446e-9049-1f7268d5be4c )
**MapField after:**
![image](https://github.com/protocolbuffers/protobuf/assets/303201/ac4aea33-e339-49e0-9a67-c174d2608393 )
**RepeatedField before:**
![image](https://github.com/protocolbuffers/protobuf/assets/303201/16353785-bef4-4489-a3ab-de2437d51d4e )
**RepeatedField after:**
![image](https://github.com/protocolbuffers/protobuf/assets/303201/f3de7680-ded9-41d8-aac0-84a9e7b65c98 )
**ByteString before:**
![image](https://github.com/protocolbuffers/protobuf/assets/303201/4febc400-1eb7-46ee-911e-a7698783a358 )
**ByteString after:**
![image](https://github.com/protocolbuffers/protobuf/assets/303201/7635080e-9bb0-4f61-9a39-afbb9e575051 )
**Descriptor before:**
![image](https://github.com/protocolbuffers/protobuf/assets/303201/5b89792b-a16a-4641-a50c-5355b5230b5d )
**Descriptor after:**
![image](https://github.com/protocolbuffers/protobuf/assets/303201/5047dc1e-c93b-43d5-bb8c-a6976a9ae6da )
**TypeRegistry before:**
![image](https://github.com/protocolbuffers/protobuf/assets/303201/d4aedf19-22cc-49b5-8717-9299e00abc85 )
**TypeRegistry after:**
![image](https://github.com/protocolbuffers/protobuf/assets/303201/4a473595-74b9-40e2-96b8-2b103d5f44b0 )
Closes #14097
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14097 from JamesNK:jamesnk/debugging f0dea3464d
PiperOrigin-RevId: 568444117
1 year ago