Protobuf Team Bot
f82c2ef0db
Minor cleanup: whitelist --> allowlist
...
PiperOrigin-RevId: 605439980
1 year ago
Protobuf Team Bot
b3878b5ae3
Auto-generate files after cl/605413999
1 year ago
Eric Salo
b0d3a787cc
upb: Simplify inline functions in mini_table/ and mem/ and wire/ and message/
...
PiperOrigin-RevId: 605413999
1 year ago
Protobuf Team Bot
5427138178
Remove rust proto libraries from the editions/BUILD file.
...
PiperOrigin-RevId: 605397582
1 year ago
Protobuf Team Bot
9443f08fad
Auto-generate files after cl/605368710
1 year ago
Protobuf Team Bot
2fc7022879
Adds string view fields whose accessors are absl::string_view based.
...
PiperOrigin-RevId: 605368710
1 year ago
Protobuf Team Bot
55e50ba406
C#: Ignore invalid enum string values in JSON, when invalid fields are being ignored.
...
PiperOrigin-RevId: 605310357
1 year ago
Protobuf Team Bot
959e5df20f
Minor cleanup: IWYU, clang-tidy.
...
PiperOrigin-RevId: 605131702
1 year ago
Adam Cozzette
220548f30c
Add missing alias targets for C++ util libraries
...
Until recently, these targets were dependencies of `//:protobuf` and could thus
be accessed through that target. But now that we are adhering to the layering
check, we need to provide proper access in a way that respects that check. This
change uses top-level alias targets following the existing pattern.
PiperOrigin-RevId: 605123979
1 year ago
Protobuf Team Bot
4767a309d3
Auto-generate files after cl/605097398
1 year ago
Joshua Haberman
49fdc9d1cd
Rewrote the comment about the `java_string_check_utf8` option to fix a few errors and omissions.
...
- The comment stated that the option does not affect lite, but this appears to be false: in my testing the option affects both lite and full protos.
- The comment failed to mention that the option has no effect when set explicitly to false. It can only be used to opt proto2 into extra checking, it cannot opt proto3 out of the checks.
PiperOrigin-RevId: 605097398
1 year ago
Protobuf Team Bot
afd1c0d653
Add a test that when using an Arena from a single thread, objects are destroyed in reverse order from construction.
...
PiperOrigin-RevId: 605085198
1 year ago
Protobuf Team Bot
31920e9548
Auto-generate files after cl/605067418
1 year ago
Ilya Tokar
948ca2e0f3
Add software prefetch to ByteSizeLong
...
Mkaes ByteSizeLong faster:
BM_ByteSizeLong 15.7µs ± 4% 14.9µs ± 6% -5.17% (p=0.000 n=20+20)
PiperOrigin-RevId: 605067418
1 year ago
Protobuf Team Bot
85a80488ff
Fix unnecessary generation of PostLoopHandler when tracking is on, but
...
OnDeserialize is disabled.
PiperOrigin-RevId: 605060804
1 year ago
Matt Kulukundis
38c0f6d01c
Switch rank structs to be consistent with written guidance in go/ranked-overloads
...
PiperOrigin-RevId: 605015758
1 year ago
Joshua Haberman
ffd7e1702a
Updated freshness on several docs, and made some minor updates to the content.
...
PiperOrigin-RevId: 604993985
1 year ago
Protobuf Team Bot
f55a9b4936
Use the post-loop hook to invoke the tracker when parsing via TcParser.
...
PiperOrigin-RevId: 604780875
1 year ago
Protobuf Team Bot
a2cdf59778
Adding Edition 2023 z_generated_example.
...
PiperOrigin-RevId: 604754130
1 year ago
Alyssa Haroldsen
a522a47120
Validate that map keys are copied
...
PiperOrigin-RevId: 604716574
1 year ago
Alyssa Haroldsen
398508287e
Correct ExactSizeIterator impl for RepeatedIter
...
- size_hint must be implemented as described in the docs
- len/size_hint must return the number of items remaining in the iterator, not the size of the container
PiperOrigin-RevId: 604704172
1 year ago
Alyssa Haroldsen
3ccccdb855
Copy repeated string/bytes in upb when pushing/setting/copying
...
This memory management should be handled by Rust.
I've confirmed this works by running the new included tests with msan.
The sanitizer is necessary to detect an incorrect copy_from impl
that uses-after-free from the upb arena.
PiperOrigin-RevId: 604689154
1 year ago
Adam Cozzette
e8535e70da
Internal change
...
PiperOrigin-RevId: 604672870
1 year ago
Alyssa Haroldsen
01312f9c34
Add RepeatedIter to public protobuf items
...
PiperOrigin-RevId: 604554509
1 year ago
Alyssa Haroldsen
a9bcb60dc5
Remove RepeatedIterMut
...
Mutator access in repeated and map is a 1.0 feature.
PiperOrigin-RevId: 604554490
1 year ago
Éamonn McManus
3c2fa8f21c
Internal change.
...
PiperOrigin-RevId: 604537991
1 year ago
Mariano Simone
11eab86cc0
[Ruby] Delegate difference, intersection, union from RepeatedField to Array ( #15652 )
...
Coming from [[protobuf/issues/15180] [Ruby] Support for currently ignored Array methods in `RepeatedField`](https://github.com/protocolbuffers/protobuf/issues/15180 )
This adds a couple of `Array` methods to what gets delegated from `RepeatedField`.
- `intersection`, because `|` was already delegated
- `union`, because `&` was already delegated
- `difference`, because `-` was already delegated
Closes #15652
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/15652 from marianosimone:delegate_rb_array_methods 2971981338
PiperOrigin-RevId: 604534655
1 year ago
Jiri Pechanec
c98bdc2bdc
Add missing generated file ( #15693 )
...
The proto file is required for Java test. Otherwise it fails with
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile (default-testCompile) on project protobuf-java: Compilation failure: Compilation failure:
[ERROR] /tmp/protocolbuffers-protobuf-3.25.2/java/core/src/test/java/com/google/protobuf/DescriptorsTest.java:[46,25] cannot find symbol
[ERROR] symbol: class UnittestRetention
[ERROR] location: package protobuf_unittest
[ERROR] /tmp/protocolbuffers-protobuf-3.25.2/java/core/src/test/java/com/google/protobuf/DescriptorsTest.java:[550,27] cannot find symbol
[ERROR] symbol: variable UnittestRetention
[ERROR] location: class com.google.protobuf.DescriptorsTest
[ERROR] /tmp/protocolbuffers-protobuf-3.25.2/java/core/src/test/java/com/google/protobuf/DescriptorsTest.java:[551,37] cannot find symbol
[ERROR] symbol: variable UnittestRetention
[ERROR] location: class com.google.protobuf.DescriptorsTest
[ERROR] /tmp/protocolbuffers-protobuf-3.25.2/java/core/src/test/java/com/google/protobuf/DescriptorsTest.java:[552,37] cannot find symbol
[ERROR] symbol: variable UnittestRetention
[ERROR] location: class com.google.protobuf.DescriptorsTest
[ERROR] /tmp/protocolbuffers-protobuf-3.25.2/java/core/src/test/java/com/google/protobuf/DescriptorsTest.java:[553,37] cannot find symbol
[ERROR] symbol: variable UnittestRetention
[ERROR] location: class com.google.protobuf.DescriptorsTest
[ERROR] -> [Help 1]
```
Closes #15693
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/15693 from jpechane:add-missing-file 9293fabf1f
PiperOrigin-RevId: 604518500
1 year ago
Luke Sandberg
5d4fd7ef84
Clarify docs on MapFieldReflectionAccessorInternal and add tests for the mutability of lists returned from `getAllFields()`
...
PiperOrigin-RevId: 604508075
1 year ago
Alyssa Haroldsen
d445953603
Add map key and value iterators
...
PiperOrigin-RevId: 604495084
1 year ago
Protobuf Team Bot
f5a225597b
Minor cleanup: IWYU, shoud_split() instead of ShouldSplit(...).
...
PiperOrigin-RevId: 604471605
1 year ago
Protobuf Team Bot
41732e8fee
Auto-generate files after cl/604457261
1 year ago
Bernard Normier
3121f8ce10
Add IceRPC to the list of third-party RPC implementations ( #15072 )
...
This PR adds IceRPC for C# to the list of RPC implementations in third_party.doc.
IceRPC provides full support for Protobuf. See https://docs.icerpc.dev/protobuf for details.
Closes #15072
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/15072 from bernardnormier:add-icerpc 857e34e8ce
PiperOrigin-RevId: 604459237
1 year ago
Chris Kennelly
34a04c1fd5
Remove lazy=true from repeated fields.
...
This is currently a no-op in protoc.
PiperOrigin-RevId: 604457261
1 year ago
Alyssa Haroldsen
035d6ec2cb
Implement map iteration
...
PiperOrigin-RevId: 604447996
1 year ago
Chris Kennelly
37826c1da6
Only consider scalar submessages eligible for explicit lazy.
...
While other fields can be tagged "lazy", they do not impact codegen.
PiperOrigin-RevId: 604443879
1 year ago
Protobuf Team Bot
9e57b8e0d8
Add prefetching in arena blocks.
...
PiperOrigin-RevId: 604441990
1 year ago
Hong Shin
dbf7adfabc
protobuf: Replace NULL with nullptr in terra cpp
...
PiperOrigin-RevId: 604429747
1 year ago
Alyssa Haroldsen
3657e05292
Improve field publicity for repeated/maps
...
A public "raw" field in a safe wrapper is guaranteed unsound!
This makes repeated and map inner access consistent and
avoids exposing raw internals.
It also provides the accessors necessary for implementing map
access for external types.
PiperOrigin-RevId: 604405543
1 year ago
Adam Cozzette
3995f538ed
Fix crash found by fuzzer in descriptor.cc
...
PiperOrigin-RevId: 604391963
1 year ago
Protobuf Team Bot
bdd833f8fc
Fix issue where nested messages in non-primary .proto files couldn't be used.
...
PiperOrigin-RevId: 604383247
1 year ago
Protobuf Team Bot
2699579875
Breaking change: Remove the deprecated always_print_primitive_fields option from Java, Python and C++ JSON parsers.
...
The replacement always_print_without_presence_fields should be used instead, which is very similar but has consistent handling of optional fields by not affecting them.
PiperOrigin-RevId: 604381178
1 year ago
Alyssa Haroldsen
4c61b4364a
Consolidate PhantomData in maps
...
PiperOrigin-RevId: 604373597
1 year ago
Protobuf Team Bot
1b3dc52634
Automated rollback of commit 690f100a66
.
...
PiperOrigin-RevId: 604369183
1 year ago
Protobuf Team Bot
986d691d77
use "proto3_optional" option as signal that a field has presence.
...
This is technically redundant with the synthetic oneof container, but simplifies some tooling.
PiperOrigin-RevId: 604368850
1 year ago
Protobuf Team Bot
4d23fa068a
Move the RubyMessage.java JSON "include defaults" to use alwaysPrintFieldsWithNoPresence.
...
This is no different on proto3 but treats proto2-optional differently (to make it consistent with proto3-optional).
PiperOrigin-RevId: 604354927
1 year ago
Protobuf Team Bot
17bed48dd1
Remove the leftover fake message objects used to call ParseGroup.
...
All of those now call with a lambda instead.
PiperOrigin-RevId: 604346823
1 year ago
Protobuf Team Bot
96f3eeb91a
Add validation for string_type and ctype under edition 2024 and over.
...
PiperOrigin-RevId: 604345202
1 year ago
Jakob Buchgraber
929f19d3cc
#protobuf #rust publicly export ParseError
...
It's returned by Msg::deserialize() -> Result<(), ParseError> and should be publicly nameable as protobuf::ParseError.
PiperOrigin-RevId: 604326858
1 year ago
Chris Kennelly
cd47034a68
Prohibit lazy map fields.
...
They are a no-op in protoc.
PiperOrigin-RevId: 604324139
1 year ago