deannagarcia
9e2941faa4
Merge pull request #12632 from deannagarcia/23.x
...
Cherrypick fixes for 23.0-rc3
2 years ago
Deanna Garcia
b36c39236e
Fix bug in _internal_copy_files where the rule would fail in downstream repositories.
...
Taken from https://github.com/protocolbuffers/upb/blob/main/bazel/protobuf.patch#L42
Fixes https://github.com/protocolbuffers/protobuf/issues/12620 .
PiperOrigin-RevId: 528586464
2 years ago
Deanna Garcia
ad2dd26ffc
Mark internal rule manual
2 years ago
deannagarcia
28003bb6e0
Merge pull request #12623 from deannagarcia/23.x
...
fix(libprotoc): export useful symbols from .so
2 years ago
Carlos O'Ryan
46fb4aa8d2
fix(libprotoc): export useful symbols from .so
2 years ago
deannagarcia
d4ce533dcb
Merge pull request #12608 from protocolbuffers/23.x-202304281840
...
Update version numbers for 23.0-rc2
2 years ago
Protobuf Team Bot
29b8dc0eef
Updating version.json to: 23.0-dev
2 years ago
Protobuf Team Bot
51f51ac4ef
Updating version.json and repo version numbers to: 23.0-rc2
2 years ago
deannagarcia
e2bb23712a
Merge pull request #12607 from deannagarcia/23.x
...
Update UPB Dependency
2 years ago
Deanna Garcia
eb96482b3a
Update UPB dep
2 years ago
Mike Kruskal
0b73dd44a3
Add -ex switch to all docker bash commands. ( #12601 )
...
Without this, certain failures will be silently ignored.
PiperOrigin-RevId: 527718574
2 years ago
Mike Kruskal
49bb3f2064
Fixes Clang 6 linker bug ( #12600 )
...
PiperOrigin-RevId: 527711840
2 years ago
deannagarcia
aa4a192884
Merge pull request #12593 from protocolbuffers/23.0-rc2-patch
...
Cherrypick fixes for 23.0-rc2 into 23.x
2 years ago
Deanna Garcia
d19c7997ab
Fix bom tests
2 years ago
Deanna Garcia
99c9491f7c
Fix maven pom test
2 years ago
Mike Kruskal
e67e58a8e9
Silence deprecation warnings on FileDescriptor::SyntaxName
...
PiperOrigin-RevId: 527600194
2 years ago
Deanna Garcia
433c35dbcb
Remove osgi dependency from main java libraries.
...
//java:core, //java:lite, and //java:util shouldn't have this extra dependency. For now, we just add a separate version but we will look into using the java_library in protobuf_versioned_java_library in the future.
PiperOrigin-RevId: 527643325
2 years ago
Mike Kruskal
112a9021be
Squashed 'third_party/utf8_range/' changes from 72c943dea..cd1507d14 ( #12583 )
...
cd1507d14 Fix typo in pkg-config file to properly link the utf8_range libraries
3f179d134 Add pkg-config file declaring Abseil dependency of utf8_range
git-subtree-dir: third_party/utf8_range
git-subtree-split: cd1507d1479815fbcd8ff24dc05a978a62098bae
2 years ago
Mike Kruskal
db1d3f8b51
Replace previous breaking changes with deprecation warnings.
...
These changes hid public APIs that are deprecated in advance of protobuf editions. They will be fully removed in a future release. Any uses of them should be migrated to the future-facing feature helpers we provide on descriptor classes.
PiperOrigin-RevId: 527422059
2 years ago
Mike Kruskal
2230d0e748
Fix homebrew issue on Mac runners causing PHP CI failures
...
PiperOrigin-RevId: 527419345
2 years ago
Protobuf Team Bot
04a1a52892
Updating version.json to: 23.0-dev
2 years ago
Protobuf Team Bot
b21d6be78b
Updating version.json and repo version numbers to: 23.0-rc1
2 years ago
Deanna Garcia
b26afb5a86
Update protobuf's UPB dep in preparation for the 23.0-rc1 release.
...
PiperOrigin-RevId: 527061210
2 years ago
Protobuf Team Bot
132c67c2c7
Auto-generate files after cl/527051764
2 years ago
Protobuf Team Bot
182d564a3f
Move all the reflection related data of MapField into a separate structure.
...
This saves 24 bytes on each `map` field when reflection is not used.
It also delays constructing a Mutex until reflection is needed. This means we do
not have to register the mutex for destruction in the arena for normal
operation.
PiperOrigin-RevId: 527051764
2 years ago
Mike Kruskal
9898418bd9
Fix btree issue in map tests.
...
Without any weak ordering, btree_map fails to compile on windows 2022.
Closes #12289
PiperOrigin-RevId: 527019995
2 years ago
Son Luong Ngoc
5233990ad7
Fix protoc_nowkt linking on MacOS ( #12320 )
...
Depending on how the local cc toolchain is setup on macos, the core
foundation framework might not be available while linking protoc_nowkt.
This results in a few _CF symbols being interpreted as dynamic load and
is set to the binary's flat-namespace, causing runtime errors during
susequent actions such as gen_wkt_cc_sources.
```bash
> otool -dyld_info bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/com_google_protobuf/src/google/protobuf/compiler/protoc_nowkt | grep '_CF'
__DATA_CONST __got 0x10035C038 0x8010000000000007 bind 0x0 flat-namespace _CFRelease
__DATA_CONST __got 0x10035C040 0x8010000000000008 bind 0x0 flat-namespace _CFStringGetCString
__DATA_CONST __got 0x10035C048 0x8010000000000009 bind 0x0 flat-namespace _CFStringGetLength
__DATA_CONST __got 0x10035C050 0x801000000000000A bind 0x0 flat-namespace _CFStringGetMaximumSizeForEncoding
__DATA_CONST __got 0x10035C058 0x801000000000000B bind 0x0 flat-namespace _CFTimeZoneCopyDefault
__DATA_CONST __got 0x10035C060 0x801000000000000C bind 0x0 flat-namespace _CFTimeZoneGetName
```
Tell the linker to use CoreFoundation framework explicitly fixes this
issue.
```bash
> otool -dyld_info bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/com_google_protobuf/src/google/protobuf/compiler/protoc_nowkt | grep '_CF'
__DATA_CONST __got 0x10035C038 0x8010000000000007 bind 0x0 CoreFoundation _CFRelease
__DATA_CONST __got 0x10035C040 0x8010000000000008 bind 0x0 CoreFoundation _CFStringGetCString
__DATA_CONST __got 0x10035C048 0x8010000000000009 bind 0x0 CoreFoundation _CFStringGetLength
__DATA_CONST __got 0x10035C050 0x801000000000000A bind 0x0 CoreFoundation _CFStringGetMaximumSizeForEncoding
__DATA_CONST __got 0x10035C058 0x801000000000000B bind 0x0 CoreFoundation _CFTimeZoneCopyDefault
__DATA_CONST __got 0x10035C060 0x801000000000000C bind 0x0 CoreFoundation _CFTimeZoneGetName
```
closes #12173
Closes #12320
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12320 from sluongng:main 1416168f12
PiperOrigin-RevId: 526830008
2 years ago
Tomo Suzuki
d692223887
[WIP] Java BOM check with generated pom.xml files ( #12502 )
...
This check aims to address issues like https://github.com/protocolbuffers/protobuf/issues/12170 "Java 3.22.1: broken pom.xml".
Closes #12502
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12502 from suztomo:bom_check c69e2af597
PiperOrigin-RevId: 526776900
2 years ago
Adam Cozzette
07b1491895
Add better fallback behavior for retention stripping with invalid descriptors
...
PiperOrigin-RevId: 526758886
2 years ago
Mike Kruskal
f79e35c821
Fix declared dependencies for pkg-config ( #12518 )
...
Closes #12439
Closes #12518
PiperOrigin-RevId: 526689125
2 years ago
Jakob Buchgraber
0ecb729906
Implement 'bytes' accessors for UPB :)
...
Move the 'accessors_test.rs' to shared/ as both kernels now support the same accessor types.
PiperOrigin-RevId: 526591987
2 years ago
Protobuf Team Bot
37c8f8195b
Auto-generate files after cl/526587271
2 years ago
Jakob Buchgraber
e6b4f0e2d6
Delete the UPB kernel.
...
It's been made obsolete by cl/524903073.
PiperOrigin-RevId: 526587271
2 years ago
Protobuf Team Bot
bc127f2b56
Auto-generate files after cl/526184056
2 years ago
Protobuf Team Bot
469f0277b8
Add a field to ExtensionRangeOptions to mark an extension range is verified or not.
...
An extension range is either of verification state "UNVERIFIED" or "DECLARATION". If "DECLARATION", all extension fields of the range must be declared, or build error otherwise. The current default is "UNVERIFIED", but we will flip the default later.
Deprecate `is_repeated` in favor of `repeated`.
PiperOrigin-RevId: 526184056
2 years ago
Adam Cozzette
f71dc953c7
Add GitHub actions workflow for testing CMake build of examples directory
...
I confirmed that this test would catch the problem from #12450 .
PiperOrigin-RevId: 526165526
2 years ago
Mike Kruskal
5c59290022
Remove PROTOBUF_DEPRECATED in favor of [[deprecated]].
...
This appears to have been already broken for enum values on MSVC, and is completely unnecessary now that we required C++14.
PiperOrigin-RevId: 526163229
2 years ago
Kurt Alfred Kluever
295f1125ce
Adds `Timestamps.now()`.
...
PiperOrigin-RevId: 526160914
2 years ago
Protobuf Team Bot
a010e26505
Auto-generate files after cl/526143586
2 years ago
Protobuf Team Bot
908de8d74a
Automated rollback of commit 1e67de4ed5
.
...
PiperOrigin-RevId: 526143586
2 years ago
Protobuf Team Bot
81106b10dc
Automated rollback of commit 57d5ede3ec
.
...
PiperOrigin-RevId: 526130253
2 years ago
Protobuf Team Bot
d6ecec884c
Internal change.
...
PiperOrigin-RevId: 526046192
2 years ago
Sandy Zhang
cc7116ceeb
Remove unused proto3 field from UnknownFieldSetSchema.
...
This should reduce some unnecessary branching off of syntax for ManifestSchemaFactory for CODE_SIZE optimization for full using schemas.
PiperOrigin-RevId: 526039969
2 years ago
Tao Li
408afe1eb4
Fix typo for newlib macro ( #12521 )
...
Should use \_\_NEWLIB__
Closes #12521
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12521 from RiversideSC:main 3c793225db
PiperOrigin-RevId: 526020495
2 years ago
Luke Sandberg
983dac24c3
Change `PrintFreeFieldNumbers` to not assume that groups occupy the same field range as their containing messages.
...
PiperOrigin-RevId: 525876198
2 years ago
Protobuf Team Bot
699093915d
Auto-generate files after cl/525862155
2 years ago
Protobuf Team Bot
b2bd9dcb36
Refactor RepeatedMessageFieldGenerator code to use "_internal_$name$()" and "_internal_mutable_$name$()" rather than "$field$" to access fields in preparation for split repeated fields.
...
Motivation: we are planning to store split repeated fields in the split struct as pointers to repeated fields, which requires not accessing "$field$" directly.
We avoid using "_internal_$name$()" and "_internal_mutable_$name$()" in the implicit weak field case so that we can avoid linking in the message (as tested in implicit_weak_fields_test).
PiperOrigin-RevId: 525862155
2 years ago
Protobuf Team Bot
1123be7562
Auto-generate files after cl/525833833
2 years ago
Miguel Young de la Sota
725d7d9fc5
Partially convert message_field.cc to use Emit().
...
This CL does not change the formatting of any of the string templates;
it "only" reorganizes the file and updates the names of everything to match
other migrated files. Followup CLs will update the string templates.
PiperOrigin-RevId: 525833833
2 years ago
Jeff Gulbronson
a56e5ded7b
Reserve 1180 for Wire use_array ( #12491 )
...
release notes: no
Supports https://github.com/square/wire/pull/2433
Closes #12491
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12491 from JGulbronson:jgulbronson.claim-1180-for-wire f577336c0b
PiperOrigin-RevId: 525793344
2 years ago