Hong Shin
9a3c096b0c
Make ExtensionIdentifier's constructor private
...
PiperOrigin-RevId: 687065564
2 months ago
Sandy Zhang
e26cb4864d
Update protobuf's abseil dep to 20240722.0 in WORKSPACE protobuf_deps.bzl.
...
This was updated in MODULE.bzl already in cl/686670268
#test-continuous
PiperOrigin-RevId: 687045173
2 months ago
Protobuf Team Bot
7c0fe167b4
Automated rollback of commit bfaf36cbb1
.
...
PiperOrigin-RevId: 687045040
2 months ago
Sandy Zhang
fac0325484
Update remaining Python 3.8 upb macos tests to macos-13
...
macos-12 runner image is deprecated and is EOL 12/3/24 per https://github.com/actions/runner-images/issues/10721
Note that Python 3.8 is EOL and these tests should also be dropped / upgraded in
favor of 3.9 soon anyways.
#test-continuous
PiperOrigin-RevId: 687002433
2 months ago
Protobuf Team Bot
3fe0c75fc9
Internal change
...
PiperOrigin-RevId: 686989033
2 months ago
Mike Kruskal
955cb8154d
Internal changes
...
PiperOrigin-RevId: 686984077
2 months ago
Matteo
bd1806edc3
Fix generation of save-installed-headers.vcxproj regarding upb headers ( #18135 )
...
upb headers are not in `${protobuf_SOURCE_DIR}/src`, so the `string(REPLACE ...)` command fails and the `save-installed-headers.vcxproj` contains an invalid path regarding upb headers, causing a failure in compilation.
Closes #18135
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/18135 from Delcaran:main 28c40493e3
PiperOrigin-RevId: 686963169
2 months ago
Sandy Zhang
8eef2b3edc
Add validation that all steps have a name.
...
This also prevents the validate_yaml script from erroring when trying to log that a step is mishandling continuous-run / continuous-prefix
PiperOrigin-RevId: 686952188
2 months ago
Protobuf Team Bot
12eadfdfd9
Handle `PROTOBUF_ENABLE_DEBUG_LOGGING_MAY_LEAK_PII` being undefined
...
Check if `defined(PROTOBUF_ENABLE_DEBUG_LOGGING_MAY_LEAK_PII)` before trying to use it.
PiperOrigin-RevId: 686945589
2 months ago
Mike Kruskal
264c4b7b43
Fix abseil build after bump broke windows/cmake
...
#test-continuous
PiperOrigin-RevId: 686933460
2 months ago
Mark Hansen
fe6234122b
Automated rollback of commit 2b0a414573
.
...
PiperOrigin-RevId: 686927185
2 months ago
Mike Kruskal
54de2e5a6e
Delete unused submodules ( #18873 )
2 months ago
dependabot[bot]
8818c672f5
Bump actions/upload-artifact and actions/download-artifact from 3 to 4 ( #18329 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 3 to 4.
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 3 to 4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases ">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.0.0</h2>
<h2>What's Changed</h2>
<p>The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.</p>
<p>ℹ️ However, this is a major update that includes breaking changes. Artifacts created with versions v3 and below are not compatible with the v4 actions. Uploads and downloads <em>must</em> use the same major actions versions. There are also key differences from previous versions that may require updates to your workflows.</p>
<p>For more information, please see:</p>
<ol>
<li>The <a href="https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/ ">changelog</a> post.</li>
<li>The <a href="https://github.com/actions/upload-artifact/blob/main/README.md ">README</a>.</li>
<li>The <a href="https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md ">migration documentation</a>.</li>
<li>As well as the underlying npm package, <a href="https://github.com/actions/toolkit/tree/main/packages/artifact "><code>@actions/artifact</code></a> documentation.</li>
</ol>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/vmjoseph "><code>@vmjoseph</code></a> made their first contribution in <a href="https://redirect.github.com/actions/upload-artifact/pull/464 ">actions/upload-artifact#464</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v3...v4.0.0 ">https://github.com/actions/upload-artifact/compare/v3...v4.0.0 </a></p>
<h2>v3.2.1</h2>
<h2>What's Changed</h2>
<p>This fixes the <code>include-hidden-files</code> input introduced in <a href="https://github.com/actions/upload-artifact/releases/tag/v3.2.0 ">https://github.com/actions/upload-artifact/releases/tag/v3.2.0 </a></p>
<ul>
<li>Ensure hidden files input is used by <a href="https://github.com/joshmgross "><code>@joshmgross</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/609 ">actions/upload-artifact#609</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v3.2.0...v3.2.1 ">https://github.com/actions/upload-artifact/compare/v3.2.0...v3.2.1 </a></p>
<h2>v3.2.1-node20</h2>
<h2>What's Changed</h2>
<p>This fixes the <code>include-hidden-files</code> input introduced in <a href="https://github.com/actions/upload-artifact/releases/tag/v3.2.0-node20 ">https://github.com/actions/upload-artifact/releases/tag/v3.2.0-node20 </a></p>
<ul>
<li>Ensure hidden files input is used by <a href="https://github.com/joshmgross "><code>@joshmgross</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/608 ">actions/upload-artifact#608</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v3.2.0-node20...v3.2.1-node20 ">https://github.com/actions/upload-artifact/compare/v3.2.0-node20...v3.2.1-node20 </a></p>
<h2>v3.2.0</h2>
<h2>Notice: Breaking Changes ⚠️ </h2>
<p>We will no longer include hidden files and folders by default in the <code>upload-artifact</code> action of this version. This reduces the risk that credentials are accidentally uploaded into artifacts. Customers who need to continue to upload these files can use a new option, <code>include-hidden-files</code>, to continue to do so.</p>
<p>See <a href="https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/ ">"Notice of upcoming deprecations and breaking changes in GitHub Actions runners"</a> changelog and <a href="https://redirect.github.com/actions/upload-artifact/issues/602 ">this issue</a> for more details.</p>
<h2>What's Changed</h2>
<ul>
<li>V3 backport: Exclude hidden files by default by <a href="https://github.com/SrRyan "><code>@SrRyan</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/604 ">actions/upload-artifact#604</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="50769540e7
"><code>5076954</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/598 ">#598</a> from actions/joshmgross/exclude-hidden-files</li>
<li><a href="d52396ac5d
"><code>d52396a</code></a> Add a warning about enabling <code>include-hidden-files</code></li>
<li><a href="710f362075
"><code>710f362</code></a> Remove "merged" from <code>include-hidden-files</code> input description</li>
<li><a href="3b315f26f6
"><code>3b315f2</code></a> <code>npm run release</code> again 🙂 </li>
<li><a href="3be2180eb7
"><code>3be2180</code></a> Remove another trailing comma</li>
<li><a href="453e8d0a40
"><code>453e8d0</code></a> Update glob license</li>
<li><a href="0a398c1480
"><code>0a398c1</code></a> <code>npm run release</code></li>
<li><a href="a0c40cf602
"><code>a0c40cf</code></a> Update to latest <code>@actions/glob</code> and fix tests</li>
<li><a href="acb59e4776
"><code>acb59e4</code></a> <code>lint</code></li>
<li><a href="cb6558bb10
"><code>cb6558b</code></a> Exclude hidden files by default</li>
<li>Additional commits viewable in <a href="https://github.com/actions/upload-artifact/compare/v3...v4 ">compare view</a></li>
</ul>
</details>
<br />
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=3&new-version=4 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Closes #18329
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/18329 from protocolbuffers:dependabot/github_actions/actions/upload-artifact-4 57e94bf354
PiperOrigin-RevId: 686898193
2 months ago
Hong Shin
d80ac3a7e6
hpb: expunge MessageName in favor of upb::generator::CApiMessageType
...
PiperOrigin-RevId: 686896344
2 months ago
Protobuf Team Bot
b956147ce1
Use rules_cc everywhere in protobuf
...
Nice to have in the future when rules_cc are in the repository, but not necessary ATM.
PiperOrigin-RevId: 686760344
2 months ago
Protobuf Team Bot
50e3b1b66c
Auto-generate files after cl/686703004
2 months ago
Protobuf Team Bot
e358a4025e
Convert proto toolchain string to Label
...
Without it the still slightly weird setup of Bazel unit tests causes problems.
PiperOrigin-RevId: 686745551
2 months ago
Protobuf Team Bot
1f7f08d21d
Internal change
...
PiperOrigin-RevId: 686703004
2 months ago
Protobuf Team Bot
5aca3b7352
Auto-generate files after cl/686703004
2 months ago
Protobuf Team Bot
5216029ae8
Internal change
...
PiperOrigin-RevId: 686703004
2 months ago
Protobuf Team Bot
35a7bf2845
Auto-generate files after cl/686703004
2 months ago
Protobuf Team Bot
5856d33473
Internal change
...
PiperOrigin-RevId: 686703004
2 months ago
Protobuf Team Bot
cbb49f03bf
Auto-generate files after cl/686680363
2 months ago
Jie Luo
bfaf36cbb1
Add "PythonMessageMutator GetClearedMutableMessage(PyObject *);" in proto_api which works with cpp extension, upb and pure python.
...
PiperOrigin-RevId: 686684556
2 months ago
Protobuf Team Bot
54f38ba7f8
Internal change
...
PiperOrigin-RevId: 686680363
2 months ago
Protobuf Team Bot
799cb0a1c4
Auto-generate files after cl/686676344
2 months ago
Protobuf Team Bot
a4a781db1b
Internal change
...
PiperOrigin-RevId: 686676344
2 months ago
Protobuf Team Bot
d6d3f85f0e
Auto-generate files after cl/686670268
2 months ago
Tony Liao
571ff6f2b2
Uncouple Java hasbits from C++ hasbits.
...
There is really no reason for the Java compiler code to call into the internal
C++ implementation of HasHasbit. In the future, the two implementations may
evolve separately and this decoupling can make it easier.
PiperOrigin-RevId: 686672397
2 months ago
Tony Liao
c75095b6c6
Bump abseil dependency version from 20230802.1 to 20240722.0.
...
See abseil release notes:
https://github.com/abseil/abseil-cpp/releases/tag/20240722.0
This is necesary pre-work to enable C++17 builds in preparation of baseline C++
upgrade from C++14 to C++17. C++14 support is scheduled to reach EOL on
2024-12-15:
https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md
Interestingly enough, the older Abseil version 20230802.1 is actually OK for
building on macOS with C++17. However, we depend on GoogleTest, and they
transitively depend on Abseil version 20240116.2, which caused Bazel to
implicitly change the Abseil dependency to most recent specified version of
20240116.2:
https://github.com/google/googletest/blob/main/MODULE.bazel
Current builds with C++17 and Abseil version 20240116.2 on older macos versions
that didn't support `std::filesystem::path` would give the following error:
> error: 'path' is unavailable: introduced in macOS 10.15.
With this version upgrade, we pull in an Abseil patch that fixes this issue on
macOS:
65a55c2ba8
PiperOrigin-RevId: 686670268
2 months ago
Protobuf Team Bot
09af1d8f43
Auto-generate files after cl/686647297
2 months ago
Mike Kruskal
3f06ca4306
Breaking change: Remove CMake submodule support in favor of fetched or installed dependencies.
...
This flips the default behavior to "fetch", downloading local copies of required dependencies. This can be disabled by setting `-Dprotobuf_FETCH_DEPENDENCIES=OFF`, in which case we will look for a local installation using find_package. Setting `-Dprotobuf_ABSL_PROVIDER=package` will continue to have the same behavior as before.
See https://protobuf.dev/news/2024-10-02/#replace-cmake-submods for more details.
#test-continuous
PiperOrigin-RevId: 686649864
2 months ago
Protobuf Team Bot
66f80bb8a1
Internal change
...
PiperOrigin-RevId: 686647297
2 months ago
Protobuf Team Bot
6ded0291e3
Auto-generate files after PR #18238
2 months ago
Zoey Greer
fbe6168a02
Address warning regarding incorrectly-terminated heredoc in `src/google/protobuf/compiler/test_plugin_injection.bzl` ( #18238 )
...
Closes #18238
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/18238 from tempoz:tempoz-fix-heredoc 87644ab5e9
PiperOrigin-RevId: 686625159
2 months ago
Protobuf Team Bot
90c4487d27
Auto-generate files after cl/686608991
2 months ago
Sandy Zhang
92bed48179
Remove obsolete references to 21.x and 22.x branches that used to use Kokoro
...
PiperOrigin-RevId: 686608991
2 months ago
Protobuf Team Bot
463ca91ecd
Auto-generate files after cl/686600589
2 months ago
Protobuf Team Bot
ecec105916
Add `DynamicCastMessage` overloads for `std::shared_ptr` to replace uses of
...
`std::dynamic_pointer_cast`.
PiperOrigin-RevId: 686603280
2 months ago
Protobuf Team Bot
9e200bebb2
Internal change
...
PiperOrigin-RevId: 686600589
2 months ago
Protobuf Team Bot
62592a014c
Auto-generate files after cl/686588307
2 months ago
Mike Kruskal
2ea63b0b84
Automated rollback of commit d99d1a60c0
.
...
PiperOrigin-RevId: 686588307
2 months ago
Protobuf Team Bot
14b1488981
Auto-generate files after cl/686572636
2 months ago
Protobuf Team Bot
a0eb24061f
Replace use of C++17 with disabling a warning
...
PiperOrigin-RevId: 686572636
2 months ago
Protobuf Team Bot
8259925cc4
Auto-generate files after cl/686552884
2 months ago
Protobuf Team Bot
b1d362033d
Internal change
...
PiperOrigin-RevId: 686552884
2 months ago
Protobuf Team Bot
008046df6e
Auto-generate files after cl/686533265
2 months ago
Protobuf Team Bot
dfaec17efb
Internal change
...
PiperOrigin-RevId: 686533265
2 months ago
Protobuf Team Bot
08f9c603a2
Auto-generate files after cl/686518474
2 months ago
Protobuf Team Bot
6a4ed21083
Internal change
...
PiperOrigin-RevId: 686518474
2 months ago