Jason Lunn
42f8b7782e
Add support for extensions in CRuby, JRuby, and FFI Ruby ( #14703 )
...
Follow up to #14594 , which added support for custom options, this PR implements extensions support, which should fully resolve #1198 .
Closes #14703
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14703 from protocolbuffers:add-support-for-extensions-in-ruby 601aca4121
PiperOrigin-RevId: 582460674
1 year ago
Mike Kruskal
ab2451f6c2
Don't rely on .bazelrc for signaling sanitizer builds
...
PiperOrigin-RevId: 582436549
1 year ago
Mike Kruskal
c3bae392a6
Allow open enums from editions files in proto3.
...
The old check assumed all non-proto3 enums were closed, which is no longer true.
PiperOrigin-RevId: 582411371
1 year ago
Hong Shin
4773327787
cleanup whitespace in message.cc
...
PiperOrigin-RevId: 582344807
1 year ago
Hong Shin
885fd6f007
Migrate cpp.rs to googletest-rust
...
PiperOrigin-RevId: 582335925
1 year ago
Protobuf Team Bot
3cb1bf3338
Auto-generate files after cl/582324372
1 year ago
Protobuf Team Bot
8fe757e961
Internal changes.
...
PiperOrigin-RevId: 582324372
1 year ago
Protobuf Team Bot
7c68721b23
Auto-generate files after cl/582150596
1 year ago
Eric Salo
8849deab91
upb: implement some upb_FieldType and upb_CType functions
...
PiperOrigin-RevId: 582150596
1 year ago
Mike Kruskal
b01bd1ba17
Mark the python generator for editions support.
...
Editions has been implemented in all three implementations already, and this simply enables it.
PiperOrigin-RevId: 582139104
1 year ago
Protobuf Team Bot
fac9fdc283
Auto-generate files after cl/582099455
1 year ago
Protobuf Team Bot
d2733119a4
Use Emit instead of format()
...
PiperOrigin-RevId: 582099455
1 year ago
Protobuf Team Bot
32af7d211b
Auto-generate files after cl/581980280
1 year ago
Hong Shin
b3cfff3478
Introduce preliminary submessage_mut semantics
...
We've had access to views for submessages for a while:
If you hit some_message.submsg().some_int(), you'll get a view for that int.
Until now, there hasn't been a way to get some_message.submsg_mut(), so we introduce the mutational pathway here.
We haven't added fully-functioning mutation, but this is a step towards that goal.
subview was inaccurate, so I've refactored and renamed: { accessor_fns_for_views, accessor_fns_for_muts }.
PiperOrigin-RevId: 581984371
1 year ago
Protobuf Team Bot
a74398fbe6
Change array insertions to use `_upb_Array_ResizeUninitialized` instead of `upb_Array_Resize`.
...
`upb_Array_Append` and `upb_Array_Insert` will resize the array and then immediately overwrite the new values. These methods currently use `upb_Array_Resize` to do the array resizing, however this does extra unnecessary work by initializing those new values. This changes these insertion methods to use `_upb_Array_ResizeUninitialized` instead, which will perform the resize without the extra unnecessary initialization.
PiperOrigin-RevId: 581980280
1 year ago
Protobuf Team Bot
2a2ae9b176
Remove unused ext_scope variable from ExtensionIdentBase.
...
PiperOrigin-RevId: 581979197
1 year ago
Protobuf Team Bot
cc140a1ed4
Automated rollback of commit b1370701fd
.
...
PiperOrigin-RevId: 581957987
1 year ago
Protobuf Team Bot
81607b267c
Fix FieldSet to not load lazy fields when the fields map is cloned. In particular, if MessageSet.Builder has build() called on it, but is then later further modified, we don't need to pre-load all lazy fields during this later modification.
...
PiperOrigin-RevId: 581941605
1 year ago
dependabot[bot]
92619cdd43
Bump ossf/scorecard-action from 2.1.2 to 2.3.1 ( #14554 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.1.2 to 2.3.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ossf/scorecard-action/releases ">ossf/scorecard-action's releases</a>.</em></p>
<blockquote>
<h2>v2.3.1</h2>
<h2>What's Changed</h2>
<ul>
<li>🌱 Bump github.com/ossf/scorecard/v4 from v4.13.0 to v4.13.1 by <a href="https://github.com/spencerschrock "><code>@spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1282 ">ossf/scorecard-action#1282</a>
<ul>
<li>Adds additional Fuzzing detection and fixes a SAST bug related to detecting CodeQL. For a full changelist of what this includes, see the <a href="https://github.com/ossf/scorecard/releases/tag/v4.13.1 ">v4.13.1</a> release notes</li>
</ul>
</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/ossf/scorecard-action/compare/v2.3.0...v2.3.1 ">https://github.com/ossf/scorecard-action/compare/v2.3.0...v2.3.1 </a></p>
<h2>v2.3.0</h2>
<h2>What's Changed</h2>
<ul>
<li>🌱 Bump github.com/ossf/scorecard/v4 from v4.11.0 to v4.13.0 by <a href="https://github.com/spencerschrock "><code>@spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1270 ">ossf/scorecard-action#1270</a>
<ul>
<li>For a full changelist of what this includes, see the <a href="https://github.com/ossf/scorecard/releases/tag/v4.12.0 ">v4.12.0</a> and <a href="https://github.com/ossf/scorecard/releases/tag/v4.13.0 ">v4.13.0</a> release notes</li>
</ul>
</li>
<li>✨ Send rekor tlog index to webapp when publishing results by <a href="https://github.com/spencerschrock "><code>@spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1169 ">ossf/scorecard-action#1169</a></li>
<li>🐛 Prevent url clipping for GHES instances by <a href="https://github.com/rajbos "><code>@rajbos</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1225 ">ossf/scorecard-action#1225</a></li>
</ul>
<h3>Documentation</h3>
<ul>
<li>📖 Update access rights needed to see the results in code scanning by <a href="https://github.com/rajbos "><code>@rajbos</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1229 ">ossf/scorecard-action#1229</a></li>
<li>📖 Add package comments. by <a href="https://github.com/spencerschrock "><code>@spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1221 ">ossf/scorecard-action#1221</a></li>
<li>📖 Add SECURITY.md file by <a href="https://github.com/david-a-wheeler "><code>@david-a-wheeler</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1250 ">ossf/scorecard-action#1250</a></li>
<li>📖 Fix typo in token input docs by <a href="https://github.com/aabouzaid "><code>@aabouzaid</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1258 ">ossf/scorecard-action#1258</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/david-a-wheeler "><code>@david-a-wheeler</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1250 ">ossf/scorecard-action#1250</a></li>
<li><a href="https://github.com/aabouzaid "><code>@aabouzaid</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1258 ">ossf/scorecard-action#1258</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/ossf/scorecard-action/compare/v2.2.0...v2.3.0 ">https://github.com/ossf/scorecard-action/compare/v2.2.0...v2.3.0 </a></p>
<h2>v2.2.0</h2>
<h2>What's Changed</h2>
<ul>
<li>🌱 Bump github.com/ossf/scorecard/v4 from v4.10.5 to v4.11.0 by <a href="https://github.com/spencerschrock "><code>@spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1192 ">ossf/scorecard-action#1192</a></li>
</ul>
<h2>Scorecard Result Viewer</h2>
<p>Thanks to contributions from <a href="https://github.com/cynthia-sg "><code>@cynthia-sg</code></a> and <a href="https://github.com/tegioz "><code>@tegioz</code></a> at <a href="https://github.com/cncf/clomonitor ">CLOMonitor</a>, there is a new Scorecard Result visualization page at <code>https://securityscorecards.dev/viewer/?uri=<project-url> ;</code>.</p>
<ul>
<li><a href="https://redirect.github.com/ossf/scorecard-webapp/pull/406 ">ossf/scorecard-webapp#406</a></li>
<li><a href="https://redirect.github.com/ossf/scorecard-webapp/pull/422 ">ossf/scorecard-webapp#422</a></li>
</ul>
<p>As an example, you can see our own score visualized <a href="https://securityscorecards.dev/viewer/?uri=github.com/ossf/scorecard ">here</a>
Checkout our <a href="08b4669551/README.md (scorecard-badge)
">README</a> to learn how to link your README badge to the new visualization page.</p>
<h2>Publishing Results</h2>
<p>This release contains two fixes which will improve the user experience when <code>publish_results</code> is <code>true</code></p>
<ul>
<li>Runs that fail our <a href="08b4669551/README.md (workflow-restrictions)
">workflow restrictions</a> will fail with a 400 response indicating the problem, instead of a vague 500 status. (<a href="https://redirect.github.com/ossf/scorecard-action/pull/1156 ">ossf/scorecard-action#1156</a>, resolved <a href="https://redirect.github.com/ossf/scorecard-action/issues/1150 ">ossf/scorecard-action#1150</a>)</li>
<li>Scorecard action will retry when signing results and submitting them to our web API. This should help with flakiness from connection failures. (<a href="https://redirect.github.com/ossf/scorecard-action/pull/1191 ">ossf/scorecard-action#1191</a>)</li>
</ul>
<h2>Docs</h2>
<ul>
<li>📖 Update README to accept fine-grained tokens by <a href="https://github.com/pnacht "><code>@pnacht</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1175 ">ossf/scorecard-action#1175</a></li>
<li>📖 Update installation instructions to match current GitHub UI by <a href="https://github.com/joycebrum "><code>@joycebrum</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1153 ">ossf/scorecard-action#1153</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="0864cf1902
"><code>0864cf1</code></a> 🌱 Bump docker tag to for v2.3.1 release (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1284 ">#1284</a>)</li>
<li><a href="72df3bff66
"><code>72df3bf</code></a> 🌱 Bump github.com/ossf/scorecard/v4 from v4.13.0 to v4.13.1 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1282 ">#1282</a>)</li>
<li><a href="0ea411f94a
"><code>0ea411f</code></a> 🌱 Bump the docker-images group with 1 update (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1281 ">#1281</a>)</li>
<li><a href="dbfd042453
"><code>dbfd042</code></a> 🌱 Bump the github-actions group with 1 update (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1280 ">#1280</a>)</li>
<li><a href="2fa1e2fa15
"><code>2fa1e2f</code></a> 🌱 Bump golang.org/x/net from 0.16.0 to 0.17.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1278 ">#1278</a>)</li>
<li><a href="652ddd06c8
"><code>652ddd0</code></a> 🌱 Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1277 ">#1277</a>)</li>
<li><a href="28d0c92b8b
"><code>28d0c92</code></a> 🌱 Group Dependabot updates for GitHub Actions and Dockerfiles (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1276 ">#1276</a>)</li>
<li><a href="cb50491a46
"><code>cb50491</code></a> 🌱 Bump distroless/base from <code>a35b652</code> to <code>b31a6e0</code> (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1275 ">#1275</a>)</li>
<li><a href="87157ac77d
"><code>87157ac</code></a> 🌱 Bump github/codeql-action from 2.21.9 to 2.22.1 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1274 ">#1274</a>)</li>
<li><a href="7c1648b23e
"><code>7c1648b</code></a> 🌱 Bump step-security/harden-runner from 2.5.1 to 2.6.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1273 ">#1273</a>)</li>
<li>Additional commits viewable in <a href="e38b1902ae...0864cf1902
">compare view</a></li>
</ul>
</details>
<br />
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ossf/scorecard-action&package-manager=github_actions&previous-version=2.1.2&new-version=2.3.1 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Closes #14554
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14554 from protocolbuffers:dependabot/github_actions/ossf/scorecard-action-2.3.1 543f85ba25
PiperOrigin-RevId: 581438189
1 year ago
Protobuf Team Bot
7c1ec5a801
Auto-generate files after cl/581408568
1 year ago
Mike Kruskal
8699fde0a9
Enable upb editions conformance testing.
...
This also cleans up some pre-existing bugs and adds a Fasttable/ASAN build.
PiperOrigin-RevId: 581408568
1 year ago
Protobuf Team Bot
c6b149cbf9
Auto-generate files after cl/581384108
1 year ago
Mike Kruskal
c23d5333c3
Expose editions in Python/upb.
...
This also fixes a few minor bugs in the editions implementation that were caught in python/conformance tests, and adds a new SetFeatureSetDefaults API to the def pool for consistency with C++ and other python implementations.
PiperOrigin-RevId: 581384108
1 year ago
Mike Kruskal
e8377f12e1
Expose editions in Python/C++.
...
This was already fully implemented in C++, but we need to expose features methods to the Python runtime to fully enable it. This also enables conformance and unit-testing for C++.
PiperOrigin-RevId: 581364355
1 year ago
Protobuf Team Bot
efeee51380
Auto-generate files after cl/581311618
1 year ago
Protobuf Team Bot
e2c8113c92
Use Emit instead of format().
...
PiperOrigin-RevId: 581311618
1 year ago
Protobuf Team Bot
ecc2bac638
Automated rollback of commit 2641517150
.
...
PiperOrigin-RevId: 581037871
1 year ago
Protobuf Team Bot
8522fbbacd
Use PROTOBUF poison/unpoison macros instead of ASAN versions to avoid ifdef guards.
...
PiperOrigin-RevId: 581037290
1 year ago
Protobuf Team Bot
2641517150
Add more direct support for MessageSet wire in the table-driven parser:
...
- Make the table for these types be usable. The only fast parse function takes care of the whole parsing loop. Enable direct-to-table parsing for MessageSet submessages.
- Add fast functions for the parent messages to skip `_InternalParse` and `ParseLoop`. The fast function directly reaches in the ExtensionSet.
PiperOrigin-RevId: 580998394
1 year ago
Cong Liu
1511b7dc1e
Internal change.
...
PiperOrigin-RevId: 580990149
1 year ago
Protobuf Team Bot
1c8ee7c44e
Move `TopologicalSortMessagesInFile` to helpers.cc
...
We would use this function in helpers.cc for identifying the proto fields to inline. Better to have it there.
PiperOrigin-RevId: 580982766
1 year ago
Protobuf Team Bot
b1370701fd
Automated rollback of commit 8c2416311f
.
...
PiperOrigin-RevId: 580960903
1 year ago
Hong Shin
e018e99437
Complete migration of accessors_proto3_test.rs to googletest-rust
...
PiperOrigin-RevId: 580946544
1 year ago
Protobuf Team Bot
a1e8659920
Auto-generate files after cl/580944277
1 year ago
Protobuf Team Bot
f7b2fa4c4e
Add missing version comments to C++ generated source files.
...
PiperOrigin-RevId: 580944277
1 year ago
Hong Shin
c482a8a583
update protos_generator to shortened license
...
PiperOrigin-RevId: 580934188
1 year ago
Adam Cozzette
d30e326ca1
Remove obsolete `github` directory from utf8_range
...
PiperOrigin-RevId: 580926097
1 year ago
Jason Lunn
ae1f2b7e1b
Add support for options in CRuby, JRuby and FFI ( #14594 )
...
Rewrrte and extension of #12828 , with additional work for JRuby. Partially fixes #1198 by adding support for custom options. Handling of extensions will be handled in a follow up.
Also includes these unrelated fixes:
* Removes code echo between `google/protobuf/repeated_field.rb` and `google/protobuf/ffi/repeated_field.rb` by `require`'ing the former in the latter.
* Adds missing calles to `testFrozen()` from methods of `RepeatedField` under JRuby that mutate.
* Various typos in comments.
Closes #14594
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14594 from protocolbuffers:add-support-for-options-in-ruby 16cc9e35b8
PiperOrigin-RevId: 580848874
1 year ago
Protobuf Team Bot
92f6153279
Auto-generate files after cl/580731298
1 year ago
Protobuf Team Bot
cec3a81d3a
Remove `-main` as a language version suffix in a separate version file than version numbers.
...
PiperOrigin-RevId: 580731298
1 year ago
Protobuf Team Bot
e471b00749
Auto-generate files after cl/580726494
1 year ago
Protobuf Team Bot
8c2416311f
Compare explicit zeroes from prototext in partially.
...
Right now, zeros are not allowed in explicit prototext comparison, frequently leading to very awkward manual checking. This tracks such explicit zeros, and ensures they remain 0.
PiperOrigin-RevId: 580729313
1 year ago
Cong Liu
5987c896fd
Internal change.
...
PiperOrigin-RevId: 580726494
1 year ago
Protobuf Team Bot
6105bb19ee
Auto-generate files after cl/580682733
1 year ago
Adam Cozzette
5ca84008fc
Move utf8_range into the protobuf repo
...
This makes third_party/utf8_range no longer a Git subtree, but instead the
permanent location and source of truth for utf8_range. It is also now
incorporated into the @com_google_protobuf Bazel repo. Utf8_range still has its
own separate CMake build for now, though.
PiperOrigin-RevId: 580682733
1 year ago
Protobuf Team Bot
e6f8b9d102
message_lite.h: Use PROTOBUF_EXPORT_TEMPLATE_DECLARE with extern template
...
Export extern templates in message_lite.h to avoid missing symbols when
linking protobuf-lite.so.
PiperOrigin-RevId: 580556084
1 year ago
Adam Cozzette
24fef03259
Add support and partial CI coverage for Python 3.12
...
There's a test run in test_python.yml that is non-trivial to get working with
Python 3.12 due to some refactoring of our Docker images that would be needed.
But this change updates everything else to add coverage for Python 3.12.
The main changes necessary to get the builds working were to upgrade some Pip
packages via requirements.txt, including in a patch to `rules_fuzzing` that I
plan to upstream soon. I also had to take an explicit dependency on
`setuptools`.
I removed tox.ini, since it was outdated and we have not been actively
maintaining it.
PiperOrigin-RevId: 580548224
1 year ago
Adam Cozzette
2bcfbd8aa0
Add Bazel `--incompatible` flags to our bazelrc for CI
...
I was thinking it would be a good idea to proactively opt into all upcoming
breaking change flag flips in Bazel, so this change does that by adding all the
relevant flags to the common bazelrc file we use in our CI jobs. There are
several that we cannot enable yet without breaking something, so I left those
commented out for now.
PiperOrigin-RevId: 580538273
1 year ago
Protobuf Team Bot
5c7b41a769
Auto-generate files after cl/580530262
1 year ago
Adam Cozzette
01292502fa
Squashed 'third_party/utf8_range/' changes from d863bc33e..0e378bdb2 ( #14679 )
...
0e378bdb2 Add missing `<cstdint>` include to utf8_validity_fuzzer.cc
git-subtree-dir: third_party/utf8_range
git-subtree-split: 0e378bdb224cc8d4653b0db963b474839c2bb43c
1 year ago