protobuf

Commit Graph

Author	SHA1	Message	Date
Tony Liao	162a740670	Reduced nesting in GenerateByteSize: slight readability improvements in generated code. GenerateByteSize itself remains deeply nested, but by factoring out one part of the loop, at least we make the part that generates UpdateByteSize a bit more readable. Making the callsite of MayEmitIfNonDefaultCheck less nested actually resulted in slight readability improvements also in the generated code, namely of the form: @@ -10563,8 +10559,7 @@ PROTOBUF_NOINLINE void OneStringEdition: { // string data = 1; - cached_has_bits = - this_._impl_._has_bits_[0]; + cached_has_bits = this_._impl_._has_bits_[0]; if (cached_has_bits & 0x00000001u) { total_size += 1 + ::proto2::internal::WireFormatLite::StringSize( this_._internal_data()); These readability improvements should be kept IMO -- they make the generated protobuf C++ code slightly easier to read. PiperOrigin-RevId: 655180880	4 months ago
Protobuf Team Bot	c97a042116	In the custom vtable mode invert how the static/non-static overloads versions work for ByteSizeLong and _InternalSerialize. That way the public entry point and the function pointer both end up being the same. Currently, the static function is a separate function than the one called externally, forcing two functions to exist. It has no effect in normal mode. PiperOrigin-RevId: 651119789	5 months ago
Protobuf Team Bot	a9e0480768	Use Emit for ByteSizeLong PiperOrigin-RevId: 627204923	7 months ago
Mike Kruskal	ea81024ddf	Refactor editions infrastructure to a top-level directory. The only public target here is the edition defaults helper macro, which can be used by external runtimes and plugins. None of this code is C++-specific though, and should be organized higher up. Appropriate aliases are also placed at the top level for public targets PiperOrigin-RevId: 625392504	8 months ago
Ilya Tokar	4b31b781f6	Be less aggressive about prefetching in bytesizelong PiperOrigin-RevId: 609454594	9 months ago
Ilya Tokar	948ca2e0f3	Add software prefetch to ByteSizeLong Mkaes ByteSizeLong faster: BM_ByteSizeLong 15.7µs ± 4% 14.9µs ± 6% -5.17% (p=0.000 n=20+20) PiperOrigin-RevId: 605067418	10 months ago
Cong Liu	5987c896fd	Internal change. PiperOrigin-RevId: 580726494	1 year ago
Mike Kruskal	58722b10c9	Internal change PiperOrigin-RevId: 572987133	1 year ago
Mike Kruskal	e9fc181ae9	Migrate C++ utf8 validation to a global feature. PiperOrigin-RevId: 568686594	1 year ago
Mike Kruskal	1f9583069f	Editions: Migrate string_field_validation to a C++ feature Every language has very different handling of utf8 validation. Any with proto2/proto3 differences will receive language-specific features for edition zero to better model these subtle differences. PiperOrigin-RevId: 557258923	1 year ago
Sandy Zhang	beec240675	Update compare_codegen_test to be paramaterizable per language. PiperOrigin-RevId: 557211627	1 year ago
Mike Kruskal	4f9e41767a	Release prototype of Protobuf Editions. This represents the future direction of protobuf, replacing proto2/proto3 syntax with editions. These will enable more incremental evolution of protobuf APIs through features, which are individual behaviors (such as whether field presence is explicit or implicit). For more details see https://protobuf.dev/editions/overview/. This PR contains a working implementation of editions for the protoc frontend and C++ code generation, along with various infrastructure improvements to support it. It gives early access for anyone who wants to a preview of editions, but has no effect on proto2/proto3 syntax. It is flag-guarded behind the `--experimental_editions` flag, and is an experimental feature with no guarantees. PiperOrigin-RevId: 544805690	1 year ago

4 Commits (94c50325ca9039b4dcff5376f9ae8601bf9205d7)