protobuf

Commit Graph

Author	SHA1	Message	Date
Joshua Haberman	c9f9668234	symtab: use longjmp() for errors and avoid intermediate table. We used to use a separate "add table" during the upb_symtab_addfile() operation to make it easier to back out the file if it contained errors. But this created unnecessary work of re-adding the same symbols to the main symtab once everything was validated. Instead we directly add symbols to the main symbols table. If there is an error in validation, we remove precisely the set of symbols that were already added. This also requires using a separate arena for each file. We can fuse it with the symtab's main arena if the operation is successful. LoadDescriptor_Upb 61.2µs ± 4% 53.5µs ± 1% -12.50% (p=0.000 n=12+12) LoadAdsDescriptor_Upb 4.43ms ± 1% 3.06ms ± 0% -31.00% (p=0.000 n=12+12) LoadDescriptor_Proto2 257µs ± 0% 259µs ± 0% +1.00% (p=0.000 n=12+12) LoadAdsDescriptor_Proto2 13.9ms ± 1% 13.9ms ± 1% ~ (p=0.128 n=12+12)	4 years ago
Joshua Haberman	4d9a8cd67b	Merge branch 'master' into symtab-longjmp	4 years ago
Joshua Haberman	6322d1d72d	Merge pull request #329 from haberman/benchmark-ads-descriptor Added benchmark for loading ads descriptor.	4 years ago
Joshua Haberman	5ec1d39224	Avoid building .pb.cc for ads protos, as C++ takes forever to compile.	4 years ago
Joshua Haberman	43c207ea7e	Added CMake dummy rule.	4 years ago
Joshua Haberman	c3b5637646	Added benchmark for loading ads descriptor. Generally this seems to track the speed of loading descriptor.proto. ---------------------------------------------------------------------------------------------------- Benchmark Time CPU Iterations ---------------------------------------------------------------------------------------------------- BM_LoadDescriptor_Upb 59091 ns 59086 ns 11747 121.182MB/s BM_LoadAdsDescriptor_Upb 4218587 ns 4218582 ns 166 120.544MB/s BM_LoadDescriptor_Proto2 241083 ns 241049 ns 2903 29.7043MB/s BM_LoadAdsDescriptor_Proto2 13442631 ns 13442099 ns 52 34.8975MB/s	4 years ago
Joshua Haberman	acd72c6d3f	WIP.	4 years ago
Joshua Haberman	6ae3b66cd2	Merge pull request #328 from haberman/optdefload Optimized the loading of descriptors	4 years ago
Joshua Haberman	8113ebd6c7	Added explanatory comment about integer constants.	4 years ago
Joshua Haberman	f2d826b9f3	Got rid of floating-point division in table init. Ideally we would get rid of all floating-point operations in table.c, but that's a job for another day.	4 years ago
Joshua Haberman	723cd8ffc1	Added wyhash code and LICENSE, and removed temporary benchmark.	4 years ago
Joshua Haberman	15e20636c3	Merge branch 'master' into optdefload	4 years ago
Joshua Haberman	154f2c25f4	Added UTF-8 validation for proto3 string fields.	4 years ago
Joshua Haberman	e8f9eac68c	Added #defines UPB_ENABLE_FASTTABLE and UPB_TRY_ENABLE_FASTTABLE. These control whether fasttable decoding is on.	4 years ago
Joshua Haberman	994cf07cf3	Merge pull request #327 from benjaminp/modern-linking Migrate to modern Starlark linking api.	4 years ago
Benjamin Peterson	b5bd5807a7	Migrate to modern Starlark linking api. See https://github.com/bazelbuild/bazel/issues/10860.	4 years ago
Joshua Haberman	dc64613607	Merge branch 'fastest-table' into fast-table	4 years ago
Joshua Haberman	e86541ac1d	Fixed the build after the merge.	4 years ago
Joshua Haberman	1cd0cb17d3	Merge branch 'master' into fastest-table	4 years ago
Joshua Haberman	901744a97e	Merge pull request #326 from haberman/c99 Drop C89/C90 support and MSVC prior to Visual Studio 2015.	4 years ago
Joshua Haberman	a0d16e7073	Added a few missing copts, and made some functions proper prototypes.	4 years ago
Joshua Haberman	558315a1c3	Added COPTS to :port.	4 years ago
Joshua Haberman	7e5bd65098	Plumbed copts (including the crucial -std=c99) to upb_proto_library() aspect.	4 years ago
Joshua Haberman	8f3ee80d46	Drop C89/C90 support and MSVC prior to Visual Studio 2015. upb previously attempted to support C89 and pre-2015 versions of Visual Studio. This was to support older compilers with limited C99 support (particularly MSVC). But as of last August, even gRPC has dropped support for MSVC prior to 2015 `c87276d058` Therefore it seems safe for upb to no longer attempt C89 support (we were already not truly C89 compliant, with our use of "bool"). We now explicitly require C99 or greater and MSVC 2015 or greater. This cleaned up port_def.inc a fair bit. I took the chance to also remove some obsolete macros.	4 years ago
Joshua Haberman	a274ad786a	Plumbed copts (including the crucial -std=c99) to upb_proto_library() aspect.	4 years ago
Joshua Haberman	2c8bb6dd9d	Specify C99 explicitly until/unless we stop using bool.	4 years ago
Joshua Haberman	efd576b698	Added -std=gnu99 for fastdecode and ran Buildifier.	4 years ago
Joshua Haberman	b928696942	A few more fixes, and test fastdecode under Kokoro.	4 years ago
Joshua Haberman	55f3569cd2	A few minor fixes and more assertions.	4 years ago
Joshua Haberman	8b38e8f214	Merge branch 'fastest-table' into fast-table	4 years ago
Joshua Haberman	46eb82467a	Added comment to decode_fast.h.	4 years ago
Joshua Haberman	bd9f8f580d	Fixed a few bugs with the fast decoder. 1. For long tags we were putting table entries in the wrong slot. 2. For repeated strings, when the buffer flipped to no longer alias we were failing to notice and kept aliasing anyway.	4 years ago
Joshua Haberman	3eba47914b	Allocate hasbits and table slots in "hotness" order. Without a profile, we assume that fields with smaller numbers are hotter.	4 years ago
Joshua Haberman	021db6fcd5	Allow larger tags into the table if they are unique mod 31. Also fixed a bug with fixed packed in decode_fast.c.	4 years ago
Joshua Haberman	86d9908c55	Fastdecode support for packed fields. This is not very optimized yet. There is a lot of room to optimize it further.	4 years ago
Joshua Haberman	e3e797b680	Added fasttable support for oneofs.	4 years ago
Joshua Haberman	7ffa9c181a	Fixed some small bugs and performance problems in string copying. Before this CL, with alias=false: ------------------------------------------------------------------------------ Benchmark Time CPU Iterations ------------------------------------------------------------------------------ BM_Parse_Upb_FileDesc_WithInitialBlock 3715 ns 3715 ns 188916 1.88206GB/s Performance counter stats for 'bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb_FileDesc_WithInitialBlock': 1,122.92 msec task-clock # 0.979 CPUs utilized 3 context-switches # 0.003 K/sec 0 cpu-migrations # 0.000 K/sec 196 page-faults # 0.175 K/sec 4,144,746,717 cycles # 3.691 GHz 15,351,966,804 instructions # 3.70 insn per cycle 2,590,281,905 branches # 2306.728 M/sec 2,996,157 branch-misses # 0.12% of all branches 1.146615328 seconds time elapsed 1.115578000 seconds user 0.008025000 seconds sys After this CL: ------------------------------------------------------------------------------ Benchmark Time CPU Iterations ------------------------------------------------------------------------------ BM_Parse_Upb_FileDesc_WithInitialBlock 3554 ns 3554 ns 197527 1.9674GB/s Performance counter stats for 'bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb_FileDesc_WithInitialBlock': 1,105.34 msec task-clock # 0.982 CPUs utilized 3 context-switches # 0.003 K/sec 0 cpu-migrations # 0.000 K/sec 197 page-faults # 0.178 K/sec 4,077,736,892 cycles # 3.689 GHz 15,442,709,352 instructions # 3.79 insn per cycle 2,435,131,301 branches # 2203.068 M/sec 2,643,775 branch-misses # 0.11% of all branches 1.125393845 seconds time elapsed 1.097770000 seconds user 0.008012000 seconds sys	4 years ago
Joshua Haberman	e2c709e047	Repeated string and primitive support. Much of the code was adapted from Gerben's code in: `6333031195`	4 years ago
Joshua Haberman	e9103eda9e	Merge branch 'master' into fastest-table	4 years ago
Joshua Haberman	0756999ab6	Merge pull request #325 from haberman/inlined-arena Fixed upb::InlinedArena, which was completely broken.	4 years ago
Joshua Haberman	25db40bc30	Fixed upb::InlinedArena, which was compeltely broken.	4 years ago
Joshua Haberman	d81ba58215	Optimized short string copying. This sped up the alias=false case: Before: ------------------------------------------------------------------------------ Benchmark Time CPU Iterations ------------------------------------------------------------------------------ BM_Parse_Upb_FileDesc_WithInitialBlock 4562 ns 4562 ns 153251 1.53276GB/s Performance counter stats for 'bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb_FileDesc_WithInitialBlock': 1,216.65 msec task-clock # 0.936 CPUs utilized 6 context-switches # 0.005 K/sec 0 cpu-migrations # 0.000 K/sec 200 page-faults # 0.164 K/sec 4,490,925,650 cycles # 3.691 GHz 16,516,403,731 instructions # 3.68 insn per cycle 2,828,536,650 branches # 2324.861 M/sec 5,425,830 branch-misses # 0.19% of all branches 1.300178903 seconds time elapsed 1.211475000 seconds user 0.072207000 seconds sys After: ------------------------------------------------------------------------------ Benchmark Time CPU Iterations ------------------------------------------------------------------------------ BM_Parse_Upb_FileDesc_WithInitialBlock 3587 ns 3587 ns 195749 1.94935GB/s Performance counter stats for 'bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb_FileDesc_WithInitialBlock': 1,109.69 msec task-clock # 0.930 CPUs utilized 5 context-switches # 0.005 K/sec 0 cpu-migrations # 0.000 K/sec 198 page-faults # 0.178 K/sec 4,094,010,257 cycles # 3.689 GHz 15,672,677,812 instructions # 3.83 insn per cycle 2,589,291,160 branches # 2333.346 M/sec 3,306,386 branch-misses # 0.13% of all branches 1.193221789 seconds time elapsed 1.102538000 seconds user 0.072166000 seconds sys	4 years ago
Joshua Haberman	f3a2a79349	More optimization, back up to 2.56GB/s.	4 years ago
Joshua Haberman	199c914295	Simplify push/pop when msg fits in the current buffer.	4 years ago
Joshua Haberman	d5f5db2729	Put string-copying field parser into a separate function. This helps to regain a bit of lost perf. Now at 2.3GB/s.	4 years ago
Joshua Haberman	883f20d4dc	Merge branch 'master' into fastest-table Unfortunately this regresses the benchmark to ~2.25GB/s. Optimizations forthcoming.	4 years ago
Joshua Haberman	1bd62e8218	Merge pull request #324 from haberman/simplemomi Eliminated bounds checks inside parsing a field.	4 years ago
Joshua Haberman	f4adbe0698	Optimized varint decoding from Gerben. This speeds things up but costs some code size. name old time/op new time/op delta ArenaOneAlloc 21.1ns ± 0% 21.3ns ± 0% +1.33% (p=0.000 n=12+12) ArenaInitialBlockOneAlloc 6.02ns ± 0% 6.02ns ± 0% ~ (p=0.579 n=10+10) LoadDescriptor_Upb 111µs ± 1% 110µs ± 1% -0.91% (p=0.003 n=11+12) LoadDescriptor_Proto2 258µs ± 1% 258µs ± 1% ~ (p=0.674 n=10+12) Parse_Upb_FileDesc_WithArena 11.2µs ± 0% 10.4µs ± 0% -6.67% (p=0.000 n=12+12) Parse_Upb_FileDesc_WithInitialBlock 10.6µs ± 0% 10.1µs ± 0% -4.48% (p=0.000 n=12+11) SerializeDescriptor_Proto2 5.36µs ± 5% 5.36µs ± 3% ~ (p=0.880 n=12+11) SerializeDescriptor_Upb 11.9µs ± 0% 12.0µs ± 0% +0.81% (p=0.000 n=12+12) FILE SIZE VM SIZE -------------- -------------- +23% +1.11Ki +24% +1.06Ki upb/decode.c +15% +560 +15% +560 decode_msg +140% +240 +188% +240 decode_longvarint64 [NEW] +174 [NEW] +128 decode_isdonefallback +56% +160 +65% +160 upb_decode -49.7% -1.06Ki [ = ] 0 [Unmapped] +0.0% +48 +0.9% +1.06Ki TOTAL	4 years ago
Joshua Haberman	48689df72e	Eliminated bounds checks inside parsing a field. Each field parser gets 16 bytes of slop. This requires using a patch buffer at end-of-buffer. This addes 80% of what is needed to support a pull parser with a data callback, since the main parser is now tolerant to buffer flips. There is a ~4% performance regression and 12% code size regression in upb/decode.c: name old time/op new time/op delta ArenaOneAlloc 21.0ns ± 0% 21.6ns ± 0% +2.87% (p=0.000 n=12+12) ArenaInitialBlockOneAlloc 6.02ns ± 0% 6.02ns ± 0% +0.09% (p=0.001 n=11+12) LoadDescriptor_Upb 114µs ± 1% 115µs ± 1% +0.96% (p=0.000 n=11+12) LoadDescriptor_Proto2 260µs ± 1% 261µs ± 1% +0.55% (p=0.033 n=12+12) Parse_Upb_FileDesc_WithArena 10.8µs ± 0% 11.2µs ± 0% +3.43% (p=0.000 n=11+11) Parse_Upb_FileDesc_WithInitialBlock 10.5µs ± 0% 10.9µs ± 0% +3.68% (p=0.000 n=12+12) SerializeDescriptor_Proto2 5.25µs ± 3% 5.42µs ± 5% +3.39% (p=0.007 n=12+12) SerializeDescriptor_Upb 12.0µs ± 0% 12.5µs ± 0% +4.14% (p=0.000 n=12+11) FILE SIZE VM SIZE -------------- -------------- +12% +606 +12% +560 upb/decode.c +7.9% +288 +7.9% +288 decode_msg [NEW] +174 [NEW] +128 decode_isdonefallback +56% +160 +65% +160 upb_decode -9.3% -16 -12.5% -16 decode_longvarint64 -25.5% -558 [ = ] 0 [Unmapped] +0.0% +48 +0.4% +560 TOTAL	4 years ago
Joshua Haberman	a345af9883	Added a codegen parameter for whether fasttables are generated or not. Example: $ CC=clang bazel build -c opt --copt=-g benchmarks:benchmark --//:fasttable_enabled=false INFO: Build option --//:fasttable_enabled has changed, discarding analysis cache. INFO: Analyzed target //benchmarks:benchmark (0 packages loaded, 913 targets configured). INFO: Found 1 target... Target //benchmarks:benchmark up-to-date: bazel-bin/benchmarks/benchmark INFO: Elapsed time: 0.760s, Critical Path: 0.58s INFO: 7 processes: 1 internal, 6 linux-sandbox. INFO: Build completed successfully, 7 total actions $ bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb ------------------------------------------------------------------------------ Benchmark Time CPU Iterations ------------------------------------------------------------------------------ BM_Parse_Upb_FileDesc_WithArena 10985 ns 10984 ns 63567 651.857MB/s BM_Parse_Upb_FileDesc_WithInitialBlock 10556 ns 10554 ns 66138 678.458MB/s $ CC=clang bazel build -c opt --copt=-g benchmarks:benchmark --//:fasttable_enabled=true INFO: Build option --//:fasttable_enabled has changed, discarding analysis cache. INFO: Analyzed target //benchmarks:benchmark (0 packages loaded, 913 targets configured). INFO: Found 1 target... Target //benchmarks:benchmark up-to-date: bazel-bin/benchmarks/benchmark INFO: Elapsed time: 0.744s, Critical Path: 0.58s INFO: 7 processes: 1 internal, 6 linux-sandbox. INFO: Build completed successfully, 7 total actions $ bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb ------------------------------------------------------------------------------ Benchmark Time CPU Iterations ------------------------------------------------------------------------------ BM_Parse_Upb_FileDesc_WithArena 3284 ns 3284 ns 213495 2.1293GB/s BM_Parse_Upb_FileDesc_WithInitialBlock 2882 ns 2882 ns 243069 2.4262GB/s Biggest unknown is whether this parameter should default to true or false.	4 years ago

... 5 6 7 8 9 ...

1831 Commits (94565270c9bae330ad1570322ab63b20ab4bd3a2) All Branches Search

1831 Commits (94565270c9bae330ad1570322ab63b20ab4bd3a2)

All Branches