This reverts commit f00e06c95b.
Although Node Buffers are not covered by the tests, it seems that there
are users relying on them, so we need to add back in support for them.
This fixes issue #4359.
@com_google_protobuf prefixed versions. This allows them to work in 3rd party
repositories.
Fix a bad visibility rule. :hidden does not exist, but :private does.
This prevents the Bazel `CcProtoAspect` from generating and linking
C++ object code for these files. Without this blacklist, symbols for
protobuf types depended on by `libprotobuf` may be defined multiple
times and violate the ODR rule.
Fixes https://github.com/google/protobuf/issues/4311
I noticed that running this script as `./update_file_lists.sh` on MacOS
was corrupting `cmake/extract_includes.bat.in`. Forcing the shell to
Bash fixes the generated file output.
Shadowed variables can cause readability issues. Ensure a shadowed
variable isn't used in header files which may be used in a dependent
project that explicitly disables them.
Chrome is running into two issues with the use of this macro
in open-source protobuf (https://crbug.com/809157):
1. GOOGLE_FALLTHROUGH_INTENDED is defined to nothing on __APPLE__
platforms, which blocks us from enabling -Wimplicit-fallthrough
on Mac and iOS. (We use a hermetic self-built modern clang,
so whatever Xcode bug that exclusion might be for doesn't apply
to us.)
2. It's in a public header file, and it's included in a public header file.
When clang suggests adding [[clang::fallthrough]], it checks if it knows of
a macro expanding to that and if so, suggests inserting that. Since lots of
chrome code includes protobuf headers, it often suggests inserting
GOOGLE_FALLTHROUGH_INTENDED (from protobuf) instead of the correct
FALLTHROUGH (from chrome's base).
Since the fallthrough doens't do anyting useful, just remove it.
Long ago, this might have had perf impact, but d64a2d9941 added a
parsing fast path that calls this switch as slow fallback, so it should
be off the hot path nowadays.
No intended behavior change.
This is the public version of internal change 184824132.
Adam Cozzette
Feng Xiao
James O'Kane
Paul Yang
Felix Jendrusch
BSBandme
Adam Cozzette
Jon Skeet
Jisi Liu
John Millikin
Abdul Sami
Dave Tapuska
Arkady Shapkin
Alexey Malov
Jie Luo
Yilun Chong
Thomas Van Lenten
Nico Weber
ObsidianMinor
Corentin Le Molgat