protobuf

Commit Graph

Author	SHA1	Message	Date
Joshua Haberman	9abf6e2ab0	Ported Ruby extension to upb_msg (#8184 ) * WIP. * WIP. * WIP. * WIP. * WIP. * WIP. * Added some missing files. * WIP. * WIP. * Updated upb. * Extension loads, but crashes immediately. * Gets through the test suite without SEGV! Still a lot of bugs to fix, but it is a major step! 214 tests, 378 assertions, 37 failures, 147 errors, 0 pendings, 0 omissions, 0 notifications 14.0187% passed * Test and build for Ruby 3.0 * Fixed a few more bugs, efficient #inspect is almost done. 214 tests, 134243 assertions, 30 failures, 144 errors, 0 pendings, 0 omissions, 0 notifications 18.6916% passed * Fixed message hash initialization and encode depth checking. 214 tests, 124651 assertions, 53 failures, 70 errors, 0 pendings, 0 omissions, 0 notifications 42.5234% passed * A bunch of fixes to failing tests, now 70% passing. 214 tests, 202091 assertions, 41 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications 70.0935% passed * More than 80% of tests are passing now. 214 tests, 322331 assertions, 30 failures, 9 errors, 0 pendings, 0 omissions, 0 notifications 81.7757% passed Unfortunately there is also a sporadic bug/segfault hanging around that appears to be GC-related. * Add linux/ruby30 and macos/ruby30 * Use rvm master for 3.0.0-preview2 * Over 90% of tests are passing! 214 tests, 349898 assertions, 15 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications 92.5234% passed * Passes all tests! 214 tests, 369388 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed * A bunch of cleanup. 1. Removed a bunch of internal-only symbols from headers. 2. Required a frozen check to get a non-const pointer to a map or array. 3. De-duplicated the code to get a type argument for Map/RepeatedField. * Removed a bunch more stuff from protobuf.h. There is an intermittent assert failure. Intermittent failure: ruby: ../../../../ext/google/protobuf_c/protobuf.c:263: ObjectCache_Add: Assertion `rb_funcall(obj_cache2, (__builtin_constant_p("[]") ? __extension__ ({ static ID rb_intern_id_cache; if (!rb_intern_id_cache) rb_intern_id_cache = rb_intern2((("[]") ), (long)strlen(("[]"))); (ID) rb_intern_id_cache; }) : rb_intern("[]")), 1, key_rb) == val' failed * Removed a few more things from protobuf.h. * Ruby 3.0.0-preview2 to 3.0.0 * Require rake-compiler-dock >= 1.1.0 * More progress, fighting with the object cache. * Passes on all Ruby versions! * Updated and clarified comment regarding WeakMap. * Fixed the wyhash compile. * Fixed conformance tests for Ruby. Conformance results now look like: RUBYLIB=../ruby/lib:. ./conformance-test-runner --enforce_recommended --failure_list failure_list_ruby.txt --text_format_failure_list text_format_failure_list_ruby.txt ./conformance_ruby.rb CONFORMANCE TEST BEGIN ==================================== CONFORMANCE SUITE PASSED: 1955 successes, 0 skipped, 58 expected failures, 0 unexpected failures. CONFORMANCE TEST BEGIN ==================================== CONFORMANCE SUITE PASSED: 0 successes, 111 skipped, 8 expected failures, 0 unexpected failures. Fixes include: - Changed Ruby compiler to no longer reject proto2 maps. - Changed Ruby compiler to emit a warning when proto2 extensions are present instead of rejecting the .proto file completely. - Fixed conformance tests to allow proto2 and look up message by name instead of hardcoding a specific list of messages. - Fixed conformance test to support the "ignore unknown" option for JSON. - Fixed conformance test to properly report serialization errors. * Removed debug printf and fixed #inspect for floats. * Fixed compatibility test to have proper semantics for #to_json. * Updated Makefile.am with new file list. * Don't try to copy wyhash when inside Docker. * Fixed bug where we would forget that a sub-object is frozen in Ruby >=2.7. * Avoid exporting unneeded symbols and refactored a bit of code. * Some more refactoring. * Simplified and added more comments. * Some more comments and simplification. Added a missing license block. Co-authored-by: Masaki Hara <hara@wantedly.com>	4 years ago
listonjesse	2ae7cf0e03	Auxillary -> Auxiliary	5 years ago
Joshua Haberman	32e5deb1ac	Sync from Piper @308829107 PROTOBUF_SYNC_PIPER	5 years ago
Joshua Haberman	6b759688a1	Implemented proto3 presence for Ruby. (#7406 ) * WIP. * WIP. * Builds and runs. Tests need to be updated to test presence. * Ruby: proto3 presence is passing all tests. * Fixed a bug where empty messages has the wrong oneof count.	5 years ago
Joshua Haberman	e8c67e14ac	Fixed the oneof case for lazy wrappers.	5 years ago
Joshua Haberman	8393d4833f	Nearly all known cases (map, repeated field, and top-level) have been addressed. The only case that doesn't work is decoding a wrapper type from JSON at the top level. This doesn't make sense and probably no users do it I changed it to throw.	5 years ago
Joshua Haberman	bd253f0130	Fixed equality, and extended to repeated fields and maps.	5 years ago
Sorah Fukumori	997bd354d5	Fix TypeError on decoding enum map values in Ruby (#6262 ) value_field_typeclass should be a enum module, not EnumDescriptor object. Also expanding tests for enum valued maps. Fixes #4580 Signed-off-by: Sorah Fukumori <her@sorah.jp>	6 years ago
Joe Bolinger	e4bbca1fc5	Add wrapper type helpers for Ruby (#5739 ) * add wrapper type helpers * add check for _as_value suffix	6 years ago
Joe Bolinger	d2daa38986	Add native type setters for Timestamp and Duration in Ruby (#5751 ) * add implicit time conversion * add duration * add init test * more tests * add type check and alternative c type check * add rational and bigdecimal * use rb_obj_is_kind_of * use native time check * chain implicit conversions * remove unused variable	6 years ago
bmoyles0117	0b5111dbab	Raise error for JSON overflow encoding in Ruby (#5752 ) (#5861 ) * add check for overflow * de-nestify * break long lines	6 years ago
Joe Bolinger	a6e3ac0db1	Generate extra enum method helpers for Ruby (#5670 ) * example with extra enum method * update expected test output * slight simplification * add test for generated enum helpers * move const helpers to c extension * more explicit test * more explicit test * indent * add foo test * add check for _const suffix	6 years ago
Joe Bolinger	7f14ea9f48	Raise error for JSON overflow encoding in Ruby (#5752 ) * add check for overflow * de-nestify * break long lines	6 years ago
Harshit Chopra	d0535cc09e	Adds support for proto2 syntax for Ruby gem. This change only adds basic proto2 support without advanced features like extensions, custom options, maps, etc. The protoc binary now generates ruby code for proto2 syntax. However, for now, it is restricted to proto2 files without advanced features like extensions, in which case it still errors out. This change also modifies the DSL to add proto messages to the DescriptorPool. There is a new DSL Builder#add_file to create a new FileDescriptor. With this, the generated ruby DSL looks something like: Google::Protobuf::DescriptorPool.generated_pool.build do add_file "test.proto" do add_message "foo" do optional :val, :int32, 1 end end end	6 years ago

2 Commits (899c276248cc21c47c4b1e904a5f712e759cbed7)