Protobuf Team Bot
5411fc6679
`TextFormat::ParseFieldValueFromString` now takes `absl::string_view` as `input` instead of `const std::string &`
...
`TextFormat::ParseFieldValueFromString` would take `const std::string &` as the input, but it's a read-only string and immediately passed to `ArrayInputStream`. This CL will change it to `absl::string_view`.
PiperOrigin-RevId: 540609068
1 year ago
Protobuf Team Bot
0a45abe4c2
Internal Change
...
PiperOrigin-RevId: 540584719
1 year ago
Protobuf Team Bot
3e6dba700f
typo fix: Javascript -> JavaScript in protobuf readme
...
PiperOrigin-RevId: 540459923
1 year ago
Dave MacLachlan
52430d7c60
Fix up sign comparison warning.
...
PiperOrigin-RevId: 540420790
1 year ago
Mike Kruskal
25a9547819
Automated rollback of commit 9b4ceb4770
.
...
PiperOrigin-RevId: 540399237
1 year ago
Mike Kruskal
9b4ceb4770
Remove workaround for whole-archive linker behavior.
...
PiperOrigin-RevId: 540373752
1 year ago
Mike Kruskal
aba0341126
Remove explicit syntax check on open enum zero value validation.
...
PiperOrigin-RevId: 540359843
1 year ago
Mike Kruskal
d1d7502444
Delete codespell presubmit.
...
This has caused repeated issues due to the fact that it checks the entire repo. Most recently, it decided to complain about a typo in a file that hasn't been touched in 5 years.
PiperOrigin-RevId: 540356791
1 year ago
Matt Kulukundis
62fdfd1062
Fix a typo
...
PiperOrigin-RevId: 540349262
1 year ago
Sandy Zhang
d5067ccbe6
Unify MessageSchema.writeFieldsInAscendingOrder proto2 and proto3 methods.
...
This unifies proto2 and proto3 (and later editions) implementations to incorporate performance optimizations directly referencing unsafe and caching reflection presence field (and offset) to all syntaxes. These optimizations were originally added in cl/187404278 for proto2 only.
These optimizations do not seem to be meaningfully proto2/3-specific. The UnsafeUtil methods simply wrap the corresponding Unsafe methods. Presence bit fields are used in the same way for proto3, but this optimization seems to predate proto3 optional.
While in there, better document how the buffer encoding and mask/offsets work.
PiperOrigin-RevId: 540320373
1 year ago
Protobuf Team Bot
5a48187464
Move internal-only but kernel-agnostic paths into an `__internal` module
...
Add some documentation along the way.
PiperOrigin-RevId: 540311409
1 year ago
Protobuf Team Bot
e4b500c476
Internal Code Change
...
PiperOrigin-RevId: 540289901
1 year ago
Protobuf Team Bot
2cf94fafe3
Auto-generate files after cl/540118699
1 year ago
Protobuf Team Bot
c3edc9036d
Internal change.
...
PiperOrigin-RevId: 540118699
1 year ago
Mike Kruskal
b1df92704b
Clean up staleness tests.
...
Our automation can't currently update release branches, so we need to enable staleness tests as presubmits to force manual regeneration.
PiperOrigin-RevId: 540094169
1 year ago
Protobuf Team Bot
381b31e9c9
Make ViewFor/MutFor use assoc. type instead of generic, rename to match
...
This implements the associated type change suggested by dmitrig@.
I don't foresee use cases that would make `ViewFor` allowing multiple `T` to be
useful, rather than confusing.
This also implements some suggested wording changes that I agree with.
PiperOrigin-RevId: 540024883
1 year ago
Protobuf Team Bot
e9391b4b3e
Update rules_java to the latest version
...
PiperOrigin-RevId: 540013522
1 year ago
Marcel Hlopko
cc83427ee3
Do not pass nullptr to slice::from_raw_parts
...
Pass dangling, but well-aligned pointer instead as per
https://doc.rust-lang.org/std/slice/fn.from_raw_parts.html#safety .
PiperOrigin-RevId: 539924021
1 year ago
Dmitri Gribenko
0246e09df8
Copy-edit comments in shared.rs
...
PiperOrigin-RevId: 539910433
1 year ago
Dmitri Gribenko
de21810745
Copy-edit comments in the BUILD file
...
PiperOrigin-RevId: 539901997
1 year ago
Protobuf Team Bot
1423035e0a
internal change
...
PiperOrigin-RevId: 539821682
1 year ago
Protobuf Team Bot
c4bc23782e
Automated rollback of commit aa2eb83fb8
.
...
PiperOrigin-RevId: 539776341
1 year ago
Protobuf Team Bot
aa2eb83fb8
Fix a bug in which we call Reflection::ClearField() on a default message instance.
...
PiperOrigin-RevId: 539740799
1 year ago
Tomo Suzuki
2fd29b0b73
Move linkage monitor check as part of Bazel build ( #12980 )
...
Fixes https://github.com/protocolbuffers/protobuf/issues/12912
Moving the Linkage Monitor check to Bazel, so that the result is cached.
Closes #12980
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12980 from suztomo:bazelize_linkage_monitor 51c00949ba
PiperOrigin-RevId: 539681611
1 year ago
Protobuf Team Bot
aa8fadc5cc
Automated rollback of commit d1f35880a2
.
...
PiperOrigin-RevId: 539653422
1 year ago
Protobuf Team Bot
d1f35880a2
Internal changes
...
PiperOrigin-RevId: 539641027
1 year ago
Marcel Hlopko
209accaf6f
Implement Proxied for v0.6
...
PiperOrigin-RevId: 539600447
1 year ago
Jie Luo
3560e2381e
Remove RegisterExtension in message class
...
PiperOrigin-RevId: 539568063
1 year ago
Protobuf Team Bot
6fe5c6fd8e
Auto-generate files after cl/539172395
1 year ago
Protobuf Team Bot
c53fb29ddf
Update TSan validation to not trigger on `mutable_repeated(int)`/`set_repeated(int, value)` accessors and also change to use _impl_ instead of _internal_metadata_ for validation.
...
Note that this is a no-op because TSan validation is currently disabled.
PiperOrigin-RevId: 539172395
1 year ago
Protobuf Team Bot
387d3132c4
internal change
...
PiperOrigin-RevId: 539141933
1 year ago
Mike Kruskal
4031712c34
Drop Bazel 4 support and add Bazel 6
...
PiperOrigin-RevId: 539130329
1 year ago
Mike Kruskal
a6f557fe81
Force push auto-commits to bypass branch protection status checks
...
PiperOrigin-RevId: 539109983
1 year ago
Dave MacLachlan
cf465769de
Clean up warnings from switch statements missing cases.
...
PiperOrigin-RevId: 539100447
2 years ago
Dave MacLachlan
c9ab361959
Mark some variables as unused.
...
PiperOrigin-RevId: 539095185
2 years ago
Sandy Zhang
a5349027e3
Handle clear for Java proto3 optionals (synthetic oneofs) using field descriptor instead of clear method.
...
This treats clear similarly to has and get to avoids issues from missing clear method for escaped synthetic oneofs (e.g. field _underscore -> oneof X_underscore). Previously, `clear` was using the clear method of the field (which has the same camel-cased name outside of the underscore case).
We also remove synthetic oneof camelCase names from the gencode for FieldAccesorTable since these should not be used / exposed.
Fixes #12880
PiperOrigin-RevId: 539069001
2 years ago
Protobuf Team Bot
6831d2072e
Making the logs friendly and useful.
...
Reducing the volume of repeating warning.
PiperOrigin-RevId: 538922035
2 years ago
Mike Kruskal
e1faf09604
Internal changes
...
PiperOrigin-RevId: 538814351
2 years ago
Protobuf Team Bot
e68550ec2c
Auto-generate files after cl/538811990
2 years ago
Mike Kruskal
d90c3e7c4f
Fix staleness test branching logic
...
PiperOrigin-RevId: 538812352
2 years ago
Protobuf Team Bot
6eb7ad1612
Automated rollback of commit dab3a8b389
.
...
PiperOrigin-RevId: 538811990
2 years ago
Protobuf Team Bot
e80cdef482
Auto-generate files after cl/538788425
2 years ago
Protobuf Team Bot
dab3a8b389
Automated rollback of commit d800c5f08b
.
...
PiperOrigin-RevId: 538788425
2 years ago
Thomas Van Lenten
2f1938fafe
Update the minimum macos to match cl/537907016
...
PiperOrigin-RevId: 538763399
2 years ago
Chad Wilson
cd615a8c65
deps: Update Guava to 32.0.0 ( #12953 )
...
Updates Guava to [32.0.0](https://github.com/google/guava/releases/tag/v32.0.0 ) to include fixes for CVE-2020-8908 and CVE-2023-2976 (https://github.com/google/guava/issues/2575 ) which affects certain builds with shaded usage, e.g ruby via jruby/java platform such as https://rubygems.org/gems/google-protobuf/versions/3.23.2-java
- Protobuf does not appear to (directly) use the affected `Files.createTempDir` or `FileBackedOutputStream` code which might behave differently on Windows.
- Referred to #9707 and #9757 for reference
- Updated transitive dependency versions match https://mvnrepository.com/artifact/com.google.guava/guava/32.0.0-jre (note major version change for `j2objc-annotations` from `1.3` --> `2.8`)
May need backporting to `23.x` branch if sufficiently compatible.
Closes #12953
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12953 from chadlwilson:update-guava-32 9c396b6759
PiperOrigin-RevId: 538666552
2 years ago
Protobuf Team Bot
460173d58b
Auto-generate files after cl/538573264
2 years ago
Protobuf Team Bot
d800c5f08b
In TSan mode, detect concurrent mutations of repeated/map fields.
...
PiperOrigin-RevId: 538573264
2 years ago
Protobuf Team Bot
87a601ebcd
Internal change
...
PiperOrigin-RevId: 538495469
2 years ago
Krzysztof Kosiński
41c022b1c5
Don't use macros to specify 64-bit literals in WireFormatTest.
...
The previous way of defining them is not compatible with unsigned integer overflow sanitizer, which complains about the conversion from uint64_t to int64_t in the macro LL().
PiperOrigin-RevId: 538418425
2 years ago
Protobuf Team Bot
947d4c37cf
Auto-generate files after cl/538323872
2 years ago