protobuf

19331 Commits

204 Branches

352 Tags

257 MiB

Tag: Branch: Tree: 6ceef1cdeb

Commit Graph

Author	SHA1	Message	Date
Protobuf Team Bot	e358a4025e	Convert proto toolchain string to Label Without it the still slightly weird setup of Bazel unit tests causes problems. PiperOrigin-RevId: 686745551	2 months ago
Protobuf Team Bot	9f9cb7a10e	Move proto_toolchain from rules_proto to protobuf The toolchain type is consumed by proto_library and produced by proto_toolchain rule. As such it's a private dependency, because both rules are now part of protobuf repo. There are some early adopters of --incompatible_enable_proto_toolchain_resolution that might be broken from this: grpc, rules_go, rules_ts, rules_rust, rules_lint, because they have implementation that is not using proto_common. Those repositories need to define their own proto_lang_toolchain and consume it with proto_common.compile. PiperOrigin-RevId: 654897871	5 months ago
Protobuf Team Bot	b19fbe62bc	Move proto_common implementation from Bazel binary Move toolchain helpers into a separate private file. After the migration those should be removed, so let's not make it a new public APIs. Copybara also handles differences in toolchain type labels. Remove ProtoLangToolchainInfo from proto_common. Providers need special care when moving and will be moved last. Read INCOMPATIBLE_ENABLE_PROTO_TOOLCHAIN_RESOLUTION from native proto_common. This is a BuildLanguageConfiguration flag (load time flag) and may only be read through native support. Add a dependency to the latest bazel_features that supports this check. On older Bazel versions fail if ALLOWLIST is configured. Implement version check for PackageSpecificationInfo. It's only available after Bazel 6.4.0. The rest of the implementation matches Bazel version. Tests are quite extensive and will be submitted in separate PRs. PiperOrigin-RevId: 651699412	5 months ago

Author

SHA1

Message

Date

Protobuf Team Bot

e358a4025e

Convert proto toolchain string to Label

Without it the still slightly weird setup of Bazel unit tests causes problems.

PiperOrigin-RevId: 686745551

2 months ago

Protobuf Team Bot

9f9cb7a10e

Move proto_toolchain from rules_proto to protobuf

The toolchain type is consumed by proto_library and produced by proto_toolchain rule. As such it's a private dependency, because both rules are now part of protobuf repo.

There are some early adopters of --incompatible_enable_proto_toolchain_resolution that might be broken from this: grpc, rules_go, rules_ts, rules_rust, rules_lint, because they have implementation that is not using proto_common. Those repositories need to define their own proto_lang_toolchain and consume it with proto_common.compile.

PiperOrigin-RevId: 654897871

5 months ago

Protobuf Team Bot

b19fbe62bc

Move proto_common implementation from Bazel binary

Move toolchain helpers into a separate private file. After the migration those should be removed, so let's not make it a new public APIs. Copybara also handles differences in toolchain type labels.

Remove ProtoLangToolchainInfo from proto_common. Providers need special care when moving and will be moved last.

Read INCOMPATIBLE_ENABLE_PROTO_TOOLCHAIN_RESOLUTION from native proto_common. This is a BuildLanguageConfiguration flag (load time flag) and may only be read through native support. Add a dependency to the latest bazel_features that supports this check. On older Bazel versions fail if ALLOWLIST is configured.

Implement version check for PackageSpecificationInfo. It's only available after Bazel 6.4.0.

The rest of the implementation matches Bazel version. Tests are quite extensive and will be submitted in separate PRs.

PiperOrigin-RevId: 651699412

5 months ago

3 Commits (6ceef1cdeb62f46f0ca9bca843d71bd30667f84f)