protobuf

18066 Commits

212 Branches

362 Tags

274 MiB

Tag: Branch: Tree: 65cb2c406a

Commit Graph

Author	SHA1	Message	Date
Protobuf Team Bot	f65108072b	Fixed printing of nan floats/doubles in Python. The second assert in _upb_EncodeRoundTripFloat is raised if val is a nan. This fix just returns the output of first spnprintf. I am not sure how changes to this repo are made so feel free to ignore this CL. To test this, you could 1. Define a proto with a float field message Test { float val = 1; } 2. In a python script, import the library and then set the val to nan and try to print it. proto = Test(val=float('nan')) print(proto) This will cause a coredump due to assertion error: assert.h assertion failed at third_party/upb/upb/lex/round_trip.c:46 in void _upb_EncodeRoundTripFloat(float, char *, size_t): strtof(buf, NULL) == val Added the corresponding change to double too PiperOrigin-RevId: 637127851	8 months ago

Author

SHA1

Message

Date

Protobuf Team Bot

f65108072b

Fixed printing of nan floats/doubles in Python.

The second assert in _upb_EncodeRoundTripFloat is raised if val is a nan. This fix just returns the output of first spnprintf.

I am not sure how changes to this repo are made so feel free to ignore this CL.

To test this, you could
1. Define a proto with a float field
message Test {
  float val = 1;
}
2. In a python script, import the library and then set the val to nan and try to print it.
proto = Test(val=float('nan'))
print(proto)

This will cause a coredump due to assertion error:

assert.h assertion failed at third_party/upb/upb/lex/round_trip.c:46 in void _upb_EncodeRoundTripFloat(float, char *, size_t): strtof(buf, NULL) == val

Added the corresponding change to double too

PiperOrigin-RevId: 637127851

8 months ago

1 Commits (65cb2c406a554bd7ed81cdaeb01c812b9b8b3071)