Mike Kruskal
6898451f5e
Setup upb installation with cmake.
...
This installs a upb's static library, headers, and three protoc plugin binaries (upb, upbdefs, upb_minitable). These will now be enabled by default, but can be disabled by setting protobuf_BUILD_LIBUPB=OFF.
To qualify this, we hook into our existing install test infrastructure which attempts to build and run our tests without any of the installation artifacts available from the source tree. Public headers are deleted, and builds of exported libraries/binaries are disabled.
PiperOrigin-RevId: 617376961
11 months ago
Mike Kruskal
83b7ca25b7
Fix windows-only issue in our compiler unittests.
...
Closes https://github.com/protocolbuffers/protobuf/issues/16026
PiperOrigin-RevId: 617333656
11 months ago
Mike Kruskal
19af1b40c6
Internal changes
...
PiperOrigin-RevId: 617322487
11 months ago
Sandy Zhang
925de189ec
Fix mistake in osgi.bzl to actually use list source_jars.
...
Bazel 7 updated java_out.source_jars to return a Depset.
Release images are still on Bazel 6, but cloudtops were updated to Bazel 7 already.
PiperOrigin-RevId: 617253874
11 months ago
Protobuf Team Bot
d9727cd657
Internal change
...
PiperOrigin-RevId: 617220518
11 months ago
Protobuf Team Bot
7c4d89e115
Implement Map::copy_from and implement the Extend trait for Maps
...
PiperOrigin-RevId: 617218421
11 months ago
Protobuf Team Bot
fa0d25a707
Add has_field() accessors for any field that supports presence.
...
PiperOrigin-RevId: 617170589
11 months ago
Protobuf Team Bot
8198fe9a5f
Change message-nesting namespacing to be some_msg:: instead of SomeMsg_::
...
PiperOrigin-RevId: 617153657
11 months ago
Protobuf Team Bot
d428610254
Automated rollback of commit 89670dd296
.
...
PiperOrigin-RevId: 617034523
11 months ago
Protobuf Team Bot
89670dd296
No public description
...
PiperOrigin-RevId: 617024635
11 months ago
Liam Miller-Cushon
2c07ea5317
Suppress a warning about a class initializer cycle
...
PiperOrigin-RevId: 616953542
11 months ago
Protobuf Team Bot
06444cb6a1
Clean up some now-unnecessary or_default()s
...
PiperOrigin-RevId: 616946153
11 months ago
Protobuf Team Bot
dca05ea1cd
Add a go/pytype annotation on Duration.toTimedelta.
...
PiperOrigin-RevId: 616938980
11 months ago
Protobuf Team Bot
1dbed2138c
Fix Rust Proto cpp-kernel map insertion behavior to better match Rust's std::HashMap and the upb-kernel behavior of "insert replaces the old value"
...
PiperOrigin-RevId: 616934577
11 months ago
Eric Salo
5d136e1b4d
upb: add containing_type() methods to MessageDefPtr and EnumDefPtr
...
PiperOrigin-RevId: 616908935
11 months ago
Hong Shin
413e7b10a0
Internal Change
...
PiperOrigin-RevId: 616872442
11 months ago
Protobuf Team Bot
0299edd5e4
Removed unused OneofMutEnumRsName function
...
PiperOrigin-RevId: 616858530
11 months ago
Protobuf Team Bot
dde9c5eee8
Auto-generate files after cl/616840653
11 months ago
Protobuf Team Bot
db60e52991
Reenable extension support for Weak Descriptor messages.
...
Extension registration now happens in two phases, where we register all linked in messages first and any dynamic message afterwards.
This guarantees that we register all extensions that will be used by descriptor parsing before we parse any descriptors.
This is currently disabled by default.
PiperOrigin-RevId: 616840653
11 months ago
Protobuf Team Bot
e6684ac037
C#: Avoid string concatenation when looking up enum values by name.
...
PiperOrigin-RevId: 616745400
11 months ago
Marcel Hlopko
71eed03fda
Remove unnecessary tags
...
PiperOrigin-RevId: 616741588
11 months ago
Eric Salo
da06505bdd
upb: use mapentry() in the code generator
...
PiperOrigin-RevId: 616713001
11 months ago
Protobuf Team Bot
6b36eb633c
Auto-generate files after cl/616648878
11 months ago
Protobuf Team Bot
9f65af7e76
Automated rollback of commit 5c183bda86
.
...
PiperOrigin-RevId: 616648878
11 months ago
Protobuf Team Bot
f06ae6c4fa
Auto-generate files after cl/616461373
11 months ago
Protobuf Team Bot
5c183bda86
Clear oneof message fields even on arena on non-OPT builds.
...
PiperOrigin-RevId: 616461373
11 months ago
Protobuf Team Bot
7ef5207d81
Auto-generate files after cl/616324144
11 months ago
Mike Kruskal
15c733eef7
Internal changes
...
PiperOrigin-RevId: 616324144
11 months ago
Mike Kruskal
0176f8a72a
Downgrade our sanitized builds to ubuntu-20.
...
The latest github runner image of ubuntu-22 includes a kernel update that breaks the sanitizers we use in our docker images. Long-term, we'll likely need to upgrade the images to new sanitizers and clang.
PiperOrigin-RevId: 616319042
11 months ago
Sam Gammon
742ddf1155
fix(java): fixup test codegen for maven build ( #16176 )
...
## Summary
Fixes and closes protocolbuffers/protobuf#16170 by adding missing test-gen mappings and exclusions. Recent [changes](https://github.com/protocolbuffers/protobuf/pull/15362 ) to Protocol Buffers, along with the addition of the _Editions_ feature, have evolved ahead of Maven; running the build on `main` shows build errors related to the testsuite.
## Changelog
- fix: missing test-gen mappings
- fix: missing test exclusions
Closes #16176
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/16176 from sgammon:fix/issue-16170 2be118cf9a
PiperOrigin-RevId: 616310039
11 months ago
Thomas Köppe
57f3065459
Declare and define explicit template instantiations, since the required specializations are needed at a point where the primary template is not defined.
...
PiperOrigin-RevId: 616297036
11 months ago
Mike Kruskal
88e0495a78
Fix remaining locale issues in PHP generator causing flakes.
...
PiperOrigin-RevId: 616289767
11 months ago
Mike Kruskal
8a3430bd1a
Fix locale issue with ::tolower in PHP generator
...
PiperOrigin-RevId: 616270918
11 months ago
Sandy Zhang
1e808d5ece
Remove extra whitespace line in JavaEditionDefaults template
...
PiperOrigin-RevId: 616261718
11 months ago
Protobuf Team Bot
5e8d7e5dbe
Auto-generate files after cl/616256211
11 months ago
Mike Kruskal
bca8fb6117
Implement edition 2023 support in all Ruby runtimes.
...
Three of these runtimes are based on upb, and the fourth is based on the Java runtime. Both of these already have editions support, so this was mostly just a matter of:
- Advertising support to allow editions codegen
- Stripping features from the runtime options
- Hooking up conformance tests
- Adding some lightweight editions tests
There are also a few minor orthogonal fixes included here:
- Ruby's upb hack for treating all enums as open enums needed tweaking
- The `enable_editions` flag is no longer needed in our internal proto rules
PiperOrigin-RevId: 616256211
11 months ago
Tiago Quelhas
9ca36df54f
Automated Code Change
...
PiperOrigin-RevId: 616246031
11 months ago
Protobuf Team Bot
c6c7d21f6e
IWYU, clang-tidy, etc.
...
PiperOrigin-RevId: 616207739
11 months ago
Mike Kruskal
c320e11262
Fix a test gap from https://github.com/protocolbuffers/protobuf/pull/13818
...
These tests were put into the wrong scope, and never actually ran. Fixing them turned up a bug in JRuby FFI where this fix wasn't applied.
PiperOrigin-RevId: 616172197
11 months ago
Mike Kruskal
4afc2cc17a
Fix incorrect definition of field label getter in FFI.
...
This was unintentionally disabling a test in repeated_field_test that is broken in JRuby FFI. It appears to be a bug in Enumeration, rather than our code.
PiperOrigin-RevId: 616164907
11 months ago
Mike Kruskal
c17b102148
Disable TSAN tests due to what appears to be a sanitizer bug
...
PiperOrigin-RevId: 616138585
11 months ago
Protobuf Team Bot
67816a54a9
Add "NO CHECKED-IN PROTOBUF GENCODE" to Protobuf Java gencode.
...
PiperOrigin-RevId: 616131629
11 months ago
Mike Kruskal
0a6a117ed3
Remove remaining uses of ctype, which has locale issues.
...
PiperOrigin-RevId: 615981920
11 months ago
Chris Kennelly
2ee72715e0
Automated Code Change
...
PiperOrigin-RevId: 615873441
11 months ago
Protobuf Team Bot
f72c45ff75
Change .submsg_mut() to return $Msg$Mut instead of FieldEntry<$Msg$>.
...
PiperOrigin-RevId: 615849358
11 months ago
Protobuf Team Bot
958dd59892
Remove the public _mut() accessors from string fields.
...
PiperOrigin-RevId: 615824279
11 months ago
Protobuf Team Bot
7e47fc3e39
Remove the _mut() accessors from primitive fields (both explicit presence where they were FieldEntry and implicit presence where they were PrimitiveMut).
...
PiperOrigin-RevId: 615792730
11 months ago
Protobuf Team Bot
fb08bca4e4
Auto-generate files after cl/615779322
11 months ago
Protobuf Team Bot
7ec56d4243
Remove the oneof_mut accessor and expose the oneof_case accessor on gencode api.
...
PiperOrigin-RevId: 615782249
11 months ago
Protobuf Team Bot
2f0fe0641c
Add Arena tracing handlers.
...
PiperOrigin-RevId: 615779322
11 months ago