Thomas Van Lenten
8b96aa1e4c
[ObjC] Update MessageSet Parsing.
...
- Follow upb and only accept the first value for `type_id` and `message`
- Reflow some of the logic to hopefully make things a little easier to follow/clear.
- Validate some more assertion about things the extensions for a MessageSet.
PiperOrigin-RevId: 652545240
5 months ago
Joshua Haberman
0309d86d31
Fixed `NAN`/`INFINITY` definitions to work on Windows 11 SDK.
...
Fixes: https://github.com/protocolbuffers/protobuf/issues/17308 , https://github.com/protocolbuffers/protobuf/issues/17238
Confirmation that this addresses the issue: https://github.com/grpc/grpc/issues/37210#issuecomment-2226809722
PiperOrigin-RevId: 652541857
5 months ago
Hong Shin
00a5a200e5
rename EnableIfProtosClass -> EnableIfHpbClass
...
PiperOrigin-RevId: 652532888
5 months ago
Protobuf Team Bot
e13b8e999b
Prepare the code for migrating return types from `const std::string&` to
...
`absl::string_view`.
Added temporary macro `PROTOBUF_TEMPORARY_ENABLE_STRING_VIEW_RETURN_TYPE` to turn on the new return type before the breaking change happens. It allows users to test and update their code ahead of time.
PiperOrigin-RevId: 652517294
5 months ago
zhangskz
8e60d9f166
Updating version.json and repo version numbers to: 29.0-dev ( #17432 )
...
NOTE: This should be reviewed and imported via Copybara per the normal PR review process.
Closes #17432
PiperOrigin-RevId: 652511521
5 months ago
Sandy Zhang
956ce0f3fd
Add visibility for rust public aliases for '@protobuf//:protobuf_rust'
...
PiperOrigin-RevId: 652511009
5 months ago
Protobuf Team Bot
3849bc6983
Change logic for inline strings to use the `constexpr` constructor of
...
`std::string` instead of runtime initializers.
PiperOrigin-RevId: 652506675
5 months ago
Hong Shin
133136cd9a
Migrate internal.h to hpb + update fwd hdr
...
PiperOrigin-RevId: 652504901
5 months ago
Hong Shin
16a8034d04
Migrate Arena to hpb namespace with forwarding
...
PiperOrigin-RevId: 652503898
5 months ago
Protobuf Team Bot
9717a07957
Internal changes to versions
...
PiperOrigin-RevId: 652485956
5 months ago
Mike Kruskal
06e65a29de
Add pkgconfig file for libupb
...
PiperOrigin-RevId: 651912682
5 months ago
Protobuf Team Bot
57828b0c60
More refactoring in preparation for RepeatedField SOO.
...
We previously renamed current_size_ to size_, total_size_ to capacity_, and Rep to HeapRep.
PiperOrigin-RevId: 651895012
5 months ago
Protobuf Team Bot
1aefa5715d
Upgrade input parameters in UnknownFieldSet from `const std::string&` to
...
`absl::string_view` to prepare the code for dropping `const std::string&` from
the interface.
PiperOrigin-RevId: 651894646
5 months ago
Protobuf Team Bot
1b6869ed2c
Move Rep out of RepeatedField and rename to HeapRep.
...
Motivation: refactoring in preparation for small object optimization in RepeatedField.
PiperOrigin-RevId: 651866147
5 months ago
Mike Kruskal
da7b416fc3
Downgrade CMake to 3.29 to workaround Abseil issue.
...
This was fixed in cd7f66cab5
, but older versions of Abseil break in CMake 3.30, which github runners now use by default.
PiperOrigin-RevId: 651854867
5 months ago
Sandy Zhang
e889b0be54
Deprecated unused/obsolete mutable APIs, to be removed in next breaking change.
...
These APIs were intended to support an internal-only mutable implementation of Java protobuf and should not actually be used in open source. Removal of these APIs shouldn't break anyone -- the equivalent immutable methods should be used instead.
PiperOrigin-RevId: 651833683
5 months ago
Thomas Van Lenten
339261f58c
[ObjC] Validate MessageSet expectations.
...
- Make the generator error if things are violated.
- Have the runtime assert in debug about the things also.
PiperOrigin-RevId: 651810474
5 months ago
Thomas Van Lenten
8e3eca48d0
[ObjC] Improve parsing validations
...
Pass through the expected end marker and validate it so calling code can't
forget to do the validations.
PiperOrigin-RevId: 651809006
5 months ago
Protobuf Team Bot
b14d9ee01f
Automated Code Change
...
PiperOrigin-RevId: 651754564
5 months ago
Protobuf Team Bot
b3c9f4e0a9
Implement proto_lang_toolchain rule
...
Enable the Starlark rule only on Bazel versions, that have the Starlark version of ProtoInfo provider. That's needed, because only that exposed _transitive_proto_info field that's used in the rule.
PiperOrigin-RevId: 651753437
5 months ago
Protobuf Team Bot
d10007cf37
Test proto_common.compile
...
Rewrite compile tests from BazelProtoCommonTest to Starlark. This is using rules_analysis for testing.
The tests are super fast (cca. 1s for all of the to run).
The tests work either with a redirect (calling native rule) or with actual implementation in the protobuf repository.
PiperOrigin-RevId: 651748083
5 months ago
Protobuf Team Bot
b19fbe62bc
Move proto_common implementation from Bazel binary
...
Move toolchain helpers into a separate private file. After the migration those should be removed, so let's not make it a new public APIs. Copybara also handles differences in toolchain type labels.
Remove ProtoLangToolchainInfo from proto_common. Providers need special care when moving and will be moved last.
Read INCOMPATIBLE_ENABLE_PROTO_TOOLCHAIN_RESOLUTION from native proto_common. This is a BuildLanguageConfiguration flag (load time flag) and may only be read through native support. Add a dependency to the latest bazel_features that supports this check. On older Bazel versions fail if ALLOWLIST is configured.
Implement version check for PackageSpecificationInfo. It's only available after Bazel 6.4.0.
The rest of the implementation matches Bazel version. Tests are quite extensive and will be submitted in separate PRs.
PiperOrigin-RevId: 651699412
5 months ago
Sandy Zhang
4b9a76cbd1
Add 28.x for staleness tests
...
PiperOrigin-RevId: 651590692
5 months ago
Sandy Zhang
ccb23625f8
Remove -fsjlj-exceptions from win32-config
...
This seems to be missing using i686-w64-mingw32/10-posix after updating release images to Debian 11.
It is not clear why this flag was added in the first place for win32 but not win64.
Context: https://stackoverflow.com/questions/61206449/how-to-compile-with-clang-and-mingw-w64
PiperOrigin-RevId: 651545252
5 months ago
Hong Shin
5f366b3b7d
update .proto namespace for hpb_generator/tests
...
PiperOrigin-RevId: 651523466
5 months ago
Protobuf Team Bot
b8cb34d744
Prepare the code for migrating return types from `const std::string&` to
...
`absl::string_view`.
PiperOrigin-RevId: 651520812
5 months ago
Tony Liao
34136b3794
Comment-only change: update and clarify code comments for io::Printer.
...
PiperOrigin-RevId: 651499037
5 months ago
Protobuf Team Bot
f70ba6482e
Change reflection based accessors to not modify the instance unless it is
...
necessary.
This is necessary for moving default message instances to rodata.
PiperOrigin-RevId: 651493772
5 months ago
Protobuf Team Bot
03729f631b
Internal changes to versions
...
PiperOrigin-RevId: 651493393
5 months ago
Protobuf Team Bot
7fa8718467
In RepeatedField, rename members and use member accessors.
...
Motivation: refactoring in preparation for small object optimization in RepeatedField.
PiperOrigin-RevId: 651446582
5 months ago
Protobuf Team Bot
77047d9cda
Auto-generate files after cl/651119789
5 months ago
Protobuf Team Bot
89cd4cfc35
Auto-generate files after cl/651113583
5 months ago
Protobuf Team Bot
c97a042116
In the custom vtable mode invert how the static/non-static overloads versions work for ByteSizeLong and _InternalSerialize. That way the public entry point and the function pointer both end up being the same. Currently, the static function is a separate function than the one called externally, forcing two functions to exist.
...
It has no effect in normal mode.
PiperOrigin-RevId: 651119789
5 months ago
Protobuf Team Bot
5025dcd9c0
Automated rollback of commit d3d86d2bee
.
...
PiperOrigin-RevId: 651114051
5 months ago
Protobuf Team Bot
f9dd9ce66e
UPB text encoder without using reflection for Rust (used for a message's Debug trait) that will print out field number to value entries instead of field name to value entries of a message like how it's expected for the usual text format using reflection.
...
General test for it is done in Rust, and then extensions are tested in UPB as they're not currently supported in Rust-upb.
PiperOrigin-RevId: 651113583
5 months ago
Protobuf Team Bot
32bcf0bead
Prepare the code for migrating protobuf string accessors to
...
`absl::string_view`.
PiperOrigin-RevId: 651113544
5 months ago
Hong Shin
ab78e2fc1d
protos -> hpb namespace transition :: minimal slice
...
PiperOrigin-RevId: 651111836
5 months ago
Marcel Hlopko
21c545c8c5
Delete dead code
...
PiperOrigin-RevId: 650892555
5 months ago
Sandy Zhang
759b25ed3e
Update old comment to reflect that Java lite bit encodes enum closedness rather than just map fields with closed proto2 enum values pre-editions.
...
PiperOrigin-RevId: 650824123
5 months ago
Mark Hansen
1a18882a5d
Avoid iterator allocation in FieldSet.isInitialized
...
PiperOrigin-RevId: 650814506
5 months ago
Mark Hansen
08a0994f4b
Avoid allocations in FieldSet.Builder.mergeFromField
...
- Pre-size ArrayList
- Avoid iterator allocation
PiperOrigin-RevId: 650811055
5 months ago
Mark Hansen
2f3b4603a1
Avoid an iterator allocation in FieldSet.Builder.setField
...
Fix some rawtypes warnings too.
PiperOrigin-RevId: 650804398
5 months ago
Mark Hansen
cc5eccfb28
Avoid iterator allocations in FieldSet.computeFieldSize
...
PiperOrigin-RevId: 650803788
5 months ago
Mark Hansen
8daad6ddd4
Avoid iterator allocations in FieldSet.writeField
...
This is a performance optimisation.
PiperOrigin-RevId: 650799480
5 months ago
Hong Shin
7a2b37f77d
Update hpb generator plugin namespace protos -> hpb
...
PiperOrigin-RevId: 650780819
5 months ago
Protobuf Team Bot
94f172de82
internal changes to plugin
...
PiperOrigin-RevId: 650770447
5 months ago
Protobuf Team Bot
b54a6aa9d3
Remove unused static field.
...
PiperOrigin-RevId: 650770379
5 months ago
Protobuf Team Bot
d3d86d2bee
Bump Google.Protobuf dependency on System.Memory to version >=4.5.5
...
PiperOrigin-RevId: 650736637
5 months ago
Protobuf Team Bot
9306e8446f
Internal changes to versions
...
PiperOrigin-RevId: 650726743
5 months ago
Mike Kruskal
f46e776b1f
Upgrade sanitizer tests back to ubuntu 22
...
Our test images now have sanitizers that support githubs kernel update.
PiperOrigin-RevId: 650723051
5 months ago