protobuf

Commit Graph

Author	SHA1	Message	Date
Protobuf Team Bot	30af08f511	Add private accessors for repeated array get to be used by C++ RepeatedField implementation. PiperOrigin-RevId: 526656160	2 years ago
Joshua Haberman	339fdb5e7b	Hide `upb_MiniTableField.descriptortype` with `UPB_PRIVATE()` macro PiperOrigin-RevId: 524371449	2 years ago
Joshua Haberman	73489a9339	Removed the cleanup list It no longer has any users. If we need it later, we can add it back. This saves one pointer of memory from `sizeof(upb_Arena)`. Also, we now allow fuses if if the block allocators differ. This is made possible by cl/520144430, but was not take advantage of in that CL. PiperOrigin-RevId: 520174588	2 years ago
Joshua Haberman	bdee30b0a6	Added special case for INT64_MIN in the codegen PiperOrigin-RevId: 516236492	2 years ago
Joshua Haberman	81d27ec0e5	Fixed MSAN warning by freeing the arena in ~InlinedArena(). This fixes an MSAN warning of the form: ``` WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7fc964f2a597 in arena_findroot third_party/upb/upb/mem/arena.c:64:3 #1 0x7fc964f2a597 in upb_Arena_Free third_party/upb/upb/mem/arena.c:211:7 #2 0x7fc9d2af0028 in std::__msan::unique_ptr<upb_Arena, void ()(upb_Arena)>::~unique_ptr() third_party/crosstool/v18/stable/toolchain/bin/../include/c++/v1/__memory/unique_ptr.h:277:7 #3 0x7fc9d2aef7a2 in ~Arena third_party/upb/upb/upb.hpp:70:7 #4 0x7fc9d2aef7a2 in ~InlinedArena third_party/upb/upb/upb.hpp:97:7 #5 0x7fc9d2aef7a2 in Cpp_InlinedArena2_Test::TestBody() third_party/upb/upb/test/test_cpp.cc:187:1 #6 0x7fc97da78a57 in testing::Test::Run() third_party/googletest/googletest/src/gtest.cc:2695:5 #7 0x7fc97da7a3e8 in testing::TestInfo::Run() third_party/googletest/googletest/src/gtest.cc:2844:11 #8 0x7fc97da7b897 in testing::TestSuite::Run() third_party/googletest/googletest/src/gtest.cc:3003:30 #9 0x7fc97daa5136 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/googletest/src/gtest.cc:5899:44 #10 0x7fc97daa455c in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/googletest/src/gtest.cc #11 0x7fc97daa455c in testing::UnitTest::Run() third_party/googletest/googletest/src/gtest.cc:5464:10 #12 0x562a7fb876f0 in RUN_ALL_TESTS third_party/googletest/googletest/include/gtest/gtest.h:2329:73 #13 0x562a7fb876f0 in main testing/base/internal/gunit_main.cc:86:10 #14 0x7fc9ba9b7632 in __libc_start_main (/usr/grte/v5/lib64/libc.so.6+0x61632) (BuildId: 280088eab084c30a3992a9bce5c35b44) #15 0x562a7fafdbe9 in _start /build/work/ab393f4ac612f9027aae6b1a7226027ba2a2/google3/blaze-out/k8-opt/bin/third_party/grte/v5_src/grte-scratch/BUILD/src/csu/../sysdeps/x86_64/start.S:120 Member fields were destroyed #0 0x562a7fb0b13d in __sanitizer_dtor_callback_fields third_party/llvm/llvm-project/compiler-rt/lib/msan/msan_interceptors.cpp:960:5 #1 0x7fc9d2aef79a in ~InlinedArena third_party/upb/upb/upb.hpp:105:8 #2 0x7fc9d2aef79a in ~InlinedArena third_party/upb/upb/upb.hpp:97:7 #3 0x7fc9d2aef79a in Cpp_InlinedArena2_Test::TestBody() third_party/upb/upb/test/test_cpp.cc:187:1 #4 0x7fc97da78a57 in testing::Test::Run() third_party/googletest/googletest/src/gtest.cc:2695:5 #5 0x7fc97da7a3e8 in testing::TestInfo::Run() third_party/googletest/googletest/src/gtest.cc:2844:11 #6 0x7fc97da7b897 in testing::TestSuite::Run() third_party/googletest/googletest/src/gtest.cc:3003:30 #7 0x7fc97daa5136 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/googletest/src/gtest.cc:5899:44 #8 0x7fc97daa455c in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/googletest/src/gtest.cc #9 0x7fc97daa455c in testing::UnitTest::Run() third_party/googletest/googletest/src/gtest.cc:5464:10 #10 0x562a7fb876f0 in RUN_ALL_TESTS third_party/googletest/googletest/include/gtest/gtest.h:2329:73 #11 0x562a7fb876f0 in main testing/base/internal/gunit_main.cc:86:10 #12 0x7fc9ba9b7632 in __libc_start_main (/usr/grte/v5/lib64/libc.so.6+0x61632) (BuildId: 280088eab084c30a3992a9bce5c35b44) #13 0x562a7fafdbe9 in _start /build/work/ab393f4ac612f9027aae6b1a7226027ba2a2/google3/blaze-out/k8-opt/bin/third_party/grte/v5_src/grte-scratch/BUILD/src/csu/../sysdeps/x86_64/start.S:120 ``` PiperOrigin-RevId: 511849224	2 years ago
Eric Salo	e860867804	upb_MiniTableExtension_Build() -> upb_MiniTableExtension_Init() The upb convention is that "_Build()" means to also allocate, which this function does not do, so rename it as "_Init()" to free up the name for a future function that does allocate. PiperOrigin-RevId: 510282736	2 years ago
Joshua Haberman	57a79de7cc	Ensure that extensions respect deterministic serialization. Previously we were not sorting extensions at encode time, even in deterministic mode. PiperOrigin-RevId: 508217926	2 years ago
Joshua Haberman	6e1cbdfe09	Added fuzzer for descriptor parsing/serialization, and fixed several bugs. The initial motivation for this change was to fix a bug found by fuzzing. The old fuzz test (built on `cc_fuzz_target()`) detected an infinite loop if a bytes field default has an unterminated `\x` escape. To fix this bug while expanding fuzz coverage, I created a fuzz test that verifies that we can do a lossless round trip from descriptor -> DefPool -> descriptor. We use C++ as the source of truth for whether a descriptor is valid or not, and what the canonical serialization back to protobuf form should be. I wrote the new fuzz test using go/FuzzTest, which makes it easier and more readable to use an arbitrary `FileDescriptorSet` as input, while adding test cases for regressions. The fuzz test highlighted a handful of errors that I subsequently fixed and added regression tests for: 1. The aforementioned unterminated `\x` bug. 2. We were not propagating the `edition` field. 3. We were missing the CheckIdent() check in a few places. 4. We were rejecting files with empty name, whereas C++ allows this. 5. There were a few bugs with escaping string defaults. Since FuzzTest is Clang-only, I split the `FUZZ_TEST()` invocation from the regression tests, since the latter are portable and should be run on all platforms. Only `FUZZ_TEST()` itself is in a google3/Clang-only file. PiperOrigin-RevId: 506997362	2 years ago
Protobuf Team Bot	067dfeacfd	Implement UPB OneOf MiniTable apis. PiperOrigin-RevId: 506691706	2 years ago
Eric Salo	68e3662a9c	fix fuzzer test w/nested maps update upb_MiniTable_SetSubMessage() to return false on failure fix ClangTidy warnings in upb/message/test.cc PiperOrigin-RevId: 505191802	2 years ago
Eric Salo	b29761fece	add return codes to upb_MiniTable_SetSubMessage/Enum() Currently these functions are hardwired to always return true, but the upstream code now checks for failures (which will be implemented soon). PiperOrigin-RevId: 504943663	2 years ago
Joshua Haberman	a5e337f88c	Allow dynamic tree shaking for groups, and disallow groups for map entry sub-messages. The initial motivation for this CL was to fix a bug found by fuzzing. But the fuzz bug pointed out a few edge cases that this CL corrects: 1. The core bug is that we were allowing a map entry sub-message to be linked to a group field. This is not allowed in protobuf schemas, but we did not check for this edge case in `upb_MiniTable_SetSubMessage()`, so we were de facto allowing it. This triggered some bad behavior in the parser whereby we pushed a limit without checking its validity first. 2. To defend against this, I added asserts in `upb_MiniTable_SetSubMessage()` to verify the type of the field we are linking, to ensure that a group field is not linked to a map entry sub-message. But this should probably be changed to return an error instead of relying on asserts for this. 3. I changed the fuzz util code that builds the MiniTable so that it will never violate this new invariant. The fuzz util code now can run into situations where a group field has no valid non-map-entry sub-message to select. In those cases it will simply not register any sub-message for that field. 4. Previously group did not support leaving sub-messages unregistered. Previously I added this feature for sub-messages but not for groups. There is no reason why dynamic tree shaking should not work for group fields, so I extended the feature to support groups also. PiperOrigin-RevId: 504913630	2 years ago
Protobuf Team Bot	9e9d43b462	Add support for promoting unlinked map fields from unknown to upb_Map. PiperOrigin-RevId: 494820200	2 years ago
Eric Salo	b98c7c7b50	move non-conformance tests and protos into upb/test/ create upb/test/BUILD PiperOrigin-RevId: 492534429	2 years ago

14 Commits (5a422398005e7df886f463a57f2ae562759562dd)