protobuf

Commit Graph

Author	SHA1	Message	Date
Hong Shin	e320c85283	Move MessageVTable to $pbr$ from $pbi$ Part 3 of 4 (added a stage). The getter and mut_getter bifurcate based on the kernel. upb returns Option<RawMessage>, while cpp returns the RawMessage. This means that we can't have a unified MessageVTable in vtable.rs, so we've split these out in {upb.rs and cpp.rs}. $field$_entry is now prepped and populated for the $field$_mut swappage in the following CL. PiperOrigin-RevId: 601230880	1 year ago
Hong Shin	0d090df3e2	Implement ProxiedWithRawVTable, ProxiedWithRawOptionalVTable, and ProxiedWithPresence for Messages Stage 2 of 3. Fleshed out the bodies required by the aforementioned contracts above. We create MessageVTable and utilize the `unsafe fns` directly in `message.cc` -- a departure from PrimitiveVTables. In the final followup CL, we will perform the field_entry swapover and update all unit tests. PiperOrigin-RevId: 600567890	1 year ago
Hong Shin	808487918c	Initialize scaffolding for ProxiedWithPresence for Messages We want to return $pb$::FieldEntry<'_, $msg_type$> for msg_mut accessors as opposed to the current state (returning $Msg$Mut directly). In this CL, we pave the way to implementing field entry returns. We introduce { MessagePresentMutData, MessageAbsentMutData } and impl { ProxiedWithRawVTable, ProxiedWithRawOptionalVTable }. I initially tried a blanket impl approach, but it collided with the already existing PrimitiveVTable constructs; perhaps worth revisiting post 0.6. In a followup, we'll flesh out the bodies. Lastly, we'll perform the swapover by replacing $field$_mut with $field$_entry, updating all related tests. PiperOrigin-RevId: 599282850	1 year ago
Alyssa Haroldsen	9e9c727881	Expose primitive internals just enough for enums PiperOrigin-RevId: 591933966	1 year ago
Alyssa Haroldsen	8505082f16	Improve thread safety docs/bounds for PrimitiveMut PiperOrigin-RevId: 591047379	1 year ago
Alyssa Haroldsen	162908d05f	Simplify the type bounds on PrimitiveMut via type erasure PiperOrigin-RevId: 591046477	1 year ago
Alyssa Haroldsen	6ae76fd6ed	Rework Repeated and primitives with traits for use by out-of-crate items PiperOrigin-RevId: 591007327	1 year ago
Adrian Sadłocha	c303109141	Implement mutators for singular primitive fields with presence PiperOrigin-RevId: 574485191	1 year ago
Protobuf Team Bot	78d71cac9f	Fix string setter thunk to use PtrAndLen instead of two args. PiperOrigin-RevId: 565118836	1 year ago
Joshua Haberman	4a513035cf	Shorten our license headers into an abbreviated form that references LICENSE instead of including it in full. PiperOrigin-RevId: 563888892	1 year ago
Adrian Sadłocha	8c08df5a84	Implement mutators for singular primitive fields without presence PiperOrigin-RevId: 563043919	1 year ago
Alyssa Haroldsen	9a0bc392b3	Implement v0.6 Optional Bytes This makes a few changes: - It changes generated messages to reference message innards as a type in `__runtime` instead of branching on what fields should be there. That results in much less bifurcation in gencode and lets runtime-agnostic code reference raw message innards. - It adds a generic mechanism for creating vtable-based mutators. These vtables point to thunks generated for interacting with C++ or upb fields. Right now, the design results in 2-word (msg+vtable) mutators for C++ and 3-word mutators (msg+arena+vtable) for UPB. See upb.rs for an explanation of the design options. I chose the `RawMessage+&Arena` design for mutator data as opposed to a `&MessageInner` design because it did not result in extra-indirection layout changes for message mutators. We could revisit this in the future with performance data, since this results in all field mutators being 3 words large instead of the register-friendly 2 words. - And lastly, as a nearby change that touches on many of the same topics, it adds some extra SAFETY comments for Send/Sync in message gencode. PiperOrigin-RevId: 559483437	2 years ago

12 Commits (596147e6f13f14664890cc7c0a053d00fd44b94f)