Mike Kruskal
54caf40312
Avoid using string(JOIN..., which requires cmake 3.12
...
This also downgrades our tests to use cmake 3.10, compatible with our support window.
Closes #12672
PiperOrigin-RevId: 529840763
2 years ago
deannagarcia
3dc68d257a
Merge pull request #12680 from protocolbuffers/23.x-202305051714
...
Update version numbers for 23.0-rc3
2 years ago
Protobuf Team Bot
289eeaae58
Updating version.json to: 23.0-dev
2 years ago
Protobuf Team Bot
d8f44cc2fb
Updating version.json and repo version numbers to: 23.0-rc3
2 years ago
deannagarcia
09ef9a29b8
Merge pull request #12659 from deannagarcia/23.x
...
Update UPB dep
2 years ago
deannagarcia
6354914e86
Merge branch 'protocolbuffers:23.x' into 23.x
2 years ago
deannagarcia
21417bf17f
Merge pull request #12667 from protocolbuffers/cmake-fixes-23
...
Cherrypick cmake fixes to 23.x
2 years ago
Mike Kruskal
5f97a7f494
Define a new set of cmake tests.
...
These more closely follow the standard practices of our users, where dependencies are pre-installed instead of using our provided sub-modules. This will prevent issues such as #12201 from reoccuring.
Additionally, this cl bumps our Abseil dependency to the latest release, and fixes a GTest issue that went previously unnoticed.
PiperOrigin-RevId: 529490402
2 years ago
Mike Kruskal
24d3e74ac9
Remove --remote argument in cmake tests.
...
This will prevent non-hermetic breakages from changes to the Abseil release branch we're pinned to.
PiperOrigin-RevId: 529459765
2 years ago
Mike Kruskal
750a6e7d7c
Bump Abseil submodule to 20230125.3 ( #12660 )
...
This partially addresses https://github.com/protocolbuffers/protobuf/issues/12201
Closes #12660
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12660 from mkruskal-google:absl-update ce07c45a10
PiperOrigin-RevId: 529456996
2 years ago
Protobuf Team Bot
6f3c80b1a0
Internal change
...
PiperOrigin-RevId: 529429609
2 years ago
Mike Kruskal
edbee27994
Bump Abseil submodule to 20230125.3 ( #12660 )
...
* Bump Abseil submodule to 20230125.3
* Fix gtest installation setup with submodules
2 years ago
Deanna Garcia
74cea3dda5
Revert "Fix tests"
...
This reverts commit 645336fb8a
.
2 years ago
Deanna Garcia
645336fb8a
Fix tests
2 years ago
Deanna Garcia
000755a8a7
Update UPB dep
2 years ago
deannagarcia
12c835107e
Merge pull request #12652 from deannagarcia/23.x
...
Automated rollback of commit a2c5ea614c
.
2 years ago
Thomas Van Lenten
5ded06d9ab
Automated rollback of commit a2c5ea614c
.
...
PiperOrigin-RevId: 529185812
2 years ago
deannagarcia
04d31b306c
Merge pull request #12647 from deannagarcia/23.x
...
Update UPB dep for 23.0-rc3
2 years ago
Deanna Garcia
df32e78d45
Update UPB dep
2 years ago
deannagarcia
e01953476c
Merge pull request #12638 from deannagarcia/23.x
...
Update abseil dependency and reorder dependencies to ensure we use th…
2 years ago
Deanna Garcia
c4731cdfdd
Update abseil dependency and reorder dependencies to ensure we use the version specified in protobuf_deps.
...
PiperOrigin-RevId: 528838071
2 years ago
Adam Cozzette
fb18db76ad
Merge pull request #12635 from acozzette/cherrypick-musttail-23
...
Turn off `clang::musttail` on i386
2 years ago
deannagarcia
9e2941faa4
Merge pull request #12632 from deannagarcia/23.x
...
Cherrypick fixes for 23.0-rc3
2 years ago
Adam Cozzette
b40633ff0b
Turn off `clang::musttail` on i386
...
We found last week that Clang's support for `musttail` on 32-bit Linux does not
seem to work reliably, so let's disable it for now.
PiperOrigin-RevId: 528817403
2 years ago
Deanna Garcia
b36c39236e
Fix bug in _internal_copy_files where the rule would fail in downstream repositories.
...
Taken from https://github.com/protocolbuffers/upb/blob/main/bazel/protobuf.patch#L42
Fixes https://github.com/protocolbuffers/protobuf/issues/12620 .
PiperOrigin-RevId: 528586464
2 years ago
Deanna Garcia
ad2dd26ffc
Mark internal rule manual
2 years ago
deannagarcia
28003bb6e0
Merge pull request #12623 from deannagarcia/23.x
...
fix(libprotoc): export useful symbols from .so
2 years ago
Carlos O'Ryan
46fb4aa8d2
fix(libprotoc): export useful symbols from .so
2 years ago
deannagarcia
d4ce533dcb
Merge pull request #12608 from protocolbuffers/23.x-202304281840
...
Update version numbers for 23.0-rc2
2 years ago
Protobuf Team Bot
29b8dc0eef
Updating version.json to: 23.0-dev
2 years ago
Protobuf Team Bot
51f51ac4ef
Updating version.json and repo version numbers to: 23.0-rc2
2 years ago
deannagarcia
e2bb23712a
Merge pull request #12607 from deannagarcia/23.x
...
Update UPB Dependency
2 years ago
Deanna Garcia
eb96482b3a
Update UPB dep
2 years ago
Mike Kruskal
0b73dd44a3
Add -ex switch to all docker bash commands. ( #12601 )
...
Without this, certain failures will be silently ignored.
PiperOrigin-RevId: 527718574
2 years ago
Mike Kruskal
49bb3f2064
Fixes Clang 6 linker bug ( #12600 )
...
PiperOrigin-RevId: 527711840
2 years ago
deannagarcia
aa4a192884
Merge pull request #12593 from protocolbuffers/23.0-rc2-patch
...
Cherrypick fixes for 23.0-rc2 into 23.x
2 years ago
Deanna Garcia
d19c7997ab
Fix bom tests
2 years ago
Deanna Garcia
99c9491f7c
Fix maven pom test
2 years ago
Mike Kruskal
e67e58a8e9
Silence deprecation warnings on FileDescriptor::SyntaxName
...
PiperOrigin-RevId: 527600194
2 years ago
Deanna Garcia
433c35dbcb
Remove osgi dependency from main java libraries.
...
//java:core, //java:lite, and //java:util shouldn't have this extra dependency. For now, we just add a separate version but we will look into using the java_library in protobuf_versioned_java_library in the future.
PiperOrigin-RevId: 527643325
2 years ago
Mike Kruskal
112a9021be
Squashed 'third_party/utf8_range/' changes from 72c943dea..cd1507d14 ( #12583 )
...
cd1507d14 Fix typo in pkg-config file to properly link the utf8_range libraries
3f179d134 Add pkg-config file declaring Abseil dependency of utf8_range
git-subtree-dir: third_party/utf8_range
git-subtree-split: cd1507d1479815fbcd8ff24dc05a978a62098bae
2 years ago
Mike Kruskal
db1d3f8b51
Replace previous breaking changes with deprecation warnings.
...
These changes hid public APIs that are deprecated in advance of protobuf editions. They will be fully removed in a future release. Any uses of them should be migrated to the future-facing feature helpers we provide on descriptor classes.
PiperOrigin-RevId: 527422059
2 years ago
Mike Kruskal
2230d0e748
Fix homebrew issue on Mac runners causing PHP CI failures
...
PiperOrigin-RevId: 527419345
2 years ago
Protobuf Team Bot
04a1a52892
Updating version.json to: 23.0-dev
2 years ago
Protobuf Team Bot
b21d6be78b
Updating version.json and repo version numbers to: 23.0-rc1
2 years ago
Deanna Garcia
b26afb5a86
Update protobuf's UPB dep in preparation for the 23.0-rc1 release.
...
PiperOrigin-RevId: 527061210
2 years ago
Protobuf Team Bot
132c67c2c7
Auto-generate files after cl/527051764
2 years ago
Protobuf Team Bot
182d564a3f
Move all the reflection related data of MapField into a separate structure.
...
This saves 24 bytes on each `map` field when reflection is not used.
It also delays constructing a Mutex until reflection is needed. This means we do
not have to register the mutex for destruction in the arena for normal
operation.
PiperOrigin-RevId: 527051764
2 years ago
Mike Kruskal
9898418bd9
Fix btree issue in map tests.
...
Without any weak ordering, btree_map fails to compile on windows 2022.
Closes #12289
PiperOrigin-RevId: 527019995
2 years ago
Son Luong Ngoc
5233990ad7
Fix protoc_nowkt linking on MacOS ( #12320 )
...
Depending on how the local cc toolchain is setup on macos, the core
foundation framework might not be available while linking protoc_nowkt.
This results in a few _CF symbols being interpreted as dynamic load and
is set to the binary's flat-namespace, causing runtime errors during
susequent actions such as gen_wkt_cc_sources.
```bash
> otool -dyld_info bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/com_google_protobuf/src/google/protobuf/compiler/protoc_nowkt | grep '_CF'
__DATA_CONST __got 0x10035C038 0x8010000000000007 bind 0x0 flat-namespace _CFRelease
__DATA_CONST __got 0x10035C040 0x8010000000000008 bind 0x0 flat-namespace _CFStringGetCString
__DATA_CONST __got 0x10035C048 0x8010000000000009 bind 0x0 flat-namespace _CFStringGetLength
__DATA_CONST __got 0x10035C050 0x801000000000000A bind 0x0 flat-namespace _CFStringGetMaximumSizeForEncoding
__DATA_CONST __got 0x10035C058 0x801000000000000B bind 0x0 flat-namespace _CFTimeZoneCopyDefault
__DATA_CONST __got 0x10035C060 0x801000000000000C bind 0x0 flat-namespace _CFTimeZoneGetName
```
Tell the linker to use CoreFoundation framework explicitly fixes this
issue.
```bash
> otool -dyld_info bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/com_google_protobuf/src/google/protobuf/compiler/protoc_nowkt | grep '_CF'
__DATA_CONST __got 0x10035C038 0x8010000000000007 bind 0x0 CoreFoundation _CFRelease
__DATA_CONST __got 0x10035C040 0x8010000000000008 bind 0x0 CoreFoundation _CFStringGetCString
__DATA_CONST __got 0x10035C048 0x8010000000000009 bind 0x0 CoreFoundation _CFStringGetLength
__DATA_CONST __got 0x10035C050 0x801000000000000A bind 0x0 CoreFoundation _CFStringGetMaximumSizeForEncoding
__DATA_CONST __got 0x10035C058 0x801000000000000B bind 0x0 CoreFoundation _CFTimeZoneCopyDefault
__DATA_CONST __got 0x10035C060 0x801000000000000C bind 0x0 CoreFoundation _CFTimeZoneGetName
```
closes #12173
Closes #12320
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12320 from sluongng:main 1416168f12
PiperOrigin-RevId: 526830008
2 years ago