c3b5637646
Added benchmark for loading ads descriptor.
...
Generally this seems to track the speed of loading descriptor.proto.
----------------------------------------------------------------------------------------------------
Benchmark Time CPU Iterations
----------------------------------------------------------------------------------------------------
BM_LoadDescriptor_Upb 59091 ns 59086 ns 11747 121.182MB/s
BM_LoadAdsDescriptor_Upb 4218587 ns 4218582 ns 166 120.544MB/s
BM_LoadDescriptor_Proto2 241083 ns 241049 ns 2903 29.7043MB/s
BM_LoadAdsDescriptor_Proto2 13442631 ns 13442099 ns 52 34.8975MB/s
4 years ago
acd72c6d3f
WIP.
4 years ago
8113ebd6c7
Added explanatory comment about integer constants.
4 years ago
f2d826b9f3
Got rid of floating-point division in table init.
...
Ideally we would get rid of all floating-point operations
in table.c, but that's a job for another day.
4 years ago
8f3ee80d46
Drop C89/C90 support and MSVC prior to Visual Studio 2015.
...
upb previously attempted to support C89 and pre-2015 versions
of Visual Studio. This was to support older compilers with
limited C99 support (particularly MSVC). But as of last August,
even gRPC has dropped support for MSVC prior to 2015
c87276d058
4 years ago
25db40bc30
Fixed upb::InlinedArena, which was compeltely broken.
4 years ago
f4adbe0698
Optimized varint decoding from Gerben.
...
This speeds things up but costs some code size.
name old time/op new time/op delta
ArenaOneAlloc 21.1ns ± 0% 21.3ns ± 0% +1.33% (p=0.000 n=12+12)
ArenaInitialBlockOneAlloc 6.02ns ± 0% 6.02ns ± 0% ~ (p=0.579 n=10+10)
LoadDescriptor_Upb 111µs ± 1% 110µs ± 1% -0.91% (p=0.003 n=11+12)
LoadDescriptor_Proto2 258µs ± 1% 258µs ± 1% ~ (p=0.674 n=10+12)
Parse_Upb_FileDesc_WithArena 11.2µs ± 0% 10.4µs ± 0% -6.67% (p=0.000 n=12+12)
Parse_Upb_FileDesc_WithInitialBlock 10.6µs ± 0% 10.1µs ± 0% -4.48% (p=0.000 n=12+11)
SerializeDescriptor_Proto2 5.36µs ± 5% 5.36µs ± 3% ~ (p=0.880 n=12+11)
SerializeDescriptor_Upb 11.9µs ± 0% 12.0µs ± 0% +0.81% (p=0.000 n=12+12)
FILE SIZE VM SIZE
-------------- --------------
+23% +1.11Ki +24% +1.06Ki upb/decode.c
+15% +560 +15% +560 decode_msg
+140% +240 +188% +240 decode_longvarint64
[NEW] +174 [NEW] +128 decode_isdonefallback
+56% +160 +65% +160 upb_decode
-49.7% -1.06Ki [ = ] 0 [Unmapped]
+0.0% +48 +0.9% +1.06Ki TOTAL
4 years ago
48689df72e
Eliminated bounds checks inside parsing a field.
...
Each field parser gets 16 bytes of slop. This requires using a patch
buffer at end-of-buffer.
This addes 80% of what is needed to support a pull parser with a data
callback, since the main parser is now tolerant to buffer flips.
There is a ~4% performance regression and 12% code size regression in
upb/decode.c:
name old time/op new time/op delta
ArenaOneAlloc 21.0ns ± 0% 21.6ns ± 0% +2.87% (p=0.000 n=12+12)
ArenaInitialBlockOneAlloc 6.02ns ± 0% 6.02ns ± 0% +0.09% (p=0.001 n=11+12)
LoadDescriptor_Upb 114µs ± 1% 115µs ± 1% +0.96% (p=0.000 n=11+12)
LoadDescriptor_Proto2 260µs ± 1% 261µs ± 1% +0.55% (p=0.033 n=12+12)
Parse_Upb_FileDesc_WithArena 10.8µs ± 0% 11.2µs ± 0% +3.43% (p=0.000 n=11+11)
Parse_Upb_FileDesc_WithInitialBlock 10.5µs ± 0% 10.9µs ± 0% +3.68% (p=0.000 n=12+12)
SerializeDescriptor_Proto2 5.25µs ± 3% 5.42µs ± 5% +3.39% (p=0.007 n=12+12)
SerializeDescriptor_Upb 12.0µs ± 0% 12.5µs ± 0% +4.14% (p=0.000 n=12+11)
FILE SIZE VM SIZE
-------------- --------------
+12% +606 +12% +560 upb/decode.c
+7.9% +288 +7.9% +288 decode_msg
[NEW] +174 [NEW] +128 decode_isdonefallback
+56% +160 +65% +160 upb_decode
-9.3% -16 -12.5% -16 decode_longvarint64
-25.5% -558 [ = ] 0 [Unmapped]
+0.0% +48 +0.4% +560 TOTAL
4 years ago
4ea81ab107
Fixed pedantic warning.
4 years ago
6399b31f4b
Removed ULL constants in json_decode.c.
4 years ago
c8ae197e64
Removed "U" suffixes, they are not necessary.
4 years ago
bc1e0b314f
Fixed some strict C89 errors.
4 years ago
2c1664906a
Removed license comments and upb_amalgamation for google3.
4 years ago
b7dc77415a
Added licenses() to all BUILD files.
4 years ago
e3f41de6c7
Split monolithic BUILD file into many build files.
4 years ago
6f59f1256e
Optimizations to descriptor loading.
4 years ago
c10b24ffb2
Simplified switch().
4 years ago
ded2e657a7
Added compatibility with old generated code.
...
Until everyone can regenerate their code, we need to provide
compatible semantics with the old generated code.
Also fixed a bug where enums were allocated 8 bytes instead
of 4.
4 years ago
7ccf5650c7
If we encounter "null" for a non-NullValue enum, throw an error.
4 years ago
0a3a94a12f
Updated to a new version of protobuf and fixed a few conformance tests.
...
When `google.protobuf.NullValue` appears on its own, we need to parse
and serialize it as plain JSON "null" value.
4 years ago
504e105420
undef UPB_ASAN.
4 years ago
ab96d1ec41
Removed extraneous C++-style comment.
4 years ago
d5096f9ee8
Fixed bug in addunknown and added ASAN poisoning.
4 years ago
2339fc779c
Updated obsolete comment.
4 years ago
ebe53f8590
Fixed compile error.
4 years ago
71749b7caf
Implemented inline array allocation, and moved type->lg2 map to reflection.
4 years ago
b58d2a0ee6
Shrink overhead of message representation.
4 years ago
d87ceeacab
Shave off one more store.
4 years ago
c25d895adf
Shrunk the arena state that needs to be synced.
4 years ago
ff40dd6ea9
Added new internal header.
4 years ago
cbcd635917
Fixed memory leak.
4 years ago
746f64692c
Moved arena inline for decoder.
4 years ago
b8ef1dcc57
Removed C++-style comments.
4 years ago
575acd85bd
Re-added const for all of the pointer wrapper types.
4 years ago
5aa5b77b41
Added simple offset-based accessors for defs, and deprecated old iterators.
4 years ago
a202ce9629
Add UPB_FORCEINLINE for varint32 decoding.
...
This speeds up the decoder by >20% and also reduces code size slightly!
name old time/op new time/op delta
ArenaOneAlloc 20.4ns ± 0% 20.2ns ± 0% -1.10% (p=0.000 n=12+11)
ArenaInitialBlockOneAlloc 5.25ns ± 0% 5.25ns ± 0% ~ (p=0.786 n=11+12)
ParseDescriptorNoHeap 17.1µs ± 0% 13.1µs ± 0% -23.29% (p=0.000 n=11+12)
ParseDescriptor 17.4µs ± 1% 13.5µs ± 1% -22.51% (p=0.000 n=12+12)
SerializeDescriptor 10.7µs ± 0% 10.9µs ± 0% +1.95% (p=0.000 n=12+12)
FILE SIZE VM SIZE
-------------- --------------
+2.7% +16 +2.7% +16 [LOAD #2 [RX]]
+0.5% +16 [ = ] 0 [Unmapped]
-1.4% -72 -0.7% -32 upb/decode.c
+3.1% +98 +3.1% +98 decode_msg
[DEL] -170 [DEL] -130 decode_varint32
-0.0% -40 -0.0% -16 TOTAL
4 years ago
5741eb9ad7
Expanded benchmarking script and added one size opt to the encoder.
4 years ago
0135399e60
Fixed bug introduced in refactoring.
4 years ago
df3438222b
Notated impossible branch as unreachable.
4 years ago
9b31e8fe12
Merged common encode tag paths.
4 years ago
5d7dc718cc
Minor formatting fix.
4 years ago
80441e4eb4
Optimized binary encoder.
4 years ago
ada28896b9
Changed encoder to use longjmp() for error recovery.
4 years ago
4d2251c3e4
Add UPB_NORETURN for MSC
4 years ago
efefbffc80
Fixed binary encoding and decoding for big-endian machines.
4 years ago
55dd9d3e41
Fixed UPB_ASSUME() for non-GCC, non-MSVC platforms.
4 years ago
8284321780
Fixed upb_fielddef_packed() to have the correct default.
4 years ago
8e26a33bcb
Added a test for UTF-8 parse checking and added missing error reporting.
4 years ago
2c666bc8f6
Use C-style comment instead of C++.
4 years ago
a77ea639d5
Verify UTF-8 when parsing proto3 string fields.
4 years ago
Joshua Haberman
Esun Kim