Protobuf Team Bot
132c67c2c7
Auto-generate files after cl/527051764
2 years ago
Protobuf Team Bot
182d564a3f
Move all the reflection related data of MapField into a separate structure.
...
This saves 24 bytes on each `map` field when reflection is not used.
It also delays constructing a Mutex until reflection is needed. This means we do
not have to register the mutex for destruction in the arena for normal
operation.
PiperOrigin-RevId: 527051764
2 years ago
Mike Kruskal
9898418bd9
Fix btree issue in map tests.
...
Without any weak ordering, btree_map fails to compile on windows 2022.
Closes #12289
PiperOrigin-RevId: 527019995
2 years ago
Son Luong Ngoc
5233990ad7
Fix protoc_nowkt linking on MacOS ( #12320 )
...
Depending on how the local cc toolchain is setup on macos, the core
foundation framework might not be available while linking protoc_nowkt.
This results in a few _CF symbols being interpreted as dynamic load and
is set to the binary's flat-namespace, causing runtime errors during
susequent actions such as gen_wkt_cc_sources.
```bash
> otool -dyld_info bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/com_google_protobuf/src/google/protobuf/compiler/protoc_nowkt | grep '_CF'
__DATA_CONST __got 0x10035C038 0x8010000000000007 bind 0x0 flat-namespace _CFRelease
__DATA_CONST __got 0x10035C040 0x8010000000000008 bind 0x0 flat-namespace _CFStringGetCString
__DATA_CONST __got 0x10035C048 0x8010000000000009 bind 0x0 flat-namespace _CFStringGetLength
__DATA_CONST __got 0x10035C050 0x801000000000000A bind 0x0 flat-namespace _CFStringGetMaximumSizeForEncoding
__DATA_CONST __got 0x10035C058 0x801000000000000B bind 0x0 flat-namespace _CFTimeZoneCopyDefault
__DATA_CONST __got 0x10035C060 0x801000000000000C bind 0x0 flat-namespace _CFTimeZoneGetName
```
Tell the linker to use CoreFoundation framework explicitly fixes this
issue.
```bash
> otool -dyld_info bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/com_google_protobuf/src/google/protobuf/compiler/protoc_nowkt | grep '_CF'
__DATA_CONST __got 0x10035C038 0x8010000000000007 bind 0x0 CoreFoundation _CFRelease
__DATA_CONST __got 0x10035C040 0x8010000000000008 bind 0x0 CoreFoundation _CFStringGetCString
__DATA_CONST __got 0x10035C048 0x8010000000000009 bind 0x0 CoreFoundation _CFStringGetLength
__DATA_CONST __got 0x10035C050 0x801000000000000A bind 0x0 CoreFoundation _CFStringGetMaximumSizeForEncoding
__DATA_CONST __got 0x10035C058 0x801000000000000B bind 0x0 CoreFoundation _CFTimeZoneCopyDefault
__DATA_CONST __got 0x10035C060 0x801000000000000C bind 0x0 CoreFoundation _CFTimeZoneGetName
```
closes #12173
Closes #12320
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12320 from sluongng:main 1416168f12
PiperOrigin-RevId: 526830008
2 years ago
Tomo Suzuki
d692223887
[WIP] Java BOM check with generated pom.xml files ( #12502 )
...
This check aims to address issues like https://github.com/protocolbuffers/protobuf/issues/12170 "Java 3.22.1: broken pom.xml".
Closes #12502
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12502 from suztomo:bom_check c69e2af597
PiperOrigin-RevId: 526776900
2 years ago
Adam Cozzette
07b1491895
Add better fallback behavior for retention stripping with invalid descriptors
...
PiperOrigin-RevId: 526758886
2 years ago
Mike Kruskal
f79e35c821
Fix declared dependencies for pkg-config ( #12518 )
...
Closes #12439
Closes #12518
PiperOrigin-RevId: 526689125
2 years ago
Jakob Buchgraber
0ecb729906
Implement 'bytes' accessors for UPB :)
...
Move the 'accessors_test.rs' to shared/ as both kernels now support the same accessor types.
PiperOrigin-RevId: 526591987
2 years ago
Protobuf Team Bot
37c8f8195b
Auto-generate files after cl/526587271
2 years ago
Jakob Buchgraber
e6b4f0e2d6
Delete the UPB kernel.
...
It's been made obsolete by cl/524903073.
PiperOrigin-RevId: 526587271
2 years ago
Protobuf Team Bot
bc127f2b56
Auto-generate files after cl/526184056
2 years ago
Protobuf Team Bot
469f0277b8
Add a field to ExtensionRangeOptions to mark an extension range is verified or not.
...
An extension range is either of verification state "UNVERIFIED" or "DECLARATION". If "DECLARATION", all extension fields of the range must be declared, or build error otherwise. The current default is "UNVERIFIED", but we will flip the default later.
Deprecate `is_repeated` in favor of `repeated`.
PiperOrigin-RevId: 526184056
2 years ago
Adam Cozzette
f71dc953c7
Add GitHub actions workflow for testing CMake build of examples directory
...
I confirmed that this test would catch the problem from #12450 .
PiperOrigin-RevId: 526165526
2 years ago
Mike Kruskal
5c59290022
Remove PROTOBUF_DEPRECATED in favor of [[deprecated]].
...
This appears to have been already broken for enum values on MSVC, and is completely unnecessary now that we required C++14.
PiperOrigin-RevId: 526163229
2 years ago
Kurt Alfred Kluever
295f1125ce
Adds `Timestamps.now()`.
...
PiperOrigin-RevId: 526160914
2 years ago
Protobuf Team Bot
a010e26505
Auto-generate files after cl/526143586
2 years ago
Protobuf Team Bot
908de8d74a
Automated rollback of commit 1e67de4ed5
.
...
PiperOrigin-RevId: 526143586
2 years ago
Protobuf Team Bot
81106b10dc
Automated rollback of commit 57d5ede3ec
.
...
PiperOrigin-RevId: 526130253
2 years ago
Protobuf Team Bot
d6ecec884c
Internal change.
...
PiperOrigin-RevId: 526046192
2 years ago
Sandy Zhang
cc7116ceeb
Remove unused proto3 field from UnknownFieldSetSchema.
...
This should reduce some unnecessary branching off of syntax for ManifestSchemaFactory for CODE_SIZE optimization for full using schemas.
PiperOrigin-RevId: 526039969
2 years ago
Tao Li
408afe1eb4
Fix typo for newlib macro ( #12521 )
...
Should use \_\_NEWLIB__
Closes #12521
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12521 from RiversideSC:main 3c793225db
PiperOrigin-RevId: 526020495
2 years ago
Luke Sandberg
983dac24c3
Change `PrintFreeFieldNumbers` to not assume that groups occupy the same field range as their containing messages.
...
PiperOrigin-RevId: 525876198
2 years ago
Protobuf Team Bot
699093915d
Auto-generate files after cl/525862155
2 years ago
Protobuf Team Bot
b2bd9dcb36
Refactor RepeatedMessageFieldGenerator code to use "_internal_$name$()" and "_internal_mutable_$name$()" rather than "$field$" to access fields in preparation for split repeated fields.
...
Motivation: we are planning to store split repeated fields in the split struct as pointers to repeated fields, which requires not accessing "$field$" directly.
We avoid using "_internal_$name$()" and "_internal_mutable_$name$()" in the implicit weak field case so that we can avoid linking in the message (as tested in implicit_weak_fields_test).
PiperOrigin-RevId: 525862155
2 years ago
Protobuf Team Bot
1123be7562
Auto-generate files after cl/525833833
2 years ago
Miguel Young de la Sota
725d7d9fc5
Partially convert message_field.cc to use Emit().
...
This CL does not change the formatting of any of the string templates;
it "only" reorganizes the file and updates the names of everything to match
other migrated files. Followup CLs will update the string templates.
PiperOrigin-RevId: 525833833
2 years ago
Jeff Gulbronson
a56e5ded7b
Reserve 1180 for Wire use_array ( #12491 )
...
release notes: no
Supports https://github.com/square/wire/pull/2433
Closes #12491
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12491 from JGulbronson:jgulbronson.claim-1180-for-wire f577336c0b
PiperOrigin-RevId: 525793344
2 years ago
Deanna Garcia
bd6a0cf15b
Delete old numpy_test.py file and replace references with the new one.
...
This is the final step to make numpy/pip_deps a test-only dependency.
PiperOrigin-RevId: 525785717
2 years ago
Protobuf Team Bot
0b180ad11a
Auto-generate files after cl/525778274
2 years ago
Protobuf Team Bot
1e67de4ed5
Add a new enum validation format. The format is compact for sequential and almost sequential enums. Uses Eytzinger layout for a fallback binary search.
...
PiperOrigin-RevId: 525778274
2 years ago
Miguel Young de la Sota
8e53046d94
Make protobuf_upb::Arena into a proper Rust RAII type.
...
PiperOrigin-RevId: 525775419
2 years ago
Jakob Buchgraber
44ac124713
Test nested messages support for UPB.
...
PiperOrigin-RevId: 525733570
2 years ago
Tao Li
945bf3c48d
Fix build for newlib ( #12501 )
...
Fix includes for newlib
Closes #12501
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12501 from RiversideSC:main cfcc72912d
PiperOrigin-RevId: 525623814
2 years ago
Matt Kulukundis
a75c1a2761
Add `assert` to the list of keywords for C++.
...
Closes #12010
PiperOrigin-RevId: 525607232
2 years ago
Adam Cozzette
b30259722d
Fix reference to protoc binary in protobuf-generate.cmake
...
This should fix #12374 , #12375 , and #12450 . The `protobuf_PROTOC_EXEC` variable
is not defined, and I think `protobuf::protoc` is what we should be using
instead.
PiperOrigin-RevId: 525591320
2 years ago
Protobuf Team Bot
866dfe6a68
protoc java: add missing annotation to clearField() for messages
...
PiperOrigin-RevId: 525547339
2 years ago
Protobuf Team Bot
eb8d57aa6d
Auto-generate files after cl/525538377
2 years ago
Protobuf Team Bot
6a675ebb44
Internal change
...
PiperOrigin-RevId: 525538377
2 years ago
Protobuf Team Bot
eeb9851397
Auto-generate files after cl/525522437
2 years ago
Protobuf Team Bot
cebf9fe37d
Internal changes
...
PiperOrigin-RevId: 525522437
2 years ago
Protobuf Team Bot
eecb4cef1d
Disable extension declarations validations in open source.
...
PiperOrigin-RevId: 525518049
2 years ago
Deanna Garcia
13833b1df0
Add numpy test to python_test_srcs target so that the python test wheel will have access to it.
...
PiperOrigin-RevId: 525498162
2 years ago
Marcel Hlopko
e5679c01e8
Implement nested messages for v0 API for cpp kernel
...
PiperOrigin-RevId: 525372222
2 years ago
zhangskz
22d0a354a0
Merge 22.x to main ( #12494 )
...
Closes #12494
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12494 from protocolbuffers:main-202304181855 4e23571384
PiperOrigin-RevId: 525263110
2 years ago
zhangskz
0603373e44
Merge pull request #12494 from protocolbuffers/main-202304181855
...
Merge 22.x to main
2 years ago
Sandy Zhang
8bdca948db
Update version.json to 23-dev
...
PiperOrigin-RevId: 525257136
2 years ago
Miguel Young de la Sota
35b9813f85
Actually run destructors of C++ messages.
...
PiperOrigin-RevId: 525244271
2 years ago
Protobuf Team Bot
6ad1a6d674
Internal change
...
PiperOrigin-RevId: 525235311
2 years ago
zhangskz
5e8510cfe5
Merge pull request #12496 from protocolbuffers/zhangskz-patch-2
...
Update version.json to 23-dev
2 years ago
zhangskz
cf71bbca9a
Update version.json to 23-dev
...
This commit should have been auto-generated as in 96ecd25b9c
, but we missed the step merging this to main from CSR when 22.x was cut.
2 years ago