protobuf

Commit Graph

Author	SHA1	Message	Date
Mike Kruskal	0b6e768f07	Introduce lifetimes for individual feature values. This enables enforcement of lifetime specifications on individual enum values for features. It will allow us to add new values to existing features, as well as deprecate/and remove existing values. By default, each value will be scoped to the lifetime spec of its corresponding feature field. However, individual lifetime boundaries can be overridden at the value-level for finer grained control. In the near-term, this will allow us to deprecate/remove required field presence, and add a stricter utf8 validation feature. PiperOrigin-RevId: 672710484	4 months ago
Protobuf Team Bot	647ee98c65	Add #include "third_party/protobuf/port_undef.inc" a bunch of many .cc files PiperOrigin-RevId: 647700575	6 months ago
Mike Kruskal	35b34252c7	Stop supporting EDITION_PROTO2 as an alias for EDITION_LEGACY. PiperOrigin-RevId: 638902499	7 months ago
Mike Kruskal	433ca3e6a1	Internal changes PiperOrigin-RevId: 637993561	8 months ago
Mike Kruskal	57a6e8df1c	Add dedicated tests to lock down that overridable defaults never change. Once an edition is released these should be fixed forever. On the other hand, the fixed defaults may see new features included as we change legacy behaviors in future editions. PiperOrigin-RevId: 625842071	9 months ago
Mike Kruskal	db5814e4ff	Use newly split feature defaults in plugins and runtimes. The new fields fixed_features and overridable_features can be simply merged to recover the old aggregate defaults. By splitting them though, plugins and runtimes get some extra information about lifetimes for enforcement. PiperOrigin-RevId: 625527117	9 months ago
Mike Kruskal	ea81024ddf	Refactor editions infrastructure to a top-level directory. The only public target here is the edition defaults helper macro, which can be used by external runtimes and plugins. None of this code is C++-specific though, and should be organized higher up. Appropriate aliases are also placed at the top level for public targets PiperOrigin-RevId: 625392504	9 months ago
Mike Kruskal	b3b4497d61	Implement feature lifetime validation in protoc and the C++ runtime. Features need to be validated within the pool being built, since the generated pool only contains extensions linked into the binary (e.g. protoc or a runtime building dynamic protos). The generated pool may be missing extensions used in this proto or it may have version skew. Moving to the build pool requires reflective parsing, which in general can't be done from inside the pool's database lock. This required some refactoring to add a post-build validation phase outside of the lock. For now, the feature support spec is optional and the checks only are only applied when it's present. Follow-up changes will add these specs to our existing features and then require them for all FeatureSet extensions. PiperOrigin-RevId: 623630219	9 months ago
Mike Kruskal	0e167e796f	Disallow all feature types except enum and boolean. Features are designed as temporary migration tools, and any unbounded type leaves the system open to unexpected use. Features should have a fixed set of values, with well defined behaviors. PiperOrigin-RevId: 617933544	10 months ago
Mike Kruskal	f66d876a10	Allow base64 encoding of embedded edition defaults. PiperOrigin-RevId: 610570515	11 months ago
Mike Kruskal	898d8fa1fd	Open-source editions Bazel rules for embedding defaults. These utilities provide a way to embed a FeatureSetDefaults message into generators or runtimes that need to implement feature resolution. They use protoc to handle the tricky reflection-based algorithm over feature protos, leaving only simple merges to be implemented in other languages. See docs/design/editions/editions-life-of-a-featureset.md for more information. PiperOrigin-RevId: 574554333	1 year ago

7 Commits (46c0b580675f4f1bff69b97848b3712c2bc9ec5c)