Alyssa Haroldsen
f4b042feb3
Improve user friendliness of oneof mutator types
...
PiperOrigin-RevId: 597490580
11 months ago
Jakob Buchgraber
8615daab29
#rust #unsafe Fix unsound cast of RepeatedMut to RepeatedView
...
When we implement Deref for RepeatedMut we cast it to a RepeatedView. The safety comments state that this is sound because both RepeatdView and RepeatedMut are repr(transparent) over InnerRepeatedMut. However, this has no longer been true after a recent change. RepeatedView and RepeatedMut had different layouts.
This change fixes the soundness issue by type casting the RawRepeatedField of a RepeatedMut to a RepeatedView. This is sound because RepeatedReview is repr(transparent) over RawRepeatedField.
PiperOrigin-RevId: 597488476
11 months ago
Hong Shin
27275da1c0
Fix typos in printer.h
...
PiperOrigin-RevId: 597400870
11 months ago
Protobuf Team Bot
c24d9de3ce
Add proto2::VisitFields() API.
...
PiperOrigin-RevId: 597398441
11 months ago
Protobuf Team Bot
41c8f2a5c6
Auto-generate files after cl/597378801
11 months ago
Mike Kruskal
f441ce89ed
Mint Edition 2024.
...
This will allow us to begin planning the default features for 2024, but since protoc doesn't declare support nobody will be able to use it yet.
PiperOrigin-RevId: 597378801
11 months ago
Sandy Zhang
cea942c872
Remove deadcode GenerateDescriptorInitializationCodeForMutable from Java code generator.
...
PiperOrigin-RevId: 597367715
11 months ago
Sandy Zhang
63623a688c
Remove public access to Java Edition APIs e.g. getEdition(), getEditionName().
...
Editions should not be used to make semantic decisions -- specific helpers (e.g. FieldDescriptor.hasPresence()) should be used instead. FileDescriptorProto can be used to access editions for *non semantic* purposes, incl. with ProtoFileUti.
These APIs have not been released yet and are thus non-breaking.
PiperOrigin-RevId: 597362543
11 months ago
Sandy Zhang
592ee9b192
Update to call descriptor outer class's getDescriptor() method instead of accessing internal descriptor variable directly.
...
PiperOrigin-RevId: 597355223
11 months ago
Mike Kruskal
748ab1608a
Breaking change: remove const GetArena method on RepeatedPtrField
...
PiperOrigin-RevId: 597349773
11 months ago
Protobuf Team Bot
1610bf149e
Auto-generate files after cl/597341799
11 months ago
Protobuf Team Bot
d4dfb9c4a6
Add kUpb_DecodeOption_AlwaysValidateUtf8 decode option, to force UTF-8 validation of proto2 strings.
...
PiperOrigin-RevId: 597341799
11 months ago
Protobuf Team Bot
686cfc6ab5
Protobuf Java cross-domain Poison Pills.
...
PiperOrigin-RevId: 597335599
11 months ago
Protobuf Team Bot
6820a563e2
Auto-generate files after cl/597327159
11 months ago
Marcel Hlopko
36d344b63f
Automated rollback of commit 0ce457f6e7
.
...
PiperOrigin-RevId: 597327159
11 months ago
Eric Salo
33080e9917
upb: disable the Fast Table CI tests on GH
...
PiperOrigin-RevId: 597310347
11 months ago
Protobuf Team Bot
9bee747dcf
Auto-generate files after cl/597279852
11 months ago
Eric Salo
b0d5ed8b08
upb: normalize some more function names
...
PiperOrigin-RevId: 597279852
11 months ago
Hong Shin
d2b8aa7ef2
Make upb::Status final
...
PiperOrigin-RevId: 597268485
11 months ago
Protobuf Team Bot
8c1f635716
Auto-generate files after cl/597126288
11 months ago
Eric Salo
c026907a5d
upb: replace public universal hazzer with non-universal hazzers
...
PiperOrigin-RevId: 597126288
11 months ago
Protobuf Team Bot
408b497d4e
Auto-generate files after cl/597088960
11 months ago
Mike Kruskal
755b690a7c
Breaking change: disallow incorrect ctype usage
...
PiperOrigin-RevId: 597091014
11 months ago
Protobuf Team Bot
0ce457f6e7
Adds mutable extension accessors to the codegen for upb C and adds a `::protos::MutableExtension` method to upb C++ for getting a mutable extension.
...
PiperOrigin-RevId: 597088960
11 months ago
Protobuf Team Bot
7d6198ed42
Print usage count if it's rarely used.
...
PiperOrigin-RevId: 597083184
11 months ago
Protobuf Team Bot
3b5b6e9f02
Allow friendly use of Reflection::MutableRaw(), Reflection::MutableRawNonOneof().
...
PiperOrigin-RevId: 597061355
11 months ago
Protobuf Team Bot
c5083a855a
InlinedArena needs copy constructor and copy assignment operator deleted
...
Deletes the default copy constructor and assignment operator.
PiperOrigin-RevId: 597041019
11 months ago
Hong Shin
373192ceff
Expunge unnecessary commentary from singular_message.cc and message.cc codegen
...
PiperOrigin-RevId: 597027922
11 months ago
Protobuf Team Bot
afd94185f7
Auto-generate files after cl/597019522
11 months ago
Eric Salo
facf959a78
upb: tag upb_Array.data as UPB_ONLYBITS()
...
PiperOrigin-RevId: 597019522
11 months ago
Protobuf Team Bot
e5b547bcb8
Change MsgMut's _mut() accessors to use (&mut self) instead of (&self)
...
If this took a &self there were holes in thread and memory safety, because it's allowed to get multiple &MsgMuts (but only &mut MsgMuts).
PiperOrigin-RevId: 596991263
11 months ago
Alyssa Haroldsen
0b5cd4e9ef
Implement repeated enum accessors
...
PiperOrigin-RevId: 596985413
11 months ago
Alyssa Haroldsen
20933b2b22
Implement singular enum accessors
...
PiperOrigin-RevId: 596984036
11 months ago
Protobuf Team Bot
f2c187df28
Auto-generate files after cl/596962024
11 months ago
Joshua Haberman
dbd4dcede0
Breaking Change: Removed `syntax` and added `has_presence?`/`is_packed?`.
...
Closes #15313
PiperOrigin-RevId: 596962024
11 months ago
Alyssa Haroldsen
e7be866a17
Support enums in DefaultValue
...
PiperOrigin-RevId: 596769895
11 months ago
Alyssa Haroldsen
e3d2551c8e
Move enum value name calculation
...
PiperOrigin-RevId: 596767666
11 months ago
Alyssa Haroldsen
fa67ce8d4d
Expand PrimitiveRsTypeName to work with non-primitives, rename, refactor
...
PiperOrigin-RevId: 596765288
11 months ago
Alyssa Haroldsen
1eab5a0237
Generate `pub use` for imported enums
...
PiperOrigin-RevId: 596762218
11 months ago
Alyssa Haroldsen
17b0f3f6a4
Add enum qualified path naming fns
...
PiperOrigin-RevId: 596738896
11 months ago
Alyssa Haroldsen
c16e0485c2
Refactor oneof/enum naming functions for consistency
...
PiperOrigin-RevId: 596734937
11 months ago
Protobuf Team Bot
f8d7885236
Add SPLIT test coverage to :analyze_profile_proto_test and disable force_split.
...
PiperOrigin-RevId: 596723248
11 months ago
Protobuf Team Bot
e1253cd905
Auto-generate files after cl/596706308
11 months ago
Eric Salo
87618fcbdd
upb: remove duplicate typedef for upb_TaggedMessagePtr
...
PiperOrigin-RevId: 596706308
11 months ago
Protobuf Team Bot
434d109d9c
Make utf8chars.chars iter return `impl Iterator + fmt::Debug`.
...
PiperOrigin-RevId: 596599987
11 months ago
Protobuf Team Bot
4e90eadcb3
Auto-generate files after cl/596588385
11 months ago
Eric Salo
c02f943f1a
upb: distinguish between fields and extensions in the public clear() accessors
...
PiperOrigin-RevId: 596588385
11 months ago
Jakob Buchgraber
991a2f4d54
#refactor Simplify maps through the new ProxiedInMapValue<K> trait
...
This change is a pure refactoring and simplification of the code. We replace all MapsWith<TYPE>KeyOps traits through a single generic ProxiedInMapValue<K> trait. Through connecting the runtime maps implementation with Proxied the code gets a lot simpler e.g. we can use View<T> instead of hardcoding the concrete type behind it.
I also expect this change to be beneficial for the gencode. In a subsequent CL we'll implement message values for maps. After this change we'll only have to implement a single trait, while before we had to implement num(key types) many traits.
PiperOrigin-RevId: 596562909
11 months ago
Protobuf Team Bot
1a21cb57b7
Auto-generate files after cl/596390524
11 months ago
Eric Salo
bdf24b2e0d
upb: add 'static' to some wire decoder functions
...
PiperOrigin-RevId: 596390524
11 months ago