Deanna Garcia
000da39ada
Fix python tests
3 years ago
Deanna Garcia
d2ca349c2a
Fix python tests
3 years ago
Deanna Garcia
fc9fb726f1
Fix python and kotlin tests
3 years ago
Adam Cozzette
22d0e265de
Update protobuf version for 3.19.4 ( #9449 )
...
I also updated the PHP release notes in
php/ext/google/protobuf/package.xml.
3 years ago
Maximilian
82372d8fe6
Use proper SPDX license identifier ( #9441 )
...
The previously used term "3-Clause BSD License" is not properly
standarized. A common standard is SPDX, therefore "3-Clause BSD License"
is substituted with "BSD-3-Clause" which is a SPDX identifier.
`grep -rl "3-Clause BSD License" | xargs -n1 sed -i "s/3-Clause BSD
License/BSD-3-Clause/g"`
3 years ago
Adam Cozzette
a035bd0882
Make libprotobuf symbols local on OSX ( #8346 ) ( #9435 )
...
@gnossen gave a great overview in https://github.com/grpc/grpc/pull/24992 of the overall problem.
If a python process using both protobuf _and_ another native library linking in libprotobuf
frequently can cause crashes. This seems to frequently affect tensorflow as well:
tensorflow/tensorflow#8394 ,
tensorflow/tensorflow#9525 (comment)
tensorflow/tensorflow#24976 ,
tensorflow/tensorflow#35573 ,
https://github.com/tensorflow/tensorflow/blob/v2.0.0/tensorflow/contrib/makefile/rename_protobuf.sh ,
tensorflow/tensorflow#16104
Testing locally this fixes both crashes when linking in multiple versions of protobuf
and fixes `DescriptorPool` clashes as well (e.g. Python and Native code import different versions of the same message).
Co-authored-by: Roy Williams <roy.williams.iii@gmail.com>
3 years ago
Joshua Haberman
62af892ddf
Fixed the build for Python 3.7.
3 years ago
Joshua Haberman
1c3d63dc25
Fixed a test by checking for the type of proto.
...
Also labeled a few tests for why we don't pass them.
3 years ago
Joshua Haberman
06d6f5c91f
Added test for -0.
3 years ago
Joshua Haberman
bc7b5dcadf
Ported protobuf's dtoa() function for text format and JSON.
3 years ago
Joshua Haberman
bb95a18631
Fixed a bug in the enum value map, fixing a few unit tests.
3 years ago
Joshua Haberman
cfdd016bed
PyUpb_CheckStrData() -> PyUpb_VerifyStrData()
3 years ago
Joshua Haberman
606308c639
Added back missing underscore.
3 years ago
Joshua Haberman
b38e4a4332
Fixed a few cases where we were not checking GetStrData properly.
3 years ago
Joshua Haberman
e613af9e87
Fixed test by checking string argument properly.
3 years ago
Joshua Haberman
75b6291e40
Renamed upb_FieldType_* -> kUpb_FieldType_*
3 years ago
Joshua Haberman
2bdbfc33e5
Addressed PR comments.
3 years ago
Joshua Haberman
392531c14f
Fixed test by implementing FindMethodByName().
3 years ago
Joshua Haberman
3eeea895dd
Fixed FieldDescriptor test.
3 years ago
Joshua Haberman
cd214fe73d
upb_TextEncode.
3 years ago
Joshua Haberman
0c541f3305
Single encode.
3 years ago
Joshua Haberman
72af9dc0cc
Switch to a single upb_Decode.
3 years ago
Joshua Haberman
499c2cc8b1
upb_extreg, upb_msg
3 years ago
Joshua Haberman
ffdcc46390
Fixed a handful of reference leaks found in a debug build of Python ( #484 )
...
* Fixed some reference leaks.
* Fixed a few reference leaks.
* Fixed a few more memory errors.
* Fixed a few more reference leaks.
* Revert minimal_test.py.
* Re-enable limited API.
* Removed some debugging and spurious changes.
* Addressed PR comments.
3 years ago
Joshua Haberman
1c955f37ce
Mass API rename and clang-reformat ( #485 )
...
* Wave 1: upb_fielddef.
* upb_fielddef itself.
* upb_oneofdef.
* upb_msgdef.
* ExtensionRange.
* upb_enumdef
* upb_enumvaldef
* upb_filedef
* upb_methoddef
* upb_servicedef
* upb_symtab
* upb_defpool_init
* upb_wellknown and upb_syntax_t
* Some constants.
* upb_status
* upb_strview
* upb_arena
* upb.h constants
* reflection
* encode
* JSON decode.
* json encode.
* msg_internal.
* Formatted with clang-format.
* Some naming fixups and comment reformatting.
* More refinements.
* A few more stragglers.
* Fixed PyObject_HEAD with semicolon. Removed TODO entries.
3 years ago
Adam Cozzette
cc7b1b5323
Update protobuf version
3 years ago
Adam Cozzette
203c593b96
Fix build error with Python 3.10 build on Windows
...
The Windows build for Python 3.10 is giving us an error about ssize_t
being undefined, so this commit fixes the problem by replacing it with
Py_ssize_t, which is consistent with what we do elsewhere in the file.
3 years ago
Adam Cozzette
922a7ec189
Fix Python 3.10 C++ tests ( #9128 )
...
The first change is to make sure we always define PY_SSIZE_T_CLEAN
before including Python.h. Starting from Python 3.10 this is required.
Otherwise we get errors like this:
SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats
The second change is to update reflection_test.py to account for the
fact that with Python 3.10, we get a TypeError even with the C++
implementation when trying to assign a float to a bool field. I'm not
sure why this changed with Python 3.10, but it seems like a good thing
since this is the desired behavior anyway.
3 years ago
Joshua Haberman
201d2265e3
Variable rename for readability.
3 years ago
Joshua Haberman
8c256cc677
Addressed PR comments.
3 years ago
Joshua Haberman
5953ac4736
Backed out Reify() signature change.
3 years ago
Joshua Haberman
fff8dfb035
Cleaned up reporting of initialization errors.
3 years ago
Joshua Haberman
917f425326
Removed extraneous whitespace.
3 years ago
Joshua Haberman
4c005384d6
A few readability improvements.
3 years ago
Joshua Haberman
d4c0c638b8
Cleaned up ListFields sorting.
3 years ago
Joshua Haberman
d8915b3174
Cleaned up IsInitialized().
3 years ago
Joshua Haberman
cfeb1ad685
Removed extraneous whitespace.
3 years ago
Joshua Haberman
62702b6cb1
Matched text format for maps.
3 years ago
Joshua Haberman
f7b1cd3b3e
Fixed TextFormat tests by providing testdata.
3 years ago
Joshua Haberman
3eae44bada
Refine the exception type when assigning improper attributes.
3 years ago
Joshua Haberman
1c37c488d4
Refined error message.
3 years ago
Joshua Haberman
8af637bcd2
Added extension field numbers.
3 years ago
Joshua Haberman
c75b39fc4d
Accept bytes object as field name.
3 years ago
Joshua Haberman
61d6eff5c4
Throw the proper errors for message initialization failure.
3 years ago
Joshua Haberman
4984a22e75
Fixed error message when serializing with required fields missing.
3 years ago
Joshua Haberman
bca2688f3a
Implemented weird behavior when a field contains invalid UTF-8.
3 years ago
Joshua Haberman
3b25e6fde3
Implemented msg.<NAME>_FIELD_NUMBER attributes.
3 years ago
Joshua Haberman
4993f7a73a
Sort ListFields() results.
3 years ago
Joshua Haberman
cbe314d91e
Implemented IsInitialized(), fixing several more tests.
3 years ago
Joshua Haberman
586f84cd30
Properly check type of integers when converting.
3 years ago