protobuf

Commit Graph

Author	SHA1	Message	Date
Protobuf Team Bot	73ee41cbb2	license changes PiperOrigin-RevId: 534600788	2 years ago
Joshua Haberman	3b0c9261c6	Update to ads v13, to unbreak the build. Ads removed v11 earlier today: `ee990a675b` PiperOrigin-RevId: 520446026	2 years ago
Joshua Haberman	d520014cfa	Added benchmarks for `upb_Arena_Fuse()` I added two variants, one which is unbalanced (always fusing a single arena into the group) while the other is balanced (always fusing two groups of equal size). Unfortunately it is difficult to benchmark `upb_Arena_Free()` separately from fuse, since the only way to get a non-zero refcount is to fuse. Results on my machine: ``` CPU: Intel Skylake Xeon with HyperThreading (48 cores) dL1:32KB dL2:1024KB dL3:38MB Benchmark Time(ns) CPU(ns) Iterations ------------------------------------------------------------------- BM_ArenaFuseUnbalanced/2 52.2 52.2 1000000 38.300M items/s BM_ArenaFuseUnbalanced/8 416 416 142315 19.243M items/s BM_ArenaFuseUnbalanced/64 4034 4033 14306 15.868M items/s BM_ArenaFuseUnbalanced/128 8302 8301 6837 15.420M items/s BM_ArenaFuseBalanced/2 54.7 54.7 1000000 36.581M items/s BM_ArenaFuseBalanced/8 425 425 100000 18.845M items/s BM_ArenaFuseBalanced/64 4029 4029 14632 15.886M items/s BM_ArenaFuseBalanced/128 8050 8049 7176 15.902M items/s ``` PiperOrigin-RevId: 518292073	2 years ago
Joshua Haberman	c2a0cbe7d1	Add no-remote-exec tag to genrule() so Cider won't try to run it. PiperOrigin-RevId: 507582384	2 years ago
Mike Kruskal	2b011bc759	Internal changes PiperOrigin-RevId: 487599716	2 years ago
Protobuf Team Bot	306123e2e8	C++ Code generator PiperOrigin-RevId: 486158566	2 years ago
Eric Salo	41335a03be	normalize upb_Message_New() We had _upb_Message_New(), which created a message from a mini table and was being used outside of upb even though it is an internal-only function. We also had upb_Message_New(), which created a message from a message def. Now there is a single public function, upb_Message_New(), which creates a message from a mini table and covers all use cases. (The internal version has the same definition and is used for inlining.) PiperOrigin-RevId: 480169804	2 years ago
Protobuf Team Bot	04363f7bae	Update workspace_deps.bzl protobuf main commit PiperOrigin-RevId: 479635174	2 years ago
Eric Salo	edecfd5eb0	upb: use the new reflection headers Reflection headers now live in upb/reflection/ so update our include statements to reflect this. (See what I did there?) PiperOrigin-RevId: 474596615	2 years ago
Protobuf Team Bot	97993b219d	rename upb::SymbolTable as upb::DefPool PiperOrigin-RevId: 456147709	2 years ago
Protobuf Team Bot	88047d90ba	update benchmark.cc from v7 to v11 of the google ads proto PiperOrigin-RevId: 455675163	2 years ago
Protobuf Team	78f5af8103	Internal change PiperOrigin-RevId: 435060849	3 years ago
Protobuf Team	b8edc7153f	Internal change PiperOrigin-RevId: 435056074	3 years ago
Joshua Haberman	970c645140	Fixes for google3 (layering check and formatting).	3 years ago
Joshua Haberman	8405436044	Addressed PR comments.	3 years ago
Joshua Haberman	c944638b9b	Changed benchmarks:benchmark to cc_test(), so it can be run with "bazel test".	3 years ago
Joshua Haberman	6af01a26a0	Ran clang-format.	3 years ago
Joshua Haberman	4c9891bf3e	Renamed LoadDefInit_NoLayout() to LoadDefInit_BuildLayout(). This will clarify that the function should go with the WithLayout benchmarks.	3 years ago
Joshua Haberman	205a7ea8b1	Added a variant of the def-loading benchmark that builds layout dynamically. This will help us evaluate the performance impacts (if any) that the new mini-table building code will have.	3 years ago
Joshua Haberman	1c955f37ce	Mass API rename and clang-reformat (#485 ) * Wave 1: upb_fielddef. * upb_fielddef itself. * upb_oneofdef. * upb_msgdef. * ExtensionRange. * upb_enumdef * upb_enumvaldef * upb_filedef * upb_methoddef * upb_servicedef * upb_symtab * upb_defpool_init * upb_wellknown and upb_syntax_t * Some constants. * upb_status * upb_strview * upb_arena * upb.h constants * reflection * encode * JSON decode. * json encode. * msg_internal. * Formatted with clang-format. * Some naming fixups and comment reformatting. * More refinements. * A few more stragglers. * Fixed PyObject_HEAD with semicolon. Removed TODO entries.	3 years ago
Joshua Haberman	50978256b9	Properly byte-swap fixed packed fields.	3 years ago
Joshua Haberman	4abe724dde	A few more fixes.	3 years ago
Joshua Haberman	7907ed913b	Expanded the test to cover packed fields also.	3 years ago
Joshua Haberman	2e1502a637	Set benchmark baseline back to master.	3 years ago
Joshua Haberman	77c0381013	Interleave benchmark results.	3 years ago
Joshua Haberman	eabb77458a	Fixes to make upb's tests compatible with a minimal Docker container.	3 years ago
Joshua Haberman	c5d6ec737e	Removed unnecessary dependency.	3 years ago
Joshua Haberman	41bfbca375	Updated ads benchmark to v7 as v5 no longer exists upstream.	3 years ago
Joshua Haberman	cdd6434a31	Introduced upb_extreg and plumbed it into decoder.	4 years ago
Joshua Haberman	823eb09694	Update all 2011 dates to 2021.	4 years ago
Joshua Haberman	e59d2c8fa7	Added license headers to all files.	4 years ago
Joshua Haberman	c358829c76	Now that handlers are gone, cleaned up table to use arenas exclusively. Also cleaned up some cruft from table.	4 years ago
Joshua Haberman	a04627abc8	Added map sorting to binary and text encoders. For the binary encoder, sorting is off by default. For the text encoder, sorting is on by default. Both defaults can be explicitly overridden. This grows code size a bit. I think we could potentially shave this (and other map-related code size) by having the generated code inject a function pointer to the map-related parsing/serialization code if maps are present. FILE SIZE VM SIZE -------------- -------------- +86% +1.07Ki +71% +768 upb/msg.c [NEW] +391 [NEW] +344 _upb_mapsorter_pushmap [NEW] +158 [NEW] +112 _upb_mapsorter_cmpstr [NEW] +111 [NEW] +64 _upb_mapsorter_cmpbool [NEW] +110 [NEW] +64 _upb_mapsorter_cmpi32 [NEW] +110 [NEW] +64 _upb_mapsorter_cmpi64 [NEW] +110 [NEW] +64 _upb_mapsorter_cmpu32 [NEW] +110 [NEW] +64 _upb_mapsorter_cmpu64 -3.6% -8 -4.3% -8 _upb_map_new +9.5% +464 +9.2% +424 upb/text_encode.c [NEW] +656 [NEW] +616 txtenc_mapentry +15% +32 +20% +32 upb_text_encode -20.1% -224 -20.7% -224 txtenc_msg +5.7% +342 +5.3% +296 upb/encode.c [NEW] +344 [NEW] +304 encode_mapentry [NEW] +246 [NEW] +208 upb_encode_ex [NEW] +41 [NEW] +16 upb_encode_ex.ch +0.7% +8 +0.7% +8 encode_scalar -1.0% -32 -1.0% -32 encode_message [DEL] -38 [DEL] -16 upb_encode.ch [DEL] -227 [DEL] -192 upb_encode +2.0% +152 +2.2% +152 upb/decode.c +44% +128 +44% +128 [section .rodata] +3.4% +24 +3.4% +24 _GLOBAL_OFFSET_TABLE_ +0.6% +107 +0.3% +48 upb/def.c [NEW] +100 [NEW] +48 upb_fielddef_descriptortype +7.1% +7 [ = ] 0 upb_fielddef_defaultint32 +2.9% +24 +2.9% +24 [section .dynsym] +1.2% +24 [ = ] 0 [section .symtab] +3.2% +16 +3.2% +16 [section .plt] [NEW] +16 [NEW] +16 memcmp@plt +0.5% +16 +0.6% +16 tests/conformance_upb.c +1.5% +16 +1.6% +16 DoTestIo +0.1% +16 +0.1% +16 upb/json_decode.c +0.4% +16 +0.4% +16 jsondec_wellknown +3.0% +8 +3.0% +8 [section .got.plt] +3.0% +8 +3.0% +8 _GLOBAL_OFFSET_TABLE_ +1.6% +7 +1.6% +7 [section .dynstr] +1.8% +4 +1.8% +4 [section .hash] +0.5% +3 +0.5% +3 [LOAD #2 [RX]] +2.8% +2 +2.8% +2 [section .gnu.version] -60.0% -1.74Ki [ = ] 0 [Unmapped] +0.3% +496 +1.4% +1.74Ki TOTAL	4 years ago
Joshua Haberman	9abf8e043f	Clamp 32-bit varints to 5 bytes to fix a fuzz failure.	4 years ago
Joshua Haberman	9c87f1168f	Added size benchmark for CODE_SIZE.	4 years ago
Joshua Haberman	358fa14d0e	Fixed headers and updated benchmark script.	4 years ago
Joshua Haberman	378a27b640	Force "size" to run locally.	4 years ago
Joshua Haberman	da48e01f05	More google3 fixes.	4 years ago
Joshua Haberman	d2446fd2db	Moved cc_api_version attribute to proto_library().	4 years ago
Joshua Haberman	4a84390c89	Added cc_proto_library() tweaks for google3.	4 years ago
Joshua Haberman	86f671d5fd	Fix for Darwin (output is different, but it won't error out).	4 years ago
Joshua Haberman	165e01ec6f	Fix for old Python versions.	4 years ago
Joshua Haberman	65d166a6ba	Added API for copy vs. alias and added benchmarks to test both. Benchmark output: $ bazel-bin/benchmarks/benchmark '--benchmark_filter=BM_Parse' 2020-11-11 15:39:04 Running bazel-bin/benchmarks/benchmark Run on (72 X 3700 MHz CPU s) CPU Caches: L1 Data 32K (x36) L1 Instruction 32K (x36) L2 Unified 1024K (x36) L3 Unified 25344K (x2) ------------------------------------------------------------------------------------- Benchmark Time CPU Iterations ------------------------------------------------------------------------------------- BM_Parse_Upb_FileDesc<UseArena, Copy> 4134 ns 4134 ns 168714 1.69152GB/s BM_Parse_Upb_FileDesc<UseArena, Alias> 3487 ns 3487 ns 199509 2.00526GB/s BM_Parse_Upb_FileDesc<InitBlock, Copy> 3727 ns 3726 ns 187581 1.87643GB/s BM_Parse_Upb_FileDesc<InitBlock, Alias> 3110 ns 3110 ns 224970 2.24866GB/s BM_Parse_Proto2<FileDesc, NoArena, Copy> 31132 ns 31132 ns 22437 229.995MB/s BM_Parse_Proto2<FileDesc, UseArena, Copy> 21011 ns 21009 ns 33922 340.812MB/s BM_Parse_Proto2<FileDesc, InitBlock, Copy> 17976 ns 17975 ns 38808 398.337MB/s BM_Parse_Proto2<FileDescSV, InitBlock, Alias> 17357 ns 17356 ns 40244 412.539MB/s	4 years ago
Joshua Haberman	881ddac7fe	Also use .format() for gen_synthetic_protos.py.	4 years ago
Joshua Haberman	8b7dabe1a2	Use format() instead of string interpolation, for old Python versions.	4 years ago
Joshua Haberman	8e08282c3b	Removed unused small.proto.	4 years ago
Joshua Haberman	0f79d47215	Added missing lite binaries to size_data.txt.	4 years ago
Joshua Haberman	555fbbc0bc	Size benchmarks are working pretty well.	4 years ago
Joshua Haberman	e5bdfba92c	Removed accidentally-added .orig file.	4 years ago
Joshua Haberman	1eb7bd39e7	Some formatting fixes.	4 years ago

1 2 3

125 Commits (34a770d13e228985e94db5ef3e9533b2dedde1c0)