protobuf

Commit Graph

Author	SHA1	Message	Date
Marcel Hlopko	73769a030d	Fix msan issue in Map<bool,*> PiperOrigin-RevId: 606164792	10 months ago
Marcel Hlopko	5842cc9c3d	Implement support for messages as map values PiperOrigin-RevId: 605581725	10 months ago
Alyssa Haroldsen	a522a47120	Validate that map keys are copied PiperOrigin-RevId: 604716574	10 months ago
Alyssa Haroldsen	d445953603	Add map key and value iterators PiperOrigin-RevId: 604495084	10 months ago
Alyssa Haroldsen	035d6ec2cb	Implement map iteration PiperOrigin-RevId: 604447996	10 months ago
Alyssa Haroldsen	a48090e329	Make map insert return if the value was newly inserted PiperOrigin-RevId: 603481207	10 months ago
Marcel Hlopko	c1d174f7d2	Stop codegenning module for .proto package PiperOrigin-RevId: 599856754	11 months ago
Jakob Buchgraber	85972e505a	#rust #protobuf Implement bytes as map values We now support fields with bytes as map values e.g. map<i32, bytes>. The implementation for the C++ runtime was straightforward. The majority of the changes in this CL are about the UPB runtime. In UPB, when we insert Rust bytes/string into the map we need to first copy the bytes onto the maps arena. To support this I have rewritten the macro that implements the ProxiedInMapValue types. I refactored the functionality to convert between UPB and Rust types into the 'UpbTypeConversions' trait. This trait has a function 'to_message_value_if_required' which does the copying for bytes and strings. PiperOrigin-RevId: 599118416	11 months ago
Jakob Buchgraber	991a2f4d54	#refactor Simplify maps through the new ProxiedInMapValue<K> trait This change is a pure refactoring and simplification of the code. We replace all MapsWith<TYPE>KeyOps traits through a single generic ProxiedInMapValue<K> trait. Through connecting the runtime maps implementation with Proxied the code gets a lot simpler e.g. we can use View<T> instead of hardcoding the concrete type behind it. I also expect this change to be beneficial for the gencode. In a subsequent CL we'll implement message values for maps. After this change we'll only have to implement a single trait, while before we had to implement num(key types) many traits. PiperOrigin-RevId: 596562909	11 months ago
Jakob Buchgraber	976029283f	Implement Maps for strings This change implements maps with keys and values of type string e.g. Map<ProtoStr, i32> and Map<ProtoStr, ProtoStr>. Implementing the Map type for ProtoStr has been different from scalar types because ProtoStr is an unsized type i.e. its size is not known at compile time. The existing Map implementation assumed sized types in many places. To make unsized types fit into the existing code architecture I have added an associated type 'Value' to the MapWith*KeyOps traits. The associated type needs to be sized and is the type returned by the Map::get(self, key) method e.g. for aProtoStr, the `type Value = &ProtoStr`. PiperOrigin-RevId: 588783751	1 year ago
Jakob Buchgraber	ac3f553073	This CL implements msg.<field>() and msg.<field_mut>() accessors for maps with primitive-typed keys and values for the UPB kernel only. Support for the CPP runtime and non-scalar value types will be implemented in follow up CLs. PiperOrigin-RevId: 580453646	1 year ago

11 Commits (321d649b519bae91c90cdebfb90a6655d9c301cd)