dmaclach
397e017c80
Remove OSReadLittle* due to alignment requirements ( #6678 )
...
The OSReadLittleInt64 function as defined by Apple reduces down to:
`return *(volatile uint64_t *)((uintptr_t)base + byteOffset);`
which means we are type-punning using a cast. On ARMv7 and other aligned architectures this can cause crashes.
Minimal example: https://gist.github.com/dmaclach/b10b0a71ae614d304c067cb9bd264336
Fixes #6679
5 years ago
Thomas Van Lenten
33da4715ea
[ObjC] Don't use unions and instead use memcpy for the type swaps. ( #6672 )
...
The code in question hasn't change in a long time so the cause of
https://github.com/firebase/firebase-ios-sdk/issues/3851 still appears to be
an Xcode 11 clang change/bug; but this does appear to be slightly better
code for the work being done.
Cleanup along the way for #6679
5 years ago
dmaclach
4702ba9043
Remove OSReadLittle* due to alignment requirements ( #6678 )
...
The OSReadLittleInt64 function as defined by Apple reduces down to:
`return *(volatile uint64_t *)((uintptr_t)base + byteOffset);`
which means we are type-punning using a cast. On ARMv7 and other aligned architectures this can cause crashes.
Minimal example: https://gist.github.com/dmaclach/b10b0a71ae614d304c067cb9bd264336
Fixes #6679
5 years ago
Thomas Van Lenten
5846439713
[ObjC] Don't use unions and instead use memcpy for the type swaps. ( #6672 )
...
The code in question hasn't change in a long time so the cause of
https://github.com/firebase/firebase-ios-sdk/issues/3851 still appears to be
an Xcode 11 clang change/bug; but this does appear to be slightly better
code for the work being done.
Cleanup along the way for #6679
5 years ago
Jan Tattermusch
378231756f
Merge pull request #6669 from ObsidianMinor/csharp/fix-comments
...
Fix incorrect Proto2 C# doc comments
5 years ago
Sydney Acksman
c54ff8d0dc
Fix many proto2 C# doc comments
5 years ago
Rafi Kamal
33151f2c87
Merge pull request #6647 from rafi-kamal/3.10.x-201909121347
...
Update protobuf version to 3.10.0 stable
5 years ago
Jie Luo
2a4657971d
Update to 3.10.0-rc0 ( #6660 )
...
* Cherry pick changes on update_version.py #6643
* Update version to 3.10.0-rc-0
* Do not add rc0 to php packages.xml
5 years ago
Joshua Haberman
a77412892c
Merge pull request #6656 from m0hamed/fix_export
...
Simplify template exporting macros
5 years ago
Paul Yang
2610eb6675
Add license ( #6651 )
5 years ago
Mohamed Heikal
4d034fecfc
Simplify template exporting macros
5 years ago
Rafi Kamal
5021cd3419
Update protobuf version
5 years ago
Rafi Kamal
90ea897492
Merge pull request #6643 from rafi-kamal/3.10.x
...
Fix update_version.py, so that PROTOBUF_VERSION is always a 9 digit number
5 years ago
Rafi Kamal
c9af9a5539
Fix update_version.py, so that PROTOBUF_VERSION is always a 9 digit number.
5 years ago
Paul Yang
763c358874
Down Integrate Internal Changes ( #6634 )
...
* Down integrate to GitHub
* Remove unintentional double assign
* Change ByteCountInt64 to int64_t
* Revert changes in binary_conformance_test.cc
* Revert unnecessary changes
5 years ago
Marco Ferrer
580f585f58
add kotlin kroto plus
5 years ago
Vperus
8e6141a63d
[csharp] Fix typo
5 years ago
Erik Moqvist
d5fbdb45b0
Added pbtools to third party implementations list.
5 years ago
Rafi Kamal
bdf32b9a17
Merge pull request #6629 from Geod24/patch-1
...
Remove duplicate entry in third party list
5 years ago
Paul Yang
7114d73dea
Implement binary conformance test for oneof fields ( #6622 )
...
* Implement binary conformance test for oneof fields
* Update failure list
* Update failure list for php c extension
5 years ago
Mathias LANG
c656d76894
Remove duplicate entry in third party list
...
On the linked Wiki page, it can be seen that the creator is `opticron`, whose Github repository is also linked, and contains a more up-to-date implementation.
5 years ago
Rafi Kamal
1363bf9c05
Merge pull request #6628 from suztomo/linakge_monitor_fix
...
Linakge Monitor fix to handle a new version of protobuf-bom not available in Maven Central
5 years ago
Tomo Suzuki
c1a046528c
MVN
5 years ago
Tomo Suzuki
f460c178fe
Local install before changing version
5 years ago
Rafi Kamal
ae1bcaad6f
Merge pull request #6621 from rafi-kamal/3.10.x-201909051012
...
Update protobuf version for Java and PHP
5 years ago
Rafi Kamal
63fc281046
Update protobuf version
5 years ago
Rafi Kamal
4e07b6347d
Merge pull request #6618 from TeBoring/3.10.x-cherrypick
...
Cherry Pick (#6614 )
5 years ago
Rafi Kamal
56bf637221
Update protobuf version
5 years ago
Paul Yang
398d37f95f
Sync upb ( #6614 )
...
* Sync upb
https://github.com/protocolbuffers/upb/pull/209
* Update upb
https://github.com/protocolbuffers/upb/pull/210
5 years ago
Paul Yang
7f520092d9
Sync upb ( #6614 )
...
* Sync upb
https://github.com/protocolbuffers/upb/pull/209
* Update upb
https://github.com/protocolbuffers/upb/pull/210
5 years ago
Roman Kamyk
dc974d22c5
Fix small style issues in the dart example, following Effective Dart:
...
- use final instead of obvious types for local variables
- add missing `void` return type
- make the comments doccomments (///)
5 years ago
Rafi Kamal
9c0d61c333
Update CHANGES.txt for version 3.10.0
5 years ago
Rafi Kamal
f3b7af24f6
Change update_version to update the generated code
5 years ago
Tim Gates
929a72d67c
Fix up simple typo: invididual -> individual
5 years ago
Mohamed Heikal
f74b560072
Enable PROTOBUF_EXPORT/PROTOBUF_USE_DLL on clang/gcc
5 years ago
Gregory Haskins
5102df2904
Add Protojure to third-party wiki ( #6554 )
...
This adds links under the Clojure header to
https://protojure.github.io
Signed-off-by: Greg Haskins <gregory.haskins@gmail.com>
5 years ago
Paul Yang
ce942bcae1
Add binary conformance tests for map fields ( #6560 )
...
* Add binary conformance tests for map fields
* Update failure list
* Fix php conformance test
* Fix php conformance test
In 32-bit platform, int64 should be string. However, map iterator returns string key as integer.
* Add more test cases for map
* Update failure list
5 years ago
Jan Tattermusch
e2f5da65ee
C#: add System.Memory dependency for net45 too ( #6317 )
...
* introduce GOOGLE_PROTOBUF_SUPPORT_SYSTEM_MEMORY
* allow building net45 target on unix systems too
* add Span<> support on net45 as well
5 years ago
Jan Tattermusch
94cbf009e9
Merge pull request #6499 from ObsidianMinor/csharp/proto2-feature/docs
...
Document proto2 feature implementations in Google.Protobuf
5 years ago
Jan Tattermusch
37bf540fd0
Merge pull request #5936 from ObsidianMinor/csharp/proto2-feature/finale
...
C# Proto2 feature : Finale
5 years ago
Sydney Acksman
c920715cf5
Remove wording indicating proto2 support is reimplemented
5 years ago
Sydney Acksman
c9a9818075
Update proto2.md
...
Reworded info about message initialization
5 years ago
Sydney Acksman
7feb16a377
Update proto2.md
...
Addressed review comments
5 years ago
Rafi Kamal
bc1773c42c
Merge pull request #6568 from ennerf/add-jigsaw-module-name
...
Java: Add Automatic-Module-Name entries to the Manifest
5 years ago
salamaniibm
7ba4a99e00
adding protoc support for s390x
5 years ago
Adam Cozzette
36bdcb5a7a
Updated issue templates to remove question form ( #6576 )
...
This commit removes the question template. It also updates the bug report and feature request templates to direct questions to the mailing list.
5 years ago
Paul Yang
e9d4e4acbc
Fix the issue for parsing zero length message ( #6592 )
...
* When length is zero, substr returns null instead of emptry string, which breaks the invariable for message.
* Tested in https://github.com/protocolbuffers/protobuf/pull/6560
5 years ago
Rafi Kamal
14b55eb128
Merge pull request #6597 from elharo/patch-3
...
Update version number
5 years ago
Thomas Van Lenten
030a38b954
Fix typo that snuck in with last commit.
5 years ago
Thomas Van Lenten
6ec27f0d08
Add an explicit test using secure coding for added safety.
5 years ago