protobuf

Commit Graph

Author	SHA1	Message	Date
Josh Haberman	5a49a33605	Responded to CR comments.	8 years ago
Josh Haberman	af79bfb919	Some refcounting fixes. Clearly this stuff is too complex overall. The plan is to move away from this and more towards pools, like proto2 uses.	8 years ago
Joshua Haberman	fa338b70a6	Added UPB_ASSERT() that helps avoid unused var warnings. * Added UPB_ASSERT() that helps avoid unused var warnings. * Addressed PR comments. * Fixed assert in the JIT.	9 years ago
Joshua Haberman	ac2689cec7	Put oneofs in the same table as fields. (#60 ) * Put oneofs in the same table as fields. Oneofs and fields are not allowed to have names that conflict, so we might as well put them all in the same table. This also allows an efficient operation that looks for both fields and oneofs in a single lookup. Added support for OneofDef to Lua to allow testing of this. * Addressed PR comments.	9 years ago
Joshua Haberman	68bc62a7fa	Split upb::Arena/upb::Allocator from upb::Environment. (#58 ) * Split upb::Arena/upb::Allocator from upb::Environment. This will allow arenas and allocators to be used independently of environments, which will be important for an upcoming change (a message representation). Overall this design feels cleaner that the previous Environment/SeededAllocator design. As part of this change, moved all allocations in upb to use a global allocator instead of hard-coding malloc/free. This will allow injecting OOM faults for more robust testing. One place that doesn't use the global allocator is the tracked ref code. Instead of its previous approach of CHECK_OOM() after every malloc() or table insert, it simply uses an allocator that does this automatically. I moved Allocator/Arena/Environment into upb.h. This seems principled since these are the only types in upb whose size is directly exposed to users, since they form the basis of memory allocation strategy. * Cleaned up some header includes and fixed more malloc -> upb_gmalloc(). * Changes from PR review. * Don't use UINTPTR_MAX or UINT64_MAX. * Punt on adding line/file for now. * We actually can't store (uint64_t)-1, update comment and test.	9 years ago
Josh Haberman	49dab06e03	Brought into compliance with Google open-source policies. - removed myself from Author headers in source files. - removed copyright notices from source file headers. - added CONTRIBUTING.md	10 years ago
Josh Haberman	919fea438a	Ported upb to C89, for greater portability. A large part of this change contains surface-level porting, like moving variable declarations to the top of the block. However there are a few more substantial things too: - moved internal-only struct definitions to a separate file (structdefs.int.h), for greater encapsulation and ABI compatibility. - removed the UPB_UPCAST macro, since it requires access to the internal-only struct definitions. Replaced uses with calls to inline, type-safe casting functions. - removed the UPB_DEFINE_CLASS/UPB_DEFINE_STRUCT macros. Class and struct definitions are now more explicit -- you get to see the actual class/struct keywords in the source. The casting convenience functions have been moved into UPB_DECLARE_DERIVED_TYPE() and UPB_DECLARE_DERIVED_TYPE2(). - the new way that we duplicate base methods in derived types is also more convenient and requires less duplication. It is also less greppable, but hopefully that is not too big a problem. Compiler flags (-std=c89 -pedantic) should help to rigorously enforce that the code is free of C99-isms. A few functions are not available in C89 (strtoll). There are temporary, hacky solutions in place.	10 years ago
Josh Haberman	e087947c84	Enabled asserts() and verbosity for most Travis builds. Also added a separate ndebug build for testing that -DNDEBUG builds still work. Also disabled reference debugging by default, since it requires either a global lock or -DUPB_THREAD_UNSAFE.	10 years ago
Josh Haberman	d869097400	Make the absence of perf-cppflags give a good default build. Defaults are now: - thread-safe with GCC/Clang - Debugging not enabled (enable with -UNDEBUG)	10 years ago
Josh Haberman	43f2455cbd	Added UPB_UNTRACKED_REF and some more handler overload options.	10 years ago
Josh Haberman	47b5e0968a	Sync from internal Google development.	11 years ago
Josh Haberman	ce9bba3cb5	Sync from Google-internal development.	11 years ago
Josh Haberman	26d98ca94f	Merge from Google-internal development: - rewritten decoder; interpreted decoder is bytecode-based, JIT decoder no longer falls back to the interpreter. - C++ improvements: C++11-compatible iterators, upb::reffed_ptr for RAII refcounting, better upcast/downcast support. - removed the gross upb_value abstraction from public upb.h.	11 years ago
Josh Haberman	7d3e2bd2c4	Sync with 8 months of Google-internal development. Many things have changed and been simplified. The memory-management story for upb_def and upb_handlers is much more robust; upb_def and upb_handlers should be fairly stable interfaces now. There is still much work to do for the runtime component (upb_sink).	12 years ago

12 Commits (298c25269555cd8d558ec40b36eadf414d7fd255)