Mike Kruskal
a80daa2a2c
Drop support for Bazel 5.
...
This moves all our CI to Bazel 6 and drops the additional parameterization we had on Bazel version.
PiperOrigin-RevId: 551986376
1 year ago
Jason Lunn
c52d80cf04
Ruby FFI implementation ( #13343 )
...
Supersedes #11483 .
Closes #13343
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/13343 from protocolbuffers:simultaneous_ffi bcb4bb7842
PiperOrigin-RevId: 550782245
1 year ago
Sandy Zhang
2278f6db94
Drop JRuby 9.2 and 9.3 from GHA test matrix
1 year ago
Jason Lunn
2402814db6
Add JRuby 9.3 and 9.4 to the test matrix under both Bazel versions. ( #13296 )
...
Prepare for 9.2 to be removed.
Closes #13296
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/13296 from protocolbuffers:jruby_version_bump 82924ab6b3
PiperOrigin-RevId: 548279470
1 year ago
Jason Lunn
59e19a7db8
Add JRuby 9.3 and 9.4 to the test matrix under both Bazel versions. ( #13296 )
...
Prepare for 9.2 to be removed.
Closes #13296
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/13296 from protocolbuffers:jruby_version_bump 82924ab6b3
PiperOrigin-RevId: 548279470
1 year ago
Joshua Haberman
3f98af287b
Updated Ruby min version to 2.7, and removed some compat code
...
PiperOrigin-RevId: 547245820
1 year ago
Mike Kruskal
ddb1f77d7a
Add daily check for 24.x staleness
...
PiperOrigin-RevId: 547017953
1 year ago
Mike Kruskal
3e9fd25ac6
Drop Bazel 4 support in upb.
...
This has already been dropped in the protobuf repo, which now supports Bazel 5 and 6.
PiperOrigin-RevId: 547007891
1 year ago
Matt Kulukundis
a5516ca6cc
Require PHP version >=8.0, Ruby >=2.7, and Python >=3.8
...
If you are running an older version of PHP, you can install a previous release
of the protobuf PHP extension by running pecl install protobuf-3.23.3.
PiperOrigin-RevId: 546056449
1 year ago
Mike Kruskal
93b5905c89
Avoid running staleness tests in scheduled CI.
...
These are designed to only run once daily in "quiet" hours to avoid race conditions. While isn't very harmful, it does cause our monitoring to show an artificial increase in flakes.
PiperOrigin-RevId: 544883830
1 year ago
Mike Kruskal
d4cd481e60
Remove excess C++14 flag in our CMake tests.
...
It's not clear what happens if both C++17/C++20 and C++14 are specified, so it's possible this was effectively disabling those tests.
PiperOrigin-RevId: 544763031
1 year ago
Mike Kruskal
ea51496f6e
Allow safety tag removal from GHA.
...
This was broken by a recent lockdown of GHA permissions.
PiperOrigin-RevId: 543531770
1 year ago
Sandy Zhang
80264f7cab
Add GHA UPB macOS bazel coverage for Apple Silicon
...
This is based on cl/525134469 which sets up coverage for C++
PiperOrigin-RevId: 542600526
1 year ago
Mike Kruskal
d1d7502444
Delete codespell presubmit.
...
This has caused repeated issues due to the fact that it checks the entire repo. Most recently, it decided to complain about a typo in a file that hasn't been touched in 5 years.
PiperOrigin-RevId: 540356791
2 years ago
Mike Kruskal
b1df92704b
Clean up staleness tests.
...
Our automation can't currently update release branches, so we need to enable staleness tests as presubmits to force manual regeneration.
PiperOrigin-RevId: 540094169
2 years ago
Tomo Suzuki
2fd29b0b73
Move linkage monitor check as part of Bazel build ( #12980 )
...
Fixes https://github.com/protocolbuffers/protobuf/issues/12912
Moving the Linkage Monitor check to Bazel, so that the result is cached.
Closes #12980
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12980 from suztomo:bazelize_linkage_monitor 51c00949ba
PiperOrigin-RevId: 539681611
2 years ago
Mike Kruskal
4031712c34
Drop Bazel 4 support and add Bazel 6
...
PiperOrigin-RevId: 539130329
2 years ago
Mike Kruskal
d90c3e7c4f
Fix staleness test branching logic
...
PiperOrigin-RevId: 538812352
2 years ago
Marcel Hlopko
ff750bb4c3
Put shared.rs and cpp.rs/upb.rs into the same crate.
...
The motivation is to make the setup simpler and more flexible.
PiperOrigin-RevId: 538189061
2 years ago
Marcel Hlopko
f92edc13c2
Automated rollback of commit fe7c4f9422
.
...
PiperOrigin-RevId: 538128679
2 years ago
Joyce
010fde9a18
Set top level permissions to read only on GitHub Workflows ( #12971 )
...
Hi, here is Joyce from Google again.
I'd like starting suggesting the [Token-Permission check](https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions ) fix.
Let me know if I might be missing any permission. Thanks!
### Security Reason
This is needed because, by default, github grants write-all permission to all workflows, which could be exploit by an attacker in case of a compromised workflow. Limiting permissions is a simple and effective way to also limit the impact of an eventual compromised workflow.
Thus, it is both a recommendation from [OpenSSF Scorecard](https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions ) and the [Github](https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions ) to always use credentials that are minimally scoped.
Closes #12971
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12971 from joycebrum:main 6d6dac5678
PiperOrigin-RevId: 537973051
2 years ago
Mike Kruskal
0b9b5da7a7
Cleanup scheduled staleness tests.
...
- Do some minimal sanity testing on every PR
- Only run the staleness tests on a daily schedule or explicit runs.
- Add 23.x to the checks
PiperOrigin-RevId: 537952151
2 years ago
Mike Kruskal
722d6f5897
Disable non-hermetic breakage due to github runner update
...
See https://github.com/actions/runner-images/issues/7662
PiperOrigin-RevId: 537946689
2 years ago
Marcel Hlopko
03b53f404c
Update staleness test worker
...
Currently the test fails because the Bazel version is too old for the Rust subproject (https://github.com/protocolbuffers/protobuf/actions/runs/5154290452/jobs/9282571385 )
PiperOrigin-RevId: 537323723
2 years ago
Marcel Hlopko
fe7c4f9422
Simplify Protobuf Rust runtime build setup
...
PiperOrigin-RevId: 537300231
2 years ago
Marcel Hlopko
b14ad422ca
Fix staleness test workflow
...
PiperOrigin-RevId: 537256933
2 years ago
Carlos O'Ryan
4b414d60ee
Squashed 'third_party/utf8_range/' changes from 72c943dea..d863bc33e
...
d863bc33e cleanup: avoid "unused function" errors in OSS land
f4948c4f2 internal change
cd1507d14 Fix typo in pkg-config file to properly link the utf8_range libraries
3f179d134 Add pkg-config file declaring Abseil dependency of utf8_range
git-subtree-dir: third_party/utf8_range
git-subtree-split: d863bc33e15cba6d873c878dcca9e6fe52b2f8cb
2 years ago
Mike Kruskal
4b1c4965e4
Persist COMPOSER_HOME so that we don't continue to query remote servers
...
PiperOrigin-RevId: 534968948
2 years ago
Mike Kruskal
9657172749
Use composer action for dependency caching.
...
This will reduce the flakes we've seen in PHP tests.
PiperOrigin-RevId: 534226922
2 years ago
Mike Kruskal
e15326ba80
Add a workaround for GCC constexpr bug
...
This turns the constexpr constructors into templates to silence errors when constexpr isn't valid. We are also switching to 12.2 for GCC/cmake tests to prevent regressions (9.5 and 13.1 are already tested by GCC/bazel tests).
Fixes #12807
PiperOrigin-RevId: 532258101
2 years ago
Mike Kruskal
d4ef42aa9b
Fix C++17 gcc issues.
...
This also adds tests for C++17 and C++20 to prevent further regressions.
PiperOrigin-RevId: 530693318
2 years ago
deannagarcia
0e23f18865
Merge to main after 23.0 release ( #12721 )
...
Closes #12721
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12721 from protocolbuffers:main-202305082101 36482b4c68
PiperOrigin-RevId: 530664393
2 years ago
Protobuf Team Bot
67d9ea87f3
Internal change
...
PiperOrigin-RevId: 530619366
2 years ago
Mike Kruskal
bc9a1d219e
Add tests for GCC support window.
...
Note: gcc only supports docker images down to 9.5, and the 7.3 image is very old and problematic. A follow-up change might enable testing for GCC 7.3, which is our minimal supported version
PiperOrigin-RevId: 529885733
2 years ago
Mike Kruskal
da2c4a6ce9
Add tests for GCC support window.
...
Note: gcc only supports docker images down to 9.5, and the 7.3 image is very old and problematic. A follow-up change might enable testing for GCC 7.3, which is our minimal supported version
PiperOrigin-RevId: 529885733
2 years ago
Mike Kruskal
54caf40312
Avoid using string(JOIN..., which requires cmake 3.12
...
This also downgrades our tests to use cmake 3.10, compatible with our support window.
Closes #12672
PiperOrigin-RevId: 529840763
2 years ago
Mike Kruskal
adee0a59f9
Avoid using string(JOIN..., which requires cmake 3.12
...
This also downgrades our tests to use cmake 3.10, compatible with our support window.
Closes #12672
PiperOrigin-RevId: 529840763
2 years ago
Mike Kruskal
5f97a7f494
Define a new set of cmake tests.
...
These more closely follow the standard practices of our users, where dependencies are pre-installed instead of using our provided sub-modules. This will prevent issues such as #12201 from reoccuring.
Additionally, this cl bumps our Abseil dependency to the latest release, and fixes a GTest issue that went previously unnoticed.
PiperOrigin-RevId: 529490402
2 years ago
Mike Kruskal
7714d57c91
Define a new set of cmake tests.
...
These more closely follow the standard practices of our users, where dependencies are pre-installed instead of using our provided sub-modules. This will prevent issues such as #12201 from reoccuring.
Additionally, this cl bumps our Abseil dependency to the latest release, and fixes a GTest issue that went previously unnoticed.
PiperOrigin-RevId: 529490402
2 years ago
Mike Kruskal
24d3e74ac9
Remove --remote argument in cmake tests.
...
This will prevent non-hermetic breakages from changes to the Abseil release branch we're pinned to.
PiperOrigin-RevId: 529459765
2 years ago
Mike Kruskal
5223f56dba
Remove --remote argument in cmake tests.
...
This will prevent non-hermetic breakages from changes to the Abseil release branch we're pinned to.
PiperOrigin-RevId: 529459765
2 years ago
Deanna Garcia
74cea3dda5
Revert "Fix tests"
...
This reverts commit 645336fb8a
.
2 years ago
Deanna Garcia
645336fb8a
Fix tests
2 years ago
Thomas Van Lenten
2282505327
Move to proto_common for all upb aspects to fix numerous tricky edge cases and simplify the code
...
PiperOrigin-RevId: 527937369
2 years ago
Joshua Haberman
88d5b91810
Move to proto_common for all upb aspects to fix numerous tricky edge cases and simplify the code
...
PiperOrigin-RevId: 527904449
2 years ago
Mike Kruskal
0b73dd44a3
Add -ex switch to all docker bash commands. ( #12601 )
...
Without this, certain failures will be silently ignored.
PiperOrigin-RevId: 527718574
2 years ago
Mike Kruskal
f6c7fdf88c
Add -ex switch to all docker bash commands.
...
Without this, certain failures will be silently ignored.
PiperOrigin-RevId: 527718574
2 years ago
Deanna Garcia
d19c7997ab
Fix bom tests
2 years ago
Deanna Garcia
99c9491f7c
Fix maven pom test
2 years ago
Mike Kruskal
2230d0e748
Fix homebrew issue on Mac runners causing PHP CI failures
...
PiperOrigin-RevId: 527419345
2 years ago