protobuf

Commit Graph

Author	SHA1	Message	Date
Sergio Campama	b1f954e639	Improves coverage of GPBCodedInputStream	7 years ago
Thomas Van Lenten	ecc0f54127	Properly error on a tag with field number zero.	8 years ago
Thomas Van Lenten	ddb438855a	Raise the recursion limit to 100 to match other languages.	8 years ago
Sergio Campamá	d58b92ae51	Adds pushLimit: and popLimit: into GPBCodedInputStream (#2297 ) Adds pushLimit: and popLimit: into GPBCodedInputStream	8 years ago
Thomas Van Lenten	c18aa7795a	Validate the tag numbers when parsing. (#1725 ) There was a twist code path (that some times showed up due to what happened to be in memory in failure cases), that would cast a bogus wire type into the enum, and then fall through switch statements. Resolve this by validating all wire types when parsing tags and throwing the error at that point so it can't enter the system. As added safety, stick in a few asserts for apis that get passed tags to ensure they also are only seeing valid data. Bonus: Tweak the parsing loop to skip some work when we get the end marker (zero tag) instead of still looping through all the fields.	9 years ago
Sergio Campamá	e34c09182e	Improving the granularity parsing errors (#1623 ) Add more context to GPBCodedInputStream failures. Have GPBMessage parsing apis extract out the GPBCodedInputStream information and expose it. Update HeaderDocs with pointers to all error domains/codes. Expand the unittests to cover the full set of errors reported. Fixes https://github.com/google/protobuf/issues/1618	9 years ago
Thomas Van Lenten	c8a440dfb6	Add more warnings to for the ObjC runtime build Working on https://github.com/google/protobuf/issues/1599, specifically: - Turn on more warnings that the Xcode UI calls out with individual controls. - Manually add: -Wundef -Wswitch-enum - Manually add and then diable in the unittests because of XCTest's headers: -Wreserved-id-macro -Wdocumentation-unknown-command - Manually add -Wdirect-ivar-access, but disable it for the unittests and in the library code (via #pragmas to suppress it). This is done so proto users can enable the warning.	9 years ago
Thomas Van Lenten	c9167f2acd	Error during parsing for invalid UTF-8 instead of dropping dropping data. This seems to be some code evolution side effects. Back when there was a custom string class, we couldn't really error when we finally saw the string was bad so we had to return the empty string, but now that full validation is done up front, it can error out.	9 years ago
Thomas Van Lenten	331cee5022	Add -position and -isAtEnd for use when manually parsing input streams.	9 years ago
Thomas Van Lenten	d6590d6534	Drop all use of OSSpinLock Apple engineers have pointed out that OSSpinLocks are vulnerable to live locking on iOS in cases of priority inversion: . http://mjtsai.com/blog/2015/12/16/osspinlock-is-unsafe/ . https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20151214/000372.html - Use a dispatch_semaphore_t within the extension registry. - Use a dispatch_semaphore_t for protecting autocreation within messages. - Drop the custom/internal GPBString class since we don't have really good numbers to judge the locking replacements and it isn't required. We can always bring it back with real data in the future.	9 years ago
Thomas Van Lenten	ba800e2e57	Set the stream limit to the length of the data. - Mark all conformance tests as now passing.	9 years ago
Thomas Van Lenten	d846b0b059	Beta quality drop of Objective C Support. - Add more to the ObjC dir readme. - Merge the ExtensionField and ExtensionDescriptor to reduce overhead. - Fix an initialization race. - Clean up the Xcode schemes. - Remove the class/enum filter. - Remove some forced inline that were bloating things without proof of performance wins. - Rename some internal types to avoid conflicts with the well know types protos. - Drop the use of ApplyFunctions to the compiler/optimizer can do what it wants. - Better document some possible future improvements. - Add missing support for parsing repeated primitive fields in packed or unpacked forms. - Improve -hash. - Add *Count for repeated and map<> fields to avoid auto create when checking for them being set.	10 years ago
Thomas Van Lenten	30650d81d9	Alpha 1 drop of Google's Objective C plugin and runtime support for protobufs.	10 years ago

13 Commits (1681fe664b2bbe5ced9a5094322f375515a2e149)