protobuf

Commit Graph

Author	SHA1	Message	Date
Alyssa Haroldsen	1dd6a7d06e	Clean up some trivial lifetime usage - Rename most usage of `'a` to `'msg` - Remove a no-op unused lifetime param for `remove` in maps - Elide lifetimes recommended by clippy PiperOrigin-RevId: 589878364	1 year ago
Jakob Buchgraber	ab11a0d1a8	Name the lifetime in the signature of SettableValue.set_on() This change names the lifetime of Mut<'a, T> and requires that T outlives 'a. The motivation for this change came up while implementing `Map<K, ProtoStr>`. The Map implementation makes it so that `V` needs to implement the `MapWithKeyOps` trait which has an associated type with a lifetime (`Value<'a>`. The lifetime bound on `T` ensures that e.g. for `MapWithKeyOps<Value<'b>=&'b ProtoStr>` `'a` outlives `'b`. PiperOrigin-RevId: 585657154	1 year ago
Sandy Zhang	81068e8e8c	Internal change PiperOrigin-RevId: 566426899	1 year ago
Joshua Haberman	4a513035cf	Shorten our license headers into an abbreviated form that references LICENSE instead of including it in full. PiperOrigin-RevId: 563888892	1 year ago
Alyssa Haroldsen	614e29f946	Implement v0.6 string fields This is predominantly a wrapper around `BytesMut`, for simplicity. Bytes and string fields are mostly the same, except for possible UTF-8 handling. This also implements some minor parts of `ProtoStr` that were missed. PiperOrigin-RevId: 561422951	1 year ago
Alyssa Haroldsen	d5d207f099	Move common macros to a shared location PiperOrigin-RevId: 559855079	1 year ago
Alyssa Haroldsen	9a0bc392b3	Implement v0.6 Optional Bytes This makes a few changes: - It changes generated messages to reference message innards as a type in `__runtime` instead of branching on what fields should be there. That results in much less bifurcation in gencode and lets runtime-agnostic code reference raw message innards. - It adds a generic mechanism for creating vtable-based mutators. These vtables point to thunks generated for interacting with C++ or upb fields. Right now, the design results in 2-word (msg+vtable) mutators for C++ and 3-word mutators (msg+arena+vtable) for UPB. See upb.rs for an explanation of the design options. I chose the `RawMessage+&Arena` design for mutator data as opposed to a `&MessageInner` design because it did not result in extra-indirection layout changes for message mutators. We could revisit this in the future with performance data, since this results in all field mutators being 3 words large instead of the register-friendly 2 words. - And lastly, as a nearby change that touches on many of the same topics, it adds some extra SAFETY comments for Send/Sync in message gencode. PiperOrigin-RevId: 559483437	1 year ago
Protobuf Team Bot	4b0e76370b	Add UTF-8 handling to ProtoStr This mostly uses a copied `Utf8Chunks` utility from nightly Rust. PiperOrigin-RevId: 551224417	1 year ago
Protobuf Team Bot	49d3bca39f	Improve overall `unsafe` hygiene This adds `#![deny(unsafe_op_in_unsafe_fn)]` which removes the implicit `unsafe` block that `unsafe fn` does. It also adds many more `SAFETY` docs, corrects some incomplete ones, and catches a null pointer returned by `upb_Arena_New`. PiperOrigin-RevId: 549067106	1 year ago
Protobuf Team Bot	8fe9d8e7c1	Define the shape of ProtoStr as a DST PiperOrigin-RevId: 547871451	1 year ago
Protobuf Team Bot	230a9a751f	Remove stubs for in-place mutating BytesMut operations These are invalid for UPB which uses immutable string views. This also adjusts some docs: - removes a promise in the language of `truncate` that no reallocation will occur. - removes language about DerefMut and replaces the `&mut Vec<u8>` analogy PiperOrigin-RevId: 547603918	1 year ago
Protobuf Team Bot	a75def66cd	Define the shape of BytesMut with stubbed methods This is the primary mutator for `bytes` fields, which proxy `[u8]`. PiperOrigin-RevId: 547242972	1 year ago

12 Commits (1658213ba84a641531948aa9cdc3b53bebf20190)