protobuf

Commit Graph

Author	SHA1	Message	Date
Joshua Haberman	754b9f1cfd	All tests pass again!	6 years ago
Joshua Haberman	cb26d883d1	WIP.	6 years ago
Joshua Haberman	d2f9bec5c6	Removed old-style C++ handlers that relied on UB in favor of more normal ones.	6 years ago
Joshua Haberman	0553eff64a	upb_refcounted is gone! Some tests still to fix.	6 years ago
Joshua Haberman	380558922b	test_encoder passes! Other tests still need to be fixed.	6 years ago
Joshua Haberman	ffae78df27	Updated encoder to new API.	6 years ago
Joshua Haberman	7ff8413a03	Ported some tests.	6 years ago
Joshua Haberman	68bc62a7fa	Split upb::Arena/upb::Allocator from upb::Environment. (#58 ) * Split upb::Arena/upb::Allocator from upb::Environment. This will allow arenas and allocators to be used independently of environments, which will be important for an upcoming change (a message representation). Overall this design feels cleaner that the previous Environment/SeededAllocator design. As part of this change, moved all allocations in upb to use a global allocator instead of hard-coding malloc/free. This will allow injecting OOM faults for more robust testing. One place that doesn't use the global allocator is the tracked ref code. Instead of its previous approach of CHECK_OOM() after every malloc() or table insert, it simply uses an allocator that does this automatically. I moved Allocator/Arena/Environment into upb.h. This seems principled since these are the only types in upb whose size is directly exposed to users, since they form the basis of memory allocation strategy. * Cleaned up some header includes and fixed more malloc -> upb_gmalloc(). * Changes from PR review. * Don't use UINTPTR_MAX or UINT64_MAX. * Punt on adding line/file for now. * We actually can't store (uint64_t)-1, update comment and test.	9 years ago
Josh Haberman	f8c26358f0	Changes for PR comments.	9 years ago
Josh Haberman	e9d79d2441	Added upb::FileDef, which represents the file defs are declared in. It is entirely optional: MessageDef/EnumDef can still exist on their own. But this can represent a def's file when it is desirable to do so (eg. for code generators). This approach will require that we change the way we handle extensions. But I think it will be a good change overall. Specifically, we previously handled extensions by duplicating the extended message and then adding the extension as a regular field to the duplicated message. This required also duplicating any messages that could reach the extended message. In the new world we will need a way of declaring and looking up extensions separately from the message being extended. This change also involves some notable changes to the generated code: - files are now called foo.upbdefs.h instead of foo.upb.h. This reflects the fact that we might possibly generate several different output files for a .proto file, and this one is just for defs. - we no longer generate selectors in the .h file. - the upbdefs.c no longer vends a SymbolTable. Now it vends the individual messages (and possibly a FileDef later). I think this will compose better once we can generate files where one generated files imports another. We also make the descriptor reader vend a list of FileDefs now. This is the best conceptual match for parsing a FileDescriptorSet.	9 years ago
Josh Haberman	c3e9a57a6f	Fixed some bad bugs in upb_env. Also added a unit test for upb_encoder that demonstrates the bugs and the fix.	10 years ago

11 Commits (1508648f30cbaf5a3590572b2313fb5b595a7946)