deannagarcia
f1c7820c9b
Suppress -Wunused-parameter warning for GCC and clang. ( #12355 )
...
* Suppress -Wunused-parameter warning for GCC and clang.
Closes https://github.com/protocolbuffers/protobuf/issues/12313
PiperOrigin-RevId: 520066451
* Remove unintended cherrypicked line
2 years ago
Mike Kruskal
f128ced675
Internal Code Change
...
PiperOrigin-RevId: 520076528
2 years ago
Deanna Garcia
8aff59e1c4
Suppress -Wunused-parameter warning for GCC and clang.
...
Closes https://github.com/protocolbuffers/protobuf/issues/12313
PiperOrigin-RevId: 520066451
2 years ago
Protobuf Team Bot
6ae84761bf
Auto-generate files after cl/520049946
2 years ago
Mike Kruskal
3f4af6661a
Internal Code Change
...
PiperOrigin-RevId: 520049946
2 years ago
Jakob Buchgraber
4745f526d4
Small style guide, naming and formatting fixes
...
PiperOrigin-RevId: 519993508
2 years ago
Jakob Buchgraber
8c92452c99
Split UPB and C++ kernel codegen into their own functions
...
PiperOrigin-RevId: 519977094
2 years ago
Protobuf Team Bot
e2f3d64742
Internal change.
...
PiperOrigin-RevId: 519859619
2 years ago
Mike Kruskal
dff36c7d02
Update source code info when stripping source-retention options
...
When we invoke protoc with `--include_source_info --descriptor_set_out`, we
currently strip out source-retention options but without doing the
corresponding stripping of the source code info. This CL fixes that problem by
making sure to strip the same entities from source code info that we stripped
from the main part of the descriptors.
PiperOrigin-RevId: 519831383
2 years ago
Mike Kruskal
0549e52188
Internal Code Change
...
PiperOrigin-RevId: 519775744
2 years ago
cpovirk
d60af33f09
Internal Change
...
PiperOrigin-RevId: 519771456
2 years ago
Protobuf Team Bot
5b59a02b91
Auto-generate files after cl/519752053
2 years ago
Mike Kruskal
145900f06c
Open-source extension declaration definition.
...
PiperOrigin-RevId: 519752053
2 years ago
Protobuf Team Bot
3a871acca0
Fix internal build breakage
...
PiperOrigin-RevId: 519277200
2 years ago
Adam Cozzette
42c2b7ec60
Internal change
...
PiperOrigin-RevId: 519260063
2 years ago
Jie Luo
6ecb5d097e
Added Reflection::GetCord() method in C++
...
PiperOrigin-RevId: 519246549
2 years ago
Jonas Kvinge
477e35f4c2
Add missing cstdint include to port.h ( #12331 )
...
Fixes compile errors with GCC 13.
port.h:186:67: error: ‘uint32_t’ was not declared in this scope
port.h:187:67: error: ‘uint64_t’ was not declared in this scope
Closes #12331
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12331 from jonaski:cstdint 9bef449478
PiperOrigin-RevId: 519208789
2 years ago
Mike Kruskal
3e188b7c04
Automated rollback of commit 1d7bda4a78
.
...
PiperOrigin-RevId: 519177322
2 years ago
Yamamoto, Hirotaka
620eebecde
Add Cybozu to options.md ( #12324 )
...
Hello.
We want to make our protobuf repository public which contains a custom extension.
Our code is already available at https://github.com/cybozu/protobuf .
Please let us use extension number 1179.
Regards,
Closes #12324
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12324 from ymmt2005:patch-1 b0a5171211
PiperOrigin-RevId: 519022489
2 years ago
Protobuf Team Bot
53f3cf8e15
Internal changes
...
PiperOrigin-RevId: 519008855
2 years ago
Martijn Vels
dbbe317b4f
Small optimization: move TcParser::Error() out of line
...
PiperOrigin-RevId: 518943474
2 years ago
Jakob Buchgraber
ef53613b42
Add GHA workflow for Rust
...
PiperOrigin-RevId: 518933228
2 years ago
Protobuf Team Bot
4562c1c235
Internal change.
...
PiperOrigin-RevId: 518884627
2 years ago
Protobuf Team Bot
34517b6456
Internal changes to extensions.
...
PiperOrigin-RevId: 518691032
2 years ago
Eric Salo
dfb71558a2
sync to current upb and enable new unit test on upb
...
PiperOrigin-RevId: 518643876
2 years ago
Jakob Buchgraber
7802b93442
Fix build errors in Protobuf Rust
...
PiperOrigin-RevId: 518619271
2 years ago
cpovirk
9a76b96cc4
Internal change.
...
PiperOrigin-RevId: 518582206
2 years ago
cpovirk
2b663464ea
Internal change.
...
PiperOrigin-RevId: 518574031
2 years ago
Protobuf Team Bot
a7087a0376
Automated rollback of commit f7e6c46824
.
...
PiperOrigin-RevId: 518572689
2 years ago
Eric Salo
579f4ab70d
fix Python bug with required fields
...
https://github.com/protocolbuffers/upb/issues/1220
There were two bugs here: Python was incorrectly mandating that a required
field be set during assignment, and it was also incorrectly assuming a non-NULL
return from an internal function call.
PiperOrigin-RevId: 518561818
2 years ago
deannagarcia
dbc918c6d0
Delete cmake/CMakeLists.txt in favor of CMakeLists.txt ( #12295 )
...
This fixes https://github.com/protocolbuffers/protobuf/issues/12263 , but we will not cherrypick to 22.x since it could be breaking.
Closes #12295
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12295 from deannagarcia:deleteExtraCmakeFile 8fe901aee2
PiperOrigin-RevId: 518456432
2 years ago
Protobuf Team Bot
e56cf5d8d4
Auto-generate files after cl/518395462
2 years ago
Mike Kruskal
2456753603
Mark singular `target` field option deprecated.
...
This was always designed to be repeated, and the singular one should never be used.
PiperOrigin-RevId: 518395462
2 years ago
deannagarcia
58ecf38aa5
Merge pull request #12303 from protocolbuffers/deannagarcia-patch-4
...
Add codespell exceptions
2 years ago
deannagarcia
cb009b29fa
Merge pull request #12301 from mkruskal-google/cmake-fix
...
Only include utf8_range if it hasn't been included already
2 years ago
deannagarcia
6e624e4f6b
Add codespell exceptions
...
Codespell is failing on 22.x mostly because there were changes made to this file in main that weren't added to 22.x. This adds the extra exceptions.
2 years ago
Mike Kruskal
c4005f2c92
Only include utf8_range if it hasn't been included already
...
PiperOrigin-RevId: 518361290
2 years ago
Protobuf Team Bot
f73c7cb74a
Add license rules
...
PiperOrigin-RevId: 518370510
2 years ago
Mike Kruskal
10327708f8
Create a helper for converting ErrorLocation to a string
...
PiperOrigin-RevId: 518369193
2 years ago
Mike Kruskal
1f11d71181
Only include utf8_range if it hasn't been included already
...
PiperOrigin-RevId: 518361290
2 years ago
Protobuf Team Bot
f7e6c46824
Reduce stack usage of MessageDifferencer in two ways:
...
- Replace uses of stack-based FixedArray instances with a heap-based stack.
This new stack amortizes memory allocations.
- Remove local variables of SpecificField. These are quite large and we only
use them temporarily to push into the vector. Better to push early and use the
value from the vector directly.
PiperOrigin-RevId: 518320703
2 years ago
Jie Luo
714f975026
Support C++ protobuf ctype=CORD for bytes field (generated code).
...
Reflection::SetString() can take CORD as input.
PiperOrigin-RevId: 518313997
2 years ago
Protobuf Team Bot
4b5652b030
Re-attach OSGI headers to lite,core, and util. This information was dropped in the move from maven to bazel.
...
PiperOrigin-RevId: 518267412
2 years ago
Protobuf Team Bot
bf1ae222c9
Update proto parsing to keep track of parsed fields that have no presence and were parsed to their default value, hence had no effect on the result proto.
...
Update the Partially proto matcher to cause proto parsing to check fail if the above condition was triggered.
This is to address a known issue where test are silently passing when proto3 protos are the arguments to Partially(EqualsProto) and have some of the fields ignored by the EqualsProto matcher since they were set to their default value in the expected proto.
PiperOrigin-RevId: 518262030
2 years ago
Protobuf Team Bot
35ffb665e2
Auto-generate files after PR #12262
2 years ago
Jon Skeet
4326e0f852
Make json_name take priority over name (fully) in C# parsing ( #12262 )
...
Fixes #11987
(testprotos.pb and UnittestIssues.pb.cs are both generated; no need to review.)
Closes #12262
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12262 from jskeet:json-mapping 95785247b7
PiperOrigin-RevId: 518186721
2 years ago
Joris Clement
38ab857472
Make warning message type more specific ( #12272 )
...
The minimum required CMake version is 3.5. Thus, this message type is supported.
Ref.:
https://cmake.org/cmake/help/v3.5/command/message.html
Closes #12272
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12272 from joclement:patch-1 c7528889a6
PiperOrigin-RevId: 518185074
2 years ago
Karthikeyan Singaravelan
decc1b5708
Update deprecated aliases for Python 3.12 compatibility. ( #12254 )
...
https://docs.python.org/3.12/whatsnew/3.12.html#removed . `assertRaisesRegexp` was removed in favor of `assertRaisesRegex`
Closes #12254
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12254 from tirkarthi:fix-assert 922f3ceccc
PiperOrigin-RevId: 518181080
2 years ago
Jon Skeet
0dda953e06
Fix compile-time error for Google.Protobuf in C# 11 ( #12261 )
...
Note that the error only affects users trying to build Google.Protobuf directly using C# 11. It doesn't affect users who are compiling code against the pre-built library (which is likely to be basically everyone).
Fixes #11004 .
(This is code I'm less familiar with than most of the library, and I'd be nervous of making any more wide-ranging changes. This seems pretty safe though.)
cc @JamesNK who first noticed this.
Closes #12261
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/12261 from jskeet:csharp-11 6bf22b892b
PiperOrigin-RevId: 518178901
2 years ago
Protobuf Team Bot
5d3d9aa372
Auto-generate files after cl/518088680
2 years ago