protobuf

16266 Commits

201 Branches

346 Tags

254 MiB

Tag: Branch: Tree: 08d8b80b22

Commit Graph

Author	SHA1	Message	Date
Jakob Buchgraber	245a6e692a	Remove the protobuf::__runtime::Map type Before this change the runtimes export a Map and MapInner. This change merges the Map and MapInner types into a single MapInner type, removing the Map type from the runtime (upb.rs, cpp.rs). The motivation for this change is twofold: 1) A separate Map type is not strictly needed by the runtime. I hope this reduces some complexity. 2) After this change we can introduce a runtime-agnostic protobuf::Map type that implements Proxied. PiperOrigin-RevId: 582978008	1 year ago
Jakob Buchgraber	001be3c655	Implement Maps for scalar types for the C++ kernel This CL implements Maps for scalar types for the C++ runtime. It's orthogonal to cl/580453646. This CL is constrained by having to force template instantiation of proto2::Map<K, V>. Put differently, a Rust protobuf::Map<K, V> implementation needs to call 'extern "C"' functions with both key and value type in the function name (e.g. __pb_rust_Map_i32_f64_get()). We use macros to generate a Map implementation for every (K,V)-pair. An alternative would have been to use vtables. Luckily a key in a protobuf map can only be integer types, bool and string. So the number of key types is bounded by the specification, while the number of value types is not i.e. any protobuf message can be a value in a map. Given these constraints we introduce one 'MapKeyOps' trait per key type e.g. MapKeyBOOLOps or MapKeyI32Ops. These traits need to be implemented for every value type e.g. 'impl MapKeyBOOLOps for i32' will implement 'Map::<bool, i32>'. In particular the MapKeyOps traits can also be implemented for generated messages without violating the orphan rule. This CL also contains significant changes to the UPB runtime so that both upb.rs and cpp.rs export a similar interface to simplify the implementation in map.rs and the generated code. This CL does not yet implement the Proxied trait. PiperOrigin-RevId: 582951914	1 year ago
Jakob Buchgraber	ac3f553073	This CL implements msg.<field>() and msg.<field_mut>() accessors for maps with primitive-typed keys and values for the UPB kernel only. Support for the CPP runtime and non-scalar value types will be implemented in follow up CLs. PiperOrigin-RevId: 580453646	1 year ago

Author

SHA1

Message

Date

Jakob Buchgraber

245a6e692a

Remove the protobuf::__runtime::Map type

Before this change the runtimes export a Map and MapInner. This change merges the Map and MapInner types into a single MapInner type, removing the Map type from the runtime (upb.rs, cpp.rs).

The motivation for this change is twofold:
 1) A separate Map type is not strictly needed by the runtime. I hope this reduces some complexity.
 2) After this change we can introduce a runtime-agnostic protobuf::Map type that implements Proxied.

PiperOrigin-RevId: 582978008

1 year ago

Jakob Buchgraber

001be3c655

Implement Maps for scalar types for the C++ kernel

This CL implements Maps for scalar types for the C++ runtime. It's orthogonal to cl/580453646. This CL is constrained by having to force template instantiation of proto2::Map<K, V>. Put differently, a Rust protobuf::Map<K, V> implementation needs to call 'extern "C"' functions with both key and value type in the function name (e.g. __pb_rust_Map_i32_f64_get()). We use macros to generate a Map implementation for every (K,V)-pair. An alternative would have been to use vtables.

Luckily a key in a protobuf map can only be integer types, bool and string. So the number of key types is bounded by the specification, while the number of value types is not i.e. any protobuf message can be a value in a map. Given these constraints we introduce one 'MapKeyOps' trait per key type e.g. MapKeyBOOLOps or MapKeyI32Ops. These traits need to be implemented for every value type e.g. 'impl MapKeyBOOLOps for i32' will implement 'Map::<bool, i32>'. In particular the MapKeyOps traits can also be implemented for generated messages without violating the orphan rule.

This CL also contains significant changes to the UPB runtime so that both upb.rs and cpp.rs export a similar interface to simplify the implementation in  map.rs and the generated code.

This CL does not yet implement the Proxied trait.

PiperOrigin-RevId: 582951914

1 year ago

Jakob Buchgraber

ac3f553073

This CL implements msg.<field>() and msg.<field_mut>() accessors for maps with primitive-typed keys and values for the UPB kernel only.

Support for the CPP runtime and non-scalar value types will be implemented in follow up CLs.

PiperOrigin-RevId: 580453646

1 year ago

3 Commits (08d8b80b22a28ac2958617dc48b9a76b7648ed41)